Adding json lines (jsonl) serializer ro django

107 views
Skip to first unread message

Ali Vakilzade

unread,
Dec 16, 2019, 6:06:58 PM12/16/19
to Django developers (Contributions to Django itself)
Hey!

A few month ago I opened a ticket for adding jsonl support to django serializers, I have added a basic patch as the starting point but my ticket was closed because it needed more discussion on the mailing list, I'm willing to work more on my patch to reach a final state (adding more tests and updating docs) but before working more on it just wanted to get the green light or some direction from you :-)


Thanks

Adam Johnson

unread,
Dec 16, 2019, 6:45:42 PM12/16/19
to django-d...@googlegroups.com
Hi Ali

Thanks for coming back to this. As I wrote on the ticket I'd be in favour of adding this.

If you've got some code already it'd be good to see it in a PR

As for your question about overly long lines I think the .replace() style is fine, or a consrtuction like this:

''.join([
    "{"
    '"key1": "value1",
    "}",
])

Django contributions are not just about core developers giving you the green light; you'll need to be a bit persistent to follow the coding guides, fix test errors, respond to feedback, and push the patch through. But given you've returned after 10 months I'm sure you can!

Thanks,

Adam


--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/17a919f1-559d-4599-85c8-236a9df5cf6e%40googlegroups.com.


--
Adam
Reply all
Reply to author
Forward
0 new messages