I tend to agree with Adam.
From a UI/UX perspective, the location where the "Clear all filters" button is, as well as the wording, suggest to me that it's only the filters on the right side. The search query, while technically filtering the query set, doesn't seem like a filter in the UI.
I'd potentially argue otherwise if the search field was in the filter box on the right.
Additionally, looking at it from the back-end, search terms and filters have nothing in common except for the queryset.
Cheers,
Markus
On Mon, May 18, 2020, at 11:10 AM, Mariusz Felisiak wrote:
> > I disagree Mariusz. I would NOT expect this. The "Clear all filters" button is grouped with the filters, visually separate from the search and sort controls. It's a very legitimate use case to clear the filters and maintain the search or sort, and quite a common workflow when trying to find a particular object.
>
> The idea of this feature was to remove all filters and *search
> criteria* in one click (see the ticket description[2]). The first
> proposition was to put this link in actions [2], but I proposed moving
> it to filters. I'm not sure if link for clearing only filters is still
> necessary (and it wasn't the intention of reporter), we can remove this
> feature if it's misleading. Link to the right of the search box ("X
> total") already removes the entire query string, so ...
>
> > Additionally, I see that the link only preserves the _popup=1 query param. if users have extended their admin views with any extra query params, they will also be wiped, which is less than helpful. I know I have extended the admin with extra params before e.g. to control the queryset.
>
> Link to the right of the search box ("X total") that was added in 2005
> [3] do the same. We should probably use `add_preserved_filters`.
>
> [1]
https://code.djangoproject.com/ticket/27888
> [2]
https://github.com/django/django/pull/12351#issuecomment-577415747
> [3]
>
https://github.com/django/django/commit/9dda4abee1225db7a7b195b84c915fdd141a7260
>
> --
> You received this message because you are subscribed to the Google
> Groups "Django developers (Contributions to Django itself)" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to
django-develop...@googlegroups.com.
> To view this discussion on the web visit
>
https://groups.google.com/d/msgid/django-developers/ed3810c9-bb86-4e05-97dd-4818efa1617c%40googlegroups.com <
https://groups.google.com/d/msgid/django-developers/ed3810c9-bb86-4e05-97dd-4818efa1617c%40googlegroups.com?utm_medium=email&utm_source=footer>.