Can't translate strings properly to Hebrew and Arabic (#31937)

72 views
Skip to first unread message

אורי‎

unread,
Apr 6, 2021, 6:18:23 AM4/6/21
to Django developers (Contributions to Django itself)
Hi,


Any chance this will be fixed before the next major release? (4.0).

Remember it will also take time to fix the relevant translations - I estimate it will take ~2 months to fix them before they are released to production.

In English too, I suggest using the "one" word instead of "1", for example "one week" instead of "1 week". But it's more a mistake in Hebrew (and Arabic), where there is a word for two weeks (שבועיים), and writing "2 weeks" (2 שבועות) is incorrect.

Thanks,
Uri.

Adam Johnson

unread,
Apr 6, 2021, 6:34:52 AM4/6/21
to django-d...@googlegroups.com
Hi Uri

It depends on someone making the change. It looks like Ryan Cheley assigned it to themselves but hasn't made a PR. Perhaps you could?

Thanks,

Adam

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CABD5YeH8ciWq-f6Myb-jnkm1pK4%2Brrd%2B6sQes2z64U8qON23vQ%40mail.gmail.com.


--
Adam

אורי‎

unread,
Apr 6, 2021, 7:47:11 AM4/6/21
to Django developers (Contributions to Django itself)
Hi Adam,

What will a PR require? Does it require to change all the translations in all the languages, as well as the translation keys? And how do we intend to update it with the current translations in Transifex? Do you want me to handle such a PR?

Thanks,
Uri.


To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAMyDDM2%3Di0HHqMEuoiJTZB_fkJeta61pE6yT0OqgfE9x4TYZpA%40mail.gmail.com.

Carlton Gibson

unread,
Apr 6, 2021, 9:33:02 AM4/6/21
to django-d...@googlegroups.com
Hey Uri. 

Thanks for bumping this up — Yes, it looks like the plan is to make the adjustments that you suggested on the ticket. 

I guess I’d just suggest doing a little bit as a proof-of-concept and opening a Draft PR so we can have a look, and confer with Claude to approve the general approach, before you put in hours updating every string. (Once a PR is open, it’s always possible to collaborate too.) 

It seemed the idea was fairly clear — were there specific doubts unresolved?

Kind regards, Carlton 

אורי‎

unread,
Apr 6, 2021, 9:49:03 AM4/6/21
to Django developers (Contributions to Django itself), Claude Paroz
Hi Carlton,

Thanks for the feedback. Do you want me to create the draft PR? I would also like to receive feedback from Claude (cc), to see if we are in the right direction. Maybe it's possible to update things automatically via Transifex?

Thanks,
Uri.


To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAJwKpyQpgM875uSN3Q17LcutbF0Y%2B9pjkjWfWfDJ_F2UBu77Ow%40mail.gmail.com.

Carlton Gibson

unread,
Apr 6, 2021, 9:53:59 AM4/6/21
to django-d...@googlegroups.com, Claude Paroz
Hey Uri. 

Yes, I know Claude is busy at the moment (as I think is everyone this last year) but we’ll certainly need his input. 

For me, a small set of changes just showing what’s needed (in one place) — with any relevant links and “Do X, then Y, then Z” steps — helps to focus the discussion, and we can think about tests and so on. 

So, yes, a minimal draft PR, again as a proof-of-concept before you put too many hours in, would be very helpful. (Bottom-line is you’re probably the world expert here on this topic as it stands, so we need to catch up with you — any help you can give us in doing that goes a long way 😀)

Kind Regards,

Carlton
 



אורי‎

unread,
Apr 6, 2021, 10:26:37 AM4/6/21
to Django developers (Contributions to Django itself), Claude Paroz

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/ACAB346E-E565-48AF-BA70-0114AE9781F3%40gmail.com.

Carlton Gibson

unread,
Apr 6, 2021, 12:35:07 PM4/6/21
to django-d...@googlegroups.com, Claude Paroz
Super. Thank you. 

Reply all
Reply to author
Forward
0 new messages