ORM expressions DEP
175 views
Skip to first unread message
Anssi Kääriäinen
Oct 27, 2014, 8:04:19 AM10/27/14
to django-d...@googlegroups.com
The ORM expressions DEP (https://github.com/django/deps/blob/master/drafts/orm_expressions.rst) is now ready for review.
In brief, the DEP proposes an improved and publicly documented way to write expressions for the ORM. The expressions can be used in .annotate() calls. The DEP also proposes that aggregates are a subclass of expressions.
The benefits are:
- Public API to write expressions
- Simplified implementation of how expressions are added to the query and how they are evaluated
- Aggregates behave similarly to other ORM expressions
A pull request by Josh Smeaton implements the DEP (https://github.com/django/django/pull/2496).
My understanding is that we don't have yet any process for how to accept (or number...) DEPs. I propose that first the community reviews the DEP. Unless there is clear objection to the DEP, the technical board can then consider if (and how) they want to accept the DEP.
- Anssi
In brief, the DEP proposes an improved and publicly documented way to write expressions for the ORM. The expressions can be used in .annotate() calls. The DEP also proposes that aggregates are a subclass of expressions.
The benefits are:
- Public API to write expressions
- Simplified implementation of how expressions are added to the query and how they are evaluated
- Aggregates behave similarly to other ORM expressions
A pull request by Josh Smeaton implements the DEP (https://github.com/django/django/pull/2496).
My understanding is that we don't have yet any process for how to accept (or number...) DEPs. I propose that first the community reviews the DEP. Unless there is clear objection to the DEP, the technical board can then consider if (and how) they want to accept the DEP.
- Anssi
Marc Tamlyn
Nov 4, 2014, 6:16:13 AM11/4/14
to django-d...@googlegroups.com
I've had a proper read of the patch and the DEP. As far as I'm concerned, it's an extremely powerful and useful change. We may have some minor modifications to make to the implementation as issues are found, but the API decisions are good.
--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at http://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/9b7fcf81-e618-4ea5-a806-2ffd3cd42718%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Josh Smeaton
Nov 6, 2014, 6:56:56 AM11/6/14
to django-d...@googlegroups.com
Thanks for taking a look Marc, it's nice to have a few more eyes on the DEP and patch. I'll be working through all feedback in batches when it comes through. Hopefully we can get a few more people to review also.
Reply all
Reply to author
Forward
0 new messages