Fellow Reports - April 2020

[Mariusz Felisiak]

Week ending April 5, 2020.

Triaged:

https://code.djangoproject.com/ticket/31407 - RuntimeWarning when running AsyncHandlerRequestTests.test_unawaited_response. (accepted)
https://code.djangoproject.com/ticket/31406 - Access date/time of request. (wontfix)
https://code.djangoproject.com/ticket/31409 - Add warning regarding CheckConstraint and MySQL in docs. (wontfix)
https://code.djangoproject.com/ticket/29170 - Unable to add triggers in migrations on Oracle. (accepted)
https://code.djangoproject.com/ticket/31410 - Add check for fields of UniqueConstraints. (accepted)
https://code.djangoproject.com/ticket/31411 - Use RENAME COLUMN on MariaDB 10.5.2+. (created)

https://code.djangoproject.com/ticket/31413 - migrations.test_loader not isolated on databases that don't support transactions. (accepted)
https://code.djangoproject.com/ticket/31414 - Django TestCase reads from "production" database with MySQL backend. (worksforme)
https://code.djangoproject.com/ticket/31420 - Using SimpleLazyObject with a nested subquery annotation fails. (accepted)
https://code.djangoproject.com/ticket/31421 - Running test suites hang on mac OX Catalina 10.15.2. (duplicate)
https://code.djangoproject.com/ticket/31422 - Django response too long even do nothing. (invalid)
https://code.djangoproject.com/ticket/31415 - QuerySet crashes when nested OuterRef is combined with an operator or used in function. (accepted)
https://code.djangoproject.com/ticket/31416 - FieldError when migrating field to new model subclass. (accepted)
https://code.djangoproject.com/ticket/31417 - Broken source links in docs. (invalid)
https://code.djangoproject.com/ticket/31423 - Clarify using nested database transactions in atomic() docs. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12628 - Fixed #31403 -- Added support for returning fields from INSERT statements on MariaDB 10.5+.
https://github.com/django/django/pull/12637 - Fixed #30864 -- Doc'd classproperty decorator.
https://github.com/django/django/pull/12627 - Fixed #31375 -- Made contrib.auth.hashers.make_password() accept only bytes or strings.

https://github.com/django/django/pull/12511 - Refs #31320 -- Warned against using BEGIN/COMMIT in RunSQL.
https://github.com/django/django/pull/12596 - Fixed #31380 -- Added deployment system check for DJANGO_ALLOW_ASYNC_UNSAFE environment variable.
https://github.com/django/django/pull/12649 - Used RENAME COLUMN on MariaDB 10.5.2+.
https://github.com/django/django/pull/12652 - Refs #31051 -- Fixed reloading the database with circular related objects and natural keys for tests.
https://github.com/django/django/pull/12634 - Fixed #31275 -- Optimized sql_flush() without resetting sequence on MySQL.
https://github.com/django/django/pull/12654 - Fixed #31415 -- Fixed crash when nested OuterRef is used with operators or in database functions.

Reviewed:

https://github.com/django/django/pull/8477 - Fixed #28184 -- Allowed passing a callable storage to FileField.

Authored:

https://github.com/django/django/pull/12647 - Refs #12990 -- Moved PostgresSimpleLookup to the django.db.models.lookups.PostgresOperatorLookup.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending April 12, 2020.

Triaged:

https://code.djangoproject.com/ticket/31428 - Allow empty message in management command stdout and stderr proxies. (accepted)
https://code.djangoproject.com/ticket/29069 - Static file serving does not call request_finished signal. (fixed)
https://code.djangoproject.com/ticket/31431 - Coverage integration with multiprocessed Django tests. (wontfix)
https://code.djangoproject.com/ticket/31432 - Conform to HTTP Status Code RFC's redirect classes. (wontfix)
https://code.djangoproject.com/ticket/31430 - Bug in django.test.client.Client._handle_redirects. (invalid)
https://code.djangoproject.com/ticket/31429 - Django test client adds carriage return on empty request. (needsinfo)
https://code.djangoproject.com/ticket/31433 - Model.objects.create() doesn't utilize caching for prefetches defined on the ObjectManager. (invalid)
https://code.djangoproject.com/ticket/31425 - Support for Clear-Site-Data header. (Someday/Maybe)
https://code.djangoproject.com/ticket/31434 - Enhancement in the default __str__() function. (wontfix)
https://code.djangoproject.com/ticket/30966 - Migration crashes due to foreign key issue, depending on otherwise irrelevant order on MySQL. (fixed)
https://code.djangoproject.com/ticket/31436 - format_html_join() should be able to handle named placeholders. (wontfix)
https://code.djangoproject.com/ticket/31435 - RecursionError when deleting a model with one to many relationship. (invalid)
https://code.djangoproject.com/ticket/31437 - Invalid model structure used in tests. (accepted)
https://code.djangoproject.com/ticket/31439 - Integrate Django with Angular JS. (invalid)
https://code.djangoproject.com/ticket/31438 - Current user in form. (invalid)
https://code.djangoproject.com/ticket/31440 - Add a standard way to set deferrable constraints. (wontfix)
https://code.djangoproject.com/ticket/31445 - Chain of unions leads to incorrect SQL query on MariaDB < 10.4 and MySQL. (accepted)
https://code.djangoproject.com/ticket/31446 - Annotate with ExpressionWrapper gives wrong result on date field. (invalid)
https://code.djangoproject.com/ticket/31447 - ManifestStaticFilesStorage should have file exclude patterns. (wontfix)
https://code.djangoproject.com/ticket/31449 - Autocomplete doesn't work when ForeignKey to_field is not pk. (duplicate)
https://code.djangoproject.com/ticket/31448 - Support HTML messages in send_mass_mail(). (wontfix)
https://code.djangoproject.com/ticket/31451 - Settings are cleaned insufficiently. (accepted)
https://code.djangoproject.com/ticket/31453 - Avoid comparison against a boolean value for Exists(). (fixed)

Reviewed/committed:

https://github.com/django/django/pull/12663 - Fixed #31420 -- Fixed crash when filtering subquery annotation against a SimpleLazyObject.
https://github.com/django/django/pull/12669 - Fixed #31426 -- Added proper field validation to QuerySet.order_by().
https://github.com/django/django/pull/12668 - Fixed #31030 -- Registered SQLite functions as deterministic on Python 3.8+.
https://github.com/django/django/pull/12671 - Fixed #31428 -- Allowed empty message in management command self.stdout/err proxies.
https://github.com/django/django/pull/12665 - Refs #27666 -- Ensured relationship consistency on delayed reloads.
https://github.com/django/django/pull/12680 - Added more tests for loaddata/dumpdata with forward and circular references.
https://github.com/django/django/pull/12458 - Fixed #31051 -- Allowed dumpdata to handle circular references in natural keys.
https://github.com/django/django/pull/12684 - Fixed #31437 -- Corrected tests to show abstract multiple inheritance system check error.
https://github.com/django/django/pull/12678 - Fixed #30779 -- Improved selection of filenames in technical 500 debug page.
https://github.com/django/django/pull/12656 - Fixed #13009 -- Added BoundField.widget_type property.
https://github.com/django/django/pull/12664 - Migration operations cleanups.
https://github.com/django/django/pull/12559 - Fixed #31351 -- Added system checks for partial indexes and unique constraints support.

Reviewed:

https://github.com/django/django/pull/12691 - Fixed #31407 -- Fixed unawaited coroutine warning for Python 3.8+.

Authored:

https://github.com/django/django/pull/12670 - Fixed Sphinx warnings.
https://github.com/django/django/pull/12682 - Refs #30966 -- Added test for reloading related model state on non-relational changes.
https://github.com/django/django/pull/12698 - Fixed term warnings on Sphinx 3.0.1+.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending April 19, 2020.

Triaged:

https://code.djangoproject.com/ticket/31457 - Docker container django html page was {{form.first_name}}. (invalid)
https://code.djangoproject.com/ticket/31455 - Support DEFERRABLE INITIALLY DEFERRED for EXCLUSION constraints. (accepted)
https://code.djangoproject.com/ticket/31458 - Allow changing executable_name for dbshell management command. (wontfix)
https://code.djangoproject.com/ticket/31462 - Allow overridding widget in formfield_for_manytomany(). (accepted)
https://code.djangoproject.com/ticket/31454 - The behavior of m2m_changed signals does not match the documentation. (duplicate)
https://code.djangoproject.com/ticket/31459 - URL path parameter regex too lenient. (accepted)
https://code.djangoproject.com/ticket/31465 - "python3 manage.py shell" using IPython instead of Python. (invalid)
https://code.djangoproject.com/ticket/31463 - Apply OPTIONS in database settings to dbshell. (duplicate)
https://code.djangoproject.com/ticket/31464 - Oracle destroy test database mixes tablespace, database and tables. (invalid)
https://code.djangoproject.com/ticket/31466 - A potential improvement in the Django template filter `escapejs`. (wontfix)
https://code.djangoproject.com/ticket/31467 - Possible error in the doc "Writing your first Django app, part 1". (invalid)
https://code.djangoproject.com/ticket/31470 - Overflow not respected when using `<pre>` tag in `<fieldset>` in the admin site. (accepted)
https://code.djangoproject.com/ticket/31469 - Custom lookup ignored inside built-in aggregation. (duplicate)
https://code.djangoproject.com/ticket/31472 - UserAdmin returns incorrect fieldsets when model has overridden __bool__. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/12701 - Refs #31196 -- Installed postgis_raster extension on PostGIS 3+.
https://github.com/django/django/pull/12355 - Fixed #31196 -- Added support for PostGIS 3.
https://github.com/django/django/pull/12508 - Fixed #29501 -- Allowed dbshell to pass options to underlying tool.
https://github.com/django/django/pull/12713 - Fixed #31462 -- Allowed overriding autocomplete/raw_id_fields/filter widgets for ManyToManyFields with formfield_overrides.
https://github.com/django/django/pull/12700 - Fixed #31451 -- Made settings cleansing work with list and tuple settings.
https://github.com/django/django/pull/12625 - Fixed #31268 -- Updated Algerian Arabic (ar_DZ) locale formats.
https://github.com/django/django/pull/12710 - Fixed #31459 -- Fixed handling invalid indentifiers in URL path conversion.
https://github.com/django/django/pull/12454 - Refs #27468 - Changed default Signer algorithm to SHA-256.
https://github.com/django/django/pull/12305 - Removed unused __str__() methods in tests models.
https://github.com/django/django/pull/12517 - Fixed #29329 -- Made datetime logging from runserver more consistent.
https://github.com/django/django/pull/12729 - Added test coverage for DatabaseOperations.sql_flush().
https://github.com/django/django/pull/12733 - Fixed #31473 -- Made sql_flush() use RESTART IDENTITY to reset sequences on PostgreSQL.
https://github.com/django/django/pull/12591 - Fixed #30311 -- Restored ability to override global admin actions.

Reviewed:

https://github.com/django/django/pull/12725 - Fixed #31470 -- Fixed fieldset admin CSS to prevent overflowing <pre> elements.

Authored:

https://github.com/django/django/pull/12735 - Refs #31351 -- Made partial constraints tests use required_db_features.
https://github.com/django/django/pull/12736 - Refs #26552 -- Made reloading the database for tests check only loaded tables constraints.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending April 26, 2020.

Triaged:

https://code.djangoproject.com/ticket/31480 - Accessing admin panel doesn't work. (worksforme)
https://code.djangoproject.com/ticket/31481 - Admin crash when using functions in model meta ordering of o2o primary key. (fixed)
https://code.djangoproject.com/ticket/31483 - Remove admin change_form.js dependency on jQuery. (accepted)
https://code.djangoproject.com/ticket/31484 - Possibility to provide additional Context to Render a FlatPage. (wontfix)
https://code.djangoproject.com/ticket/31478 - Template.get_exception_info() relies on internal state which isn't correct for sub-templates. (duplicate)
https://code.djangoproject.com/ticket/31485 - Update admin's jQuery to 3.5.X. (created)
https://code.djangoproject.com/ticket/31489 - Django Admin showing "Date input" for Time Field in Mobile Safari. (duplicate)
https://code.djangoproject.com/ticket/31492 - Changing field type can cause unrelated nullability change in field on Oracle. (created)
https://code.djangoproject.com/ticket/31491 - dbshell command for MySQL backend uses "passwd" instead of "password". (accepted)
https://code.djangoproject.com/ticket/31496 - Combined queryset crash when chaining `values()` after `order_by()` with annotated constantants. (accepted)
https://code.djangoproject.com/ticket/31499 - Store ModeState.fields into a dict. (accepted)
https://code.djangoproject.com/ticket/31497 - get_static_prefix() as variable in a template doesn't work. (worksforme)
https://code.djangoproject.com/ticket/31498 - GenericRelation's get_internal_type() incorrectly reports "ManyToManyField". (wontfix)
https://code.djangoproject.com/ticket/31500 - Allow QuerySet.in_bulk() for fields with total UniqueConstraints. (accepted)
https://code.djangoproject.com/ticket/24691 - Document model._state.adding (since UUIDField sets value before save) (duplicate)
https://code.djangoproject.com/ticket/31502 - Document Model._state.db and Model._state.adding. (accepted)
https://code.djangoproject.com/ticket/31506 - ExpressionWrapper() doesn't respect output_field when combining DateField and timedelta on PostgreSQL and MySQL. (accepted)
https://code.djangoproject.com/ticket/31507 - Augment QuerySet.exists() optimizations to .union().exists(). (accepted)
https://code.djangoproject.com/ticket/31505 - Document possible email address enumeration in PasswordResetView. (accepted)
https://code.djangoproject.com/ticket/31510 - server is not working properly for admin panel. (duplicate)
https://code.djangoproject.com/ticket/31511 - Allow stopwords in slugs generated by ModelAdmin.prepopulated_fields (duplicate)
https://code.djangoproject.com/ticket/31512 - Django TextChoices cannot utilize `is` or `==` isn't explicitly stated. (invalid)
https://code.djangoproject.com/ticket/31514 - Correct default forms fields in model fields docs. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12751 - Refs #29069 -- Added test for calling request_finished signal by static file responses.
https://github.com/django/django/pull/12756 - Fixed #24559 -- Made MigrationLoader.load_disk() catch more specific ModuleNotFoundError.
https://github.com/django/django/pull/12741 - Fixed #31477 -- Removed "using" argument from DatabaseOperations.execute_sql_flush().
https://github.com/django/django/pull/12742 - Disabled management commands output with verbosity 0 in various tests.
https://github.com/django/django/pull/12747 - Fixed #31474 -- Made QuerySet.delete() not return the number of deleted objects if it's zero.
https://github.com/django/django/pull/12746 - Refs #22463 -- Replaced JSHint with ESLint in contributing docs.
https://github.com/django/django/pull/12734 - Fixed #31064 -- Recreated auto-created relationships on type change on SQLite.
https://github.com/django/django/pull/12748 - Fixed #31479 -- Added support to reset sequences on SQLite.
https://github.com/django/django/pull/12771 - Fixed #31499 -- Stored ModelState.fields into a dict.
https://github.com/django/django/pull/12774 - Fixed #31500 -- Fixed detecting of unique fields in QuerySet.in_bulk() when using Meta.constraints.
https://github.com/django/django/pull/12708 - Fixed #29224 -- Fixed removing index_together indexes if exists unique_together constraint on the same fields.
https://github.com/django/django/pull/12788 - Refs #31369 -- Deprecated models.NullBooleanField in favor of BooleanField(null=True).
https://github.com/django/django/pull/12790 - Fixed #31514 -- Fixed default form widgets in model fields docs.

Authored:

https://github.com/django/django/pull/12758 - Fixed #31485 -- Updated admin's jQuery to 3.5.0.
https://github.com/django/django/pull/12762 - Updated admin's XRegExp to 3.2.0.
https://github.com/django/django/pull/12780 - Fixed #31505 -- Doc'd possible email addresses enumeration in PasswordResetView.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending May 3, 2020.

Triaged:

https://code.djangoproject.com/ticket/31517 - ManifestFilesMixin.file_hash() returning None get's included in hashed filename as 'None'. (accepted)
https://code.djangoproject.com/ticket/31513 - Store failed tests in files. (wontfix)
https://code.djangoproject.com/ticket/31369 - Deprecate the model NullBooleanField. (fixed)
https://code.djangoproject.com/ticket/31519 - Unclosed tags don't cause syntax errors in templates. (wontfix)
https://code.djangoproject.com/ticket/31515 - Django tries to reuse MySQL connections that have gone away with ASGI. (accepted)
https://code.djangoproject.com/ticket/31521 - test_parsing_rfc850 test failure on 32-bit platforms. (accepted)
https://code.djangoproject.com/ticket/31523 - Remove jQuery dependency from actions.js. (accepted)
https://code.djangoproject.com/ticket/31522 - FilteredSelectMultiple widget jumps to top when an option is added. (accepted)
https://code.djangoproject.com/ticket/31525 - Development vs Production. (invalid)
https://code.djangoproject.com/ticket/31529 - Add support for pathlib and os.PathLike in migrations serializer. (accepted)
https://code.djangoproject.com/ticket/31530 - Check that CheckConstraint.check and UniqueConstraint.condition don't span joins. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12792 - Refs #18325 -- Removed unnecessary line endings in management commands.
https://github.com/django/django/pull/12803 - Fixed #31517 -- Fixed HashedFilesMixin.hashed_name() if hash of the file is None.
https://github.com/django/django/pull/12447 - Changed django.forms.ValidationError imports to django.core.exceptions.ValidationError.
https://github.com/django/django/pull/12786 - Fixed #29249 -- Made JSON and YAML serializers use Unicode by default.
https://github.com/django/django/pull/12804 - Refs #30400 -- Improved typography of user facing strings in admin changelist.
https://github.com/django/django/pull/12809 - Fixed #31356 -- Changed IRC links to the Freenode webchat.
https://github.com/django/django/pull/12818 - Fixed #31521 -- Skipped test_parsing_rfc850 test on 32-bit systems.
https://github.com/django/django/pull/12789 - Fixed #25712 -- Reorganized templates docs.
https://github.com/django/django/pull/10338 - Fixed #20581 -- Added support for deferrable unique constraints.
https://github.com/django/django/pull/12829 - Refs #27778 -- Removed reference to ASCII usernames in django.contrib.auth.models.User docs.
https://github.com/django/django/pull/12659 - Doc'd Meta inheritance from abstract parents.
https://github.com/django/django/pull/12704 - Fixed #31455 -- Added support for deferrable exclusion constraints on PostgreSQL.

Authored:

https://github.com/django/django/pull/12822 - Refs #27468 -- Made user sessions use SHA-256 algorithm.
https://github.com/django/django/pull/12834 - Refs #31032 -- Removed obsolete CSS workaround for IE in openlayers template.
https://github.com/django/django/pull/12836 - Updated admin's Select2 to 4.0.13.

Best regards,

Mariusz