localized_fields
is a list of names of fields which should be localized.
labels
is a dictionary of model field names mapped to a label.
help_texts
is a dictionary of model field names mapped to a help text.
error_messages
is a dictionary of model field names mapped to a
dictionary of error messages.
field_classes
is a dictionary of model field names mapped to a form
field class. def get_form_class(self):
  base_form = super().get_form_class()
  return modelform_factory(self.model, base_form, widgets=...)
class PatientCreate(LoginRequiredMixin, UserOrgRequiredMixin, CreateView):
model = models.Patient
fields = ['name', 'caregiver_name', 'sex', 'birth_date',
'residence', 'country']
from django.forms.models import modelform_factory
_patient_create_form = modelform_factory(
models.Patient,
fields=['name', 'caregiver_name', 'sex', 'birth_date',
'residence', 'country'])
class PatientCreate(LoginRequiredMixin, UserOrgRequiredMixin, CreateView):
form_class = _patient_create_form
template_name = 'healthdbapp/patient_form.html'
from django.forms import HiddenInput
from django.forms.models import modelform_factory
_patient_create_form = modelform_factory(
models.Patient,
fields=['name', 'caregiver_name', 'sex', 'birth_date',
'residence', 'country'],
widgets={'country': HiddenInput()})
class PatientCreate(LoginRequiredMixin, UserOrgRequiredMixin, CreateView):
form_class = _patient_create_form
template_name = 'healthdbapp/patient_form.html'
I agree with Tim that this is a slippery slope.Maybe that adding a ModelFormMixin.get_form_class_options() that returns a{'fields': self.fields} dict by default and is passed to modelform_factory(**kwargs)in get_form_class() would be a good compromise?Best,Simon
On Tuesday, December 4, 2018 17:28:39 UTC-5, Tim Graham wrote:What I meant is that modelform_factory() also has these parameters:
localized_fields
is a list of names of fields which should be localized.
labels
is a dictionary of model field names mapped to a label.
help_texts
is a dictionary of model field names mapped to a help text.
error_messages
is a dictionary of model field names mapped to a dictionary of error messages.field_classes
is a dictionary of model field names mapped to a form field class.If we accept the patch for widgets, then are we headed down the road of adding support for the rest of those arguments? Customizing a form directly rather than indirectly via the view seems like better design to me. It doesn't require adding features to ModelFormMixin as they are added to ModelForm.On Tuesday, December 4, 2018 at 4:57:40 PM UTC-5, Dan F wrote:This ticket has a patch to pass through the "widgets" argument for generic class-based views.It was closed with "won't fix" with this comment: "I don't think the possibility of saving a few lines of user code justifies the complexity of reimplementing the parameters to modelform_factory() as CBV parameters and methods."I don't understand. The patch was quite small (doesn't seem complex), and it could give everyone the ability to overload widgets.Aside from just saving lines of code, it also would act more as expected. I tried using "widgets" before seeing that it didn't work. Also, it would support not making a new form class where every field just has to be copied (useless boilerplate).Can you accept the patch?
--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscribe@googlegroups.com.
To post to this group, send email to django-developers@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/0281164b-9bf7-485f-83ad-c0301630c91a%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
class PatientCreate(LoginRequiredMixin, UserOrgRequiredMixin, CreateView):
model = models.Patient
fields = ['name', 'caregiver_name', 'sex', 'birth_date',
'residence']def form_valid(self, form):form.instance.country = get_country() # e.g. get country from self.request.userreturn super().form_valid(form)Cheers,Alasdair