Loading lzma compressed fixtures
29 views
Skip to first unread message
Paolo Melchiorre
May 9, 2020, 6:22:13 AM5/9/20
to django-d...@googlegroups.com
Hi all,
Working at my latest merged PR [1] in Django I saw in the code the lack
of support for lzma compressed fixture for loaddata command so I opened
a ticket [2] and a related PR [3].
I think is a small PR to accept before Django 3.1 feature freeze but it
can be a great improvement in loading big fixtures.
I would ask someone to review my PR [3].
Thanks,
Paolo
[1] https://github.com/django/django/pull/12871
[2] https://code.djangoproject.com/ticket/31552
[3] https://github.com/django/django/pull/12879
--
https://www.paulox.net
Working at my latest merged PR [1] in Django I saw in the code the lack
of support for lzma compressed fixture for loaddata command so I opened
a ticket [2] and a related PR [3].
I think is a small PR to accept before Django 3.1 feature freeze but it
can be a great improvement in loading big fixtures.
I would ask someone to review my PR [3].
Thanks,
Paolo
[1] https://github.com/django/django/pull/12871
[2] https://code.djangoproject.com/ticket/31552
[3] https://github.com/django/django/pull/12879
--
https://www.paulox.net
Tim Graham
May 9, 2020, 6:39:33 AM5/9/20
to Django developers (Contributions to Django itself)
Hi Paolo, Please don't ask for code reviews on this mailing list. It just adds noise. Patches are reviewed from "Patches needing review" at https://dashboard.djangoproject.com/. At this time there are ~30 patches in the queue. Requesting your feature to be moved to the front of the review queue the weekend before the feature freeze isn't appropriate.
Paolo Melchiorre
May 9, 2020, 8:10:06 AM5/9/20
to django-d...@googlegroups.com
On 09/05/20 12:39, Tim Graham wrote:
> On Saturday, May 9, 2020 at 6:22:13 AM UTC-4, Paolo Melchiorre wrote:
>> Working at my latest merged PR [1] in Django I saw in the code the lack
>> of support for lzma compressed fixture for loaddata command so I opened
>> a ticket [2] and a related PR [3].
>> I think is a small PR to accept before Django 3.1 feature freeze but it
>> can be a great improvement in loading big fixtures.
>> I would ask someone to review my PR [3].
> On Saturday, May 9, 2020 at 6:22:13 AM UTC-4, Paolo Melchiorre wrote:
>> Working at my latest merged PR [1] in Django I saw in the code the lack
>> of support for lzma compressed fixture for loaddata command so I opened
>> a ticket [2] and a related PR [3].
>> I think is a small PR to accept before Django 3.1 feature freeze but it
>> can be a great improvement in loading big fixtures.
>> I would ask someone to review my PR [3].
>> [1] https://github.com/django/django/pull/12871
>> [2] https://code.djangoproject.com/ticket/31552
>> [3] https://github.com/django/django/pull/12879
>> [2] https://code.djangoproject.com/ticket/31552
>> [3] https://github.com/django/django/pull/12879
> Hi Paolo, Please don't ask for code reviews on this mailing list. It
> just adds noise. Patches are reviewed from "Patches needing review" at
> https://dashboard.djangoproject.com/. At this time there are ~30 patches
> in the queue. Requesting your feature to be moved to the front of
> the review queue the weekend before the feature freeze isn't appropriate.
Hi Tim,
> just adds noise. Patches are reviewed from "Patches needing review" at
> https://dashboard.djangoproject.com/. At this time there are ~30 patches
> in the queue. Requesting your feature to be moved to the front of
> the review queue the weekend before the feature freeze isn't appropriate.
Sorry, I wasn't aware of the dashboard and I definitely didn't want to
ask my feature to be moved to the front of the review queue.
Next time I won't ask for code reviews on this mailing list.
Thanks,
Paolo
--
https://www.paulox.net
Reply all
Reply to author
Forward
0 new messages