Quick Filter in the Admin Sidebar

[Maxim Milovanov]

Hey guys,

I've posted a ticket with a proposal to add a quick filtering feature to the sidebar.

To see it in action just replace the content of nav_sidebar.html by this gist

Does it worth adding to the admin features? Hope for any feedback.

Thanks,
Maxim

[Yasiel Cabrera]

I found this feature very helpful. I'm maintaining two sites with more than 20 models registered in the admin and some time is annoying when I try to find the one I'm looking for

[Maxim Milovanov]

Yeah, that's why I came up with that idea. There are two projects, 44 models on one, 57 models on another. It's very hard to navigate

четверг, 19 ноября 2020 г. в 16:50:37 UTC+3, yasie...@gmail.com:

[Tom Carrick]

I haven't looked at the gist, but I think in principle it's a good idea. ctrl+f isn't ideal.

I think we need to be careful that the UX is good, if we go with this.

Tom

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/8376528d-a2df-43b0-829e-43a49bd44dddn%40googlegroups.com.

[Collin Anderson]

I think this would be really helpful. Looking at the code in the gist, that looks about right. It's not too complicated and the basic toLowerCase()/indexOf() method of search should hopefully be enough (it's what I would do if I were implementing this!). I'd suggest adding some sort of clear or x button for canceling/removing the filter, but otherwise I think this should be ok UX wise. We can always improve it later.

[Maxim Milovanov]

Hey guys,

I'm not sure that the nav_sidebar.html is the best place for the JS snippet. Probably, it should be placed in the main JS. When DOM is ready it can be initialized there.

About UX. Agree the the "Clear" feature would be useful. It can be an "x" icon, or a shortkey (ESC?), or both.

I'll provide a working sample later.

Thanks,
Maxim 

среда, 2 декабря 2020 г. в 20:46:30 UTC+3, Collin Anderson:

[Adam Johnson]

I'm not sure that the nav_sidebar.html is the best place for the JS snippet. Probably, it should be placed in the main JS. When DOM is ready it can be initialized there.

Indeed, we can't use inline JS in the admin since that doesn't work with a strict CSP.

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/577ba446-7e78-42d8-8a1d-88db169475d4n%40googlegroups.com.

--

Adam

[Maxim Milovanov]

Hey guys,

I've updated my prototype. What's changed:

-- moved the JS and CSS to nav_sidebar.js and nav_sidebar.css respectively

-- slight changes in styling

-- added ESC key support

I've updated my gist https://gist.github.com/MilovanovM/84ffbbec02391c1ba1771a3a6aee5797

My changes are:

nav_sidebar.html: line 4

nav_sidebar.css: line 121 and below

nav_sidebar.js: line 40 and below

Here is the commit in my repo https://github.com/MilovanovM/django/commit/837701e79c468f72cbce1921b42c130801927e1c

I've attached a git patch file as well.

Thanks,

Maxim

пятница, 4 декабря 2020 г. в 12:00:35 UTC+3, Adam Johnson:

[Tom Carrick]

Hi Maxim,

I think the best thing you can do is add a ticket on trac - https://code.djangoproject.com/ and make a PR on GitHub if it's accepted. I think it's hard - at least for me - to test something from a gist. Then you will get some reviews and more feedback.

Cheers,

Tom

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/fefe1de6-874c-44d0-a2a6-2574ce257373n%40googlegroups.com.

[Carlton Gibson]

I originally sent the ticket here to see if folks were keen. 

Given discussion here, I’ve adjusted to Accepted. 

Next step would be a PR.

Thanks all. 

To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/CAHoz%3DMYbSmJ7zF_t%3D-cK%3D5ebMGwNbzFTTYtdBy65GU%2BeUkcCrg%40mail.gmail.com.

[Maxim Milovanov]

Hey guys,

I've just created a PR, please review https://github.com/django/django/pull/13873

воскресенье, 10 января 2021 г. в 09:52:56 UTC+3, carlton...@gmail.com: