Fellow Reports - May 2018

156 views
Skip to first unread message

Tim Graham

unread,
May 7, 2018, 10:49:05 AM5/7/18
to Django developers (Contributions to Django itself)

Week ending May 5, 2018


Triaged

-------

https://code.djangoproject.com/ticket/29374 - Group the 'Available format strings' in the date template tag doc by category (accepted)

https://code.djangoproject.com/ticket/29378 - migration does not consistently rename field "id" to "model_id" depending on model name (accepted)

https://code.djangoproject.com/ticket/29380 - Add support for QuerySet.select_for_update()'s nowait and skip_locked options on MySQL 8+ (accepted)

https://code.djangoproject.com/ticket/29378 -migration does not consistently rename field "id" to "model_id" depending on model name (worksforme)

https://code.djangoproject.com/ticket/29355 - ArrayField in admin inline form try to save null instead default value (needsinfo)


Reviewed/committed

------------------

https://github.com/django/django/pull/9918 - Fixed #29373 -- Added long_description in setup.py.

https://github.com/django/django/pull/9923 - Fixed #28913 -- Fixed error handling when MIGRATIONS_MODULES specifies a nonexistent top-level package.

https://github.com/django/django/pull/8752 - Fixed #26688 -- Fixed HTTP request logging inconsistencies.

https://github.com/django/django/pull/9914 - Fixed #29375 -- Removed empty action attribute on HTML forms.

Tim Graham

unread,
May 13, 2018, 6:41:33 PM5/13/18
to Django developers (Contributions to Django itself)

Week ending May 12, 2018


Triaged

-------

https://code.djangoproject.com/ticket/29391 - Postgres array lookups need to call get_db_prep_value to adapt values to their db representation (FieldGetDbPrepValueMixin) (accepted)

https://code.djangoproject.com/ticket/29395 - Assigning correctly formatted time string to TimeField field works, but leaves the field value a string (and not datetime.time as when retrieved) (duplicate)

https://code.djangoproject.com/ticket/29398 - Clarify that cascade deletion doesn't invoke .delete() on the cascaded objects (accepted)

https://code.djangoproject.com/ticket/29399 - Template rendering errors are incorrectly blamed on base template (duplicate)


Reviewed/committed

------------------

https://github.com/django/django/pull/9905 - Replaced django.test.utils.patch_logger() with assertLogs().

https://github.com/django/django/pull/9919 - Fixed #29370 -- Added choices to LogEntry.action_flag field.

https://github.com/django/django/pull/9935 - Fixed #29389 -- Made Paginator reject non-integer page numbers of type float.

https://github.com/django/django/pull/9360 - Fixed #27629 -- Added router.allow_relation() calls for assignments between unsaved model instances.

https://github.com/django/django/pull/9904 - Fixed #29363 -- Added SimpleTestCase.assertWarnsMessage().

https://github.com/django/django/pull/9939 - Increased django.utils.translation.trans_null test coverage.

https://github.com/django/django/pull/8627 - Fixed #17379 -- Removed management commands deactivation of the locale.

Tim Graham

unread,
May 24, 2018, 1:28:46 PM5/24/18
to Django developers (Contributions to Django itself)

Week ending May 19, 2018


Triaged

-------

https://code.djangoproject.com/ticket/29403 - Make PyLibMCCache backend handle TooBig exception from pylibmc (accepted)

https://code.djangoproject.com/ticket/29402 - parse_header function in http/multipartparser.py unescapes in wrong order (needsinfo)

https://code.djangoproject.com/ticket/29410 - Provide project_urls in setup.py to improve Django's PyPI page (fixed)


Authored

----------

https://github.com/django/django/pull/9962 - Bootstrapped Django 2.2.


Reviewed/committed

------------------

https://github.com/django/django/pull/9933 - Fixed #29392 -- Disallowed use of abbreviated forms of --settings and --pythonpath management command options.

https://github.com/django/django/pull/9839 - Fixed #16470 -- Allowed FileResponse to auto-set some Content headers.

https://github.com/django/django/pull/6734 - Fixed #8936 -- Added a view permission and a read-only admin.

https://github.com/django/django/pull/9950 - Fixed #29398 -- Doc'd that cascade deletion doesn't call delete() of related models.

https://github.com/django/django/pull/9934 - Fixed #29380 -- Added support for QuerySet.select_for_update()'s nowait and skip_locked options on MySQL 8+.

https://github.com/django/django/pull/9963 - Fixed #29414 -- Restored form inputs on admin inlines when the user doesn't have the change permission.

Tim Graham

unread,
May 28, 2018, 9:50:56 AM5/28/18
to Django developers (Contributions to Django itself)

Week ending May 26, 2018


Triaged

-------

https://code.djangoproject.com/ticket/29413 - QuerySet.get_or_create()/update_or_create() shouldn't evaluate lazy defaults unless they are needed (accepted)

https://code.djangoproject.com/ticket/29442 - wrong sql for cast datetime to date in sqlite backend (duplicate)

https://code.djangoproject.com/ticket/29450 - Redirect using HTTP status "303 See Other" for django.http.response HttpResponseRedirect (duplicate)

https://code.djangoproject.com/ticket/29451 - Add compatibility with MySQL 8 (accepted)

https://code.djangoproject.com/ticket/29434 - model_to_dict should work with prefix (needsinfo)

https://code.djangoproject.com/ticket/29439 - InlineAdminFormSet worked with forms array, but don't asks fieldset from every form in array (needsinfo)

https://code.djangoproject.com/ticket/29436 - admin change_form.html in prepopulated_fields_js template tag always call second time every empty_form in inline_admin_formset (needsinfo)

https://code.djangoproject.com/ticket/29445 - Compute defaults values with using of objects manager (wontfix)


Reviewed/committed

------------------

https://github.com/django/django/pull/9966 - Fixed #29417 -- Corrected two admin page titles for view-only users.

https://github.com/django/django/pull/9979 - Fixed #29400 -- Fixed @register.filter on decorated functions.

https://github.com/django/django/pull/9976 - Mentioned SuccessMessageMixin in generic editing views docs.

https://github.com/django/django/pull/9980 - Fixed #29423 -- Documented Field.value_from_object().

https://github.com/django/django/pull/9965 - Fixed #29415 -- Fixed detection of custom URL converters in included patterns.

https://github.com/django/django/pull/9988 - Fixed #29432 -- Allowed passing an integer to the slice template filter.

https://github.com/django/django/pull/9961 - Added test for createsuperuser's handling of KeyboardInterrupt.

https://github.com/django/django/pull/9995 - Fixed #29230 -- Fixed nested prefetches that clash with descriptors.

Tim Graham

unread,
Jun 4, 2018, 9:52:24 AM6/4/18
to Django developers (Contributions to Django itself)

Week ending June 2, 2018


I also spent time spinning up some new CI servers with Ubuntu 18.04. That required the GIS test fixes below.


Triaged

-------

https://code.djangoproject.com/ticket/29455 - MySQL Backend & features detection are not taking MariaDB Aria engine into account (invalid)

https://code.djangoproject.com/ticket/29464 - Move collectstatic post processing messages to verbosity 2 (accepted)


Authored

----------

https://github.com/django/django-contrib-comments/pull/134 - Added testing for Django 2.1

https://github.com/django/django-formtools/pull/127 - Add testing for Django 2.1

https://github.com/jazzband/django-hosts/pull/84 - Add testing for Django 2.1

https://github.com/django/django-localflavor/pull/335 - Add testing for Django 2.1

https://github.com/django/django/pull/10003 - Refs #28748 -- Reallowed lazy model field choices.

https://github.com/django/django/pull/10014 - Fixed #29460 -- Added support for GEOS 3.6.

https://github.com/django/django/pull/10007 - Fixed #29462 -- Fixed ogrinspect test failures with GDAL 2.2.

https://github.com/django/django/pull/10018 - Fixed #29461 -- Fixed ogrinspect test_time_field failure on SpatiaLite.


Reviewed/committed

------------------

https://github.com/django/django/pull/8908 -  Fixed #28044 -- Unified the logic for createsuperuser's interactive and --noinput modes.

https://github.com/django/django/pull/9920 - Fixed #28462 -- Decreased memory usage with ModelAdmin.list_editable.
Reply all
Reply to author
Forward
0 new messages