Fellow Reports - October 2023

[Mariusz Felisiak]

Week ending October 8

Triaged:
    https://code.djangoproject.com/ticket/34885 - Not removing original (non-hashed) files after processing (duplicate)
    https://code.djangoproject.com/ticket/34886 - Sample use of lazy in delayed translations is not valid in Django 4.1 and 4.2. (accepted)
    https://code.djangoproject.com/ticket/34887 - Allow unlimited CharField for SQLite backend (wontfix)
    https://code.djangoproject.com/ticket/34889 - Broken fallback for prefetchers that only implement get_prefetch_queryset (accepted)
    https://code.djangoproject.com/ticket/34798 - Subquery wrapping is required in QuerySet.aggregate() for aggregates referencing nested subquery. (accepted)
    https://code.djangoproject.com/ticket/14611 - Added dedicated option to test.Client methods (other than get()) for passing query parameters. (accepted)
    https://code.djangoproject.com/ticket/34893 - TIME_ZONE (settings.py) Europe/Kiev to Europe/Kyiv (invalid)

Reviewed/committed:
    https://github.com/django/django/pull/17319 - Fixed #32602 -- Clarified wording of TestCase class.
    https://github.com/django/django/pull/17325 - Fixed #34883 -- Allowed template tags to set extra data on templates.
    https://github.com/django/django/pull/17204 - Fixed #34657 -- Made assert(Not)Contains/assertInHTML display haystacks in error messages.
    https://github.com/django/django/pull/17334 - Fixed #34759 -- Confirmed support for SpatiaLite 5.1.
    https://github.com/django/django/pull/17336 - Refs #33482 -- Fixed QuerySet selecting and filtering againts Exists() with empty queryset.
    https://github.com/django/django/pull/17342 - Refs #32275 -- Added scrypt password hasher to PASSWORD_HASHERS setting docs.

Authored:
    https://github.com/django/django/pull/17331 - Refs #34118 -- Used Python 3.12 for GitHub actions.
    https://github.com/django/django/pull/17332 - Refs #34657 -- Made msg_prefix handling in assertURLEqual()/assertInHTML consistent with other assertions.
    https://github.com/django/django/pull/17333 - Used Node.js 20 for GitHub actions.
    https://github.com/django/django/pull/17337 - Corrected wrap_socket() reference in docs/ref/settings.txt.
    https://github.com/django/django/pull/17341 - Refs #22936 -- Doc'd Lookup.prepare_rhs.
    https://github.com/django/django/pull/17343 - Fixed #34889 -- Fixed get_prefetch_queryset() fallback in prefetch_one_level().

Best,
Mariusz

[Mariusz Felisiak]

Week ending October 15

Triaged:
    https://code.djangoproject.com/ticket/34894 - Query.change_aliases() has several significant bugs (needsinfo)
    https://code.djangoproject.com/ticket/34895 - Reverse migrations fail with mysql / mariadb with sql_safe_updates set to 1 (duplicate)
    https://code.djangoproject.com/ticket/12075 - Add wsgiorg.routing args support (wontfix)
    https://code.djangoproject.com/ticket/34898 - Adding non-deterministic collations to unique CharFields crashes on PostgreSQL. (accepted)
    https://code.djangoproject.com/ticket/14761 - URL resolving / reversing design doesn't allow alternate specs (needsinfo)
    https://code.djangoproject.com/ticket/34900 - Python 3.13 compatibility. (someday/maybe)

Reviewed/committed:
    https://github.com/django/django/pull/17349 - Refs #34043 -- Clarified how to test UI changes.
    https://github.com/django/django/pull/17351 - [5.0.x] Refs #26029 -- Improved get_storage_class() deprecation warning with stacklevel=2.
    https://github.com/django/django/pull/17194 - Fixed #12241 -- Preserved query strings when using "Save and continue/add another" in admin.
    https://github.com/django/django/pull/17359 - Refs #34840 -- Improved release note describing index regression.

Reviewed:
    https://github.com/django/django/pull/17308 - Fixed #34808 -- Doc'd aggregate default argument.

Authored:
    https://github.com/django/django/pull/17348 - Added backticks to setuptools in docs.
    https://github.com/django/django/pull/17354 - Refs #34882 -- Fixed GISFunctionsTests.test_asgeojson_option_0() test on Oracle.
    https://github.com/django/asgiref/pull/414 - Dropped Python 3.7 support.
    https://github.com/django/django/pull/17356 - Refs #34840 -- Fixed test_validate_nullable_textfield_with_isnull_true() on databases that don's support table check constraints.
    https://github.com/django/asgiref/pull/412 - Added Python 3.12 support.
    https://github.com/django/django/pull/17367 - Refs #34900, Refs #34118 -- Updated assertion in test_skip_class_unless_db_feature() test on Python 3.12.1+.

Best,
Mariusz

[Mariusz Felisiak]

Week ending October 22

Triaged:
    https://code.djangoproject.com/ticket/34901 - Add async interface to contrib.sessions (accepted)
    https://code.djangoproject.com/ticket/34902 - django.test.client.Client.head request fails on AttributeError as_sync is missing (worksforme)
    https://code.djangoproject.com/ticket/34903 - Parallel test runner failure on Windows (accepted)
    https://code.djangoproject.com/ticket/34904 - Changing email object after sending mutates mail in mail.outbox (accepted)
    https://code.djangoproject.com/ticket/34905 - Main landmark is on the wrong element (accepted)
    https://code.djangoproject.com/ticket/34906 - Need help with makemigrations (invalid)
    https://code.djangoproject.com/ticket/34911 - Admindocs index skips from h1 to h3 (accepted)
    https://code.djangoproject.com/ticket/34914 - Postgres connection is not restarted after it's dropped by the server, even if we use CONN_HEALTH_CHECKS=True (duplicate)
    https://code.djangoproject.com/ticket/34915 - Do not autopopulate _order field for model with an order_with_respect_to if already set. (wontfix)
    https://code.djangoproject.com/ticket/34916 - Add support for brotli compression (wontfix)
    https://code.djangoproject.com/ticket/34907 - loaddata crashes on objects with natural keys when don't exist on passed database. (accepted)
    https://code.djangoproject.com/ticket/34917 - Links within text in the Django admin are difficult to identify (wontfix)
    https://code.djangoproject.com/ticket/34918 - Assigning model instance to `_id`/attname field saves correctly, but breaks accessing the field (invalid)
    https://code.djangoproject.com/ticket/34920 - FileExtensionValidator.__eq__() should ignore allowed_extensions order. (accepted)
    https://code.djangoproject.com/ticket/34921 - Filtering an unbound DateTimeField with naive date crashes (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/17369 - Fixed #34798 -- Fixed QuerySet.aggregate() crash when referencing expressions containing subqueries.
    https://github.com/django/django/pull/17360 - Refs #34043 -- Added context managers to SeleniumTestCase for changing window size.
    https://github.com/django/django/pull/17371 - Removed unreachable code from ModelAdmin.response_change().
    https://github.com/django/django/pull/17374 - Refs #34043 -- Added --screenshots option to runtests.py and selenium tests.
    https://github.com/django/django/pull/16963 - Refs #34043 -- Added GitHub action to capture screenshots in Selenium tests.
    https://github.com/django/django/pull/17375 - Refs #34043 -- Tweaked wording in release note.
    https://github.com/django/django/pull/17378 - Made SeleniumTests.test_select_multiple less flaky by improving Selenium waits.
    https://github.com/django/django/pull/17382 - Fixed #34905 -- Corrected admin's main content element rendered in <main> tag.
    https://github.com/django/django/pull/17385 - Fixed #34911 -- Corrected HTML heading levels on admindocs' main page.
    https://github.com/django/django/pull/17386 - Fixed #34912 -- Fixed size of back links and bookmarklet help in admindocs pages.
    https://github.com/django/django/pull/17390 - Restructured writing documentation contributing guide.
    https://github.com/django/django/pull/17387 - Fixed #34913 -- Added borders on high contrast mode in the admin.
    https://github.com/django/django/pull/17399 - Fixed #34921 -- Fixed crash of warning for unbound naive datetimes.

Authored:
    https://github.com/django/django/pull/17380 - Fixed permissions for GitHub action with screenshots.

Best,
Mariusz

[Mariusz Felisiak]

Week ending October 29

Triaged:
    https://code.djangoproject.com/ticket/34923 - MESSAGE_TAGS ignored in 5.0a1 (accepted)
    https://code.djangoproject.com/ticket/34924 - Example for squashmigration not working properly (duplicate)
    https://code.djangoproject.com/ticket/34919 - Missing scope attribute in admin doc table headers. (accepted)
    https://code.djangoproject.com/ticket/34926 - Missing model after squashing (invalid)
    https://code.djangoproject.com/ticket/34928 - makemigrations when adding a ForeignKey to a model with a UniqueConstraint must create the field before creating the constraint (duplicate)
    https://code.djangoproject.com/ticket/34930 - Parallel tests fail on Python 3.11+ and MacOS. (needsinfo)
    https://code.djangoproject.com/ticket/34931 - QuerySet .count() crashes when queryset contains FilteredRelation referencing annotation in condition (duplicate)
    https://code.djangoproject.com/ticket/34932 - Setting deterministic Postgres collations incorrectly disallows use of varchar_pattern_ops and text_pattern_ops (accepted)
    https://code.djangoproject.com/ticket/34917 - Links within text in the Django admin are difficult to identify (duplicate)
    https://code.djangoproject.com/ticket/34934 - Made EmailValidator.__eq__() ignore domain_allowlist ordering. (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/17373 - Fixed #34903, Refs #34825 -- Made workers initialization respect empty set of used connections.
    https://github.com/django/django/pull/17402 - Refs #34118 -- Avoided repeat coroutine checks in MiddlewareMixin.
    https://github.com/django/django/pull/17398 - Fixed #34920 -- Made FileExtensionValidator.__eq__() ignore allowed_extensions ordering.
    https://github.com/django/django/pull/17377 - Fixed #34904 -- Prevented mutating sent emails from outbox in locmem email backend.
    https://github.com/django/django/pull/17392 - Fixed #27403 -- Doc'd that QuerySet.prefetch_related() doesn't guarantee transactional consistency.
    https://github.com/django/django/pull/17368 - Fixed #10941 -- Added {% query_string %} template tag.
    https://github.com/django/django/pull/17406 - Doc'd writing integration tests for the system check framework.
    https://github.com/django/django/pull/17420 - Fixed #34943 -- Made EmailValidator.__eq__() ignore domain_allowlist ordering.
    https://github.com/django/django/pull/17422 - Refs #29850 -- Added RowRange support for positive integer start and negative integer end.

Reviewed:
    https://github.com/django/django/pull/17384 - Fixed #15578 -- Stated the processing order of fixtures in the fixtures docs.

Authored:
    https://github.com/django/django/pull/17403 - Bumped versions in pre-commit and npm configurations.
    https://github.com/django/django/pull/17407 - Fixed #34923 -- Avoided initializing LEVEL_TAGS when importing django.contrib.messages.
    https://github.com/django/django/pull/17409 - Added missing pycon directives in various docs.
    https://github.com/django/django/pull/17412 - Fixed isolation of DatabaseWrapperLoggingTests.test_commit_debug_log().

Best,
Mariusz

[Mariusz Felisiak]

Week ending November 3

Released Django 4.2.7, 4.1.13, and 3.2.23.

Triaged:
    https://code.djangoproject.com/ticket/34941 - db_default with decimal.Decimal() doesn't return Decimal instances on Oracle. (created)
    https://code.djangoproject.com/ticket/34943 - Support passing database expressions to bulk_create()'s unique_fields. (accepted)
    https://code.djangoproject.com/ticket/34936 - db_default with decimal.Decimal() crashes on SQLite. (created)
    https://code.djangoproject.com/ticket/34938 - Allow string based generators for AutoField (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/17435 - Fixed #34927 -- Fixed admin system check for inlines with foreign keys to proxy models.
    https://github.com/django/django/pull/17437 - Refs #31300 -- Allowed testing GeneratedField without collation.
    https://github.com/django/django/pull/17427 - Fixed #34936 -- Fixed migration crash for DecimalField with db_default on SQLite.
    https://github.com/django/django/pull/17415 - Fixed #34932 -- Restored varchar_pattern_ops/text_pattern_ops index creation when deterministic collaction is set.
    https://github.com/django/django/pull/17423 - Refs #29850 -- Added exclusion support to window frames.
    https://github.com/django/django/pull/17414 - Fixed #32106 -- Preserved HTTP_HOST in test Client when following redirects.
    https://github.com/django/django/pull/17432 - Refs #34462 -- Moved ModelAdmin.log_deletion() test to a separate test case.
    https://github.com/django/django/pull/16792 - Fixed #34462 -- Made admin log actions in bulk.

Reviewed:

    https://github.com/django/django/pull/17428 - Refs #15578 -- Made cosmetic edits to fixtures docs.
    https://github.com/django/django/pull/17429 - Refs #30601 -- Fixed typos in docs/topics/db/transactions.txt.

Authored:
    https://github.com/django/django/pull/17440 - Refs #34941 -- Skipped OperationTests.test_alter_field_change_nullable_to_decimal_database_default_not_null on Oracle.

    https://github.com/django/django/pull/17441 - Fixed #34941 -- Fixed fetching decimal db_defaults for DecimalFields on Oracle.

Best,
Mariusz