Fellow Reports - August 2020

122 views
Skip to first unread message

Mariusz Felisiak

unread,
Aug 11, 2020, 2:18:39 AM8/11/20
to Django developers (Contributions to Django itself)

Week ending August 9, 2020.

Released Django 2.2.15, 3.0.9, and 3.1.

Triaged:
    https://code.djangoproject.com/ticket/31849 - django-admin startproject - Fails to create files after encountering CommandError (wontfix)
    https://code.djangoproject.com/ticket/31848 - Support namespaced django.contrib.admindocs views. (wontfix)
    https://code.djangoproject.com/ticket/31851 - list_filter not working with foreign keys (needsinfo)
    https://code.djangoproject.com/ticket/31850 - test_extraction_warning (i18n.test_extraction.BasicExtractorTests) fails with xgettext 0.21. (accepted)
    https://code.djangoproject.com/ticket/24782 - Add TestCase.assertFormValid (wontfix)
    https://code.djangoproject.com/ticket/31854 - Long model names are not wrapped in the navigation sidebar. (created)
    https://code.djangoproject.com/ticket/31856 - Add block to customize nav_ sidebar. (invalid)
    https://code.djangoproject.com/ticket/31859 - Admin side_bar showing up in models detail pages. (invalid)
    https://code.djangoproject.com/ticket/31857 - Admin side_bar showing up in login form with django-otp. (invalid)
    https://code.djangoproject.com/ticket/31863 - FK field caching behavior change between 1.11.x and 2.x (accepted)
    https://code.djangoproject.com/ticket/31864 - Session data cannot be decoded during the transition to Django 3.1. (created)
    https://code.djangoproject.com/ticket/31868 - Plural forms expression could be dangerous (duplicate)

Reviewed/committed:
    https://github.com/django/django/pull/13267 - Fixed #26977 -- Made abstract models raise TypeError when instantiating.
    https://github.com/django/django/pull/13257 - Refs #31493 -- Replaced var with const and let in JavaScriptCatalog template.
    https://github.com/django/django/pull/12163 - Used mock.Mock() in SMTPBackendTests.
    https://github.com/django/django/pull/13265 - Fixed #31831 -- Fixed migration operations ordering when adding order_with_respect_to and constraints/indexes.

Reviewed:
    https://github.com/django/django/pull/13173 - Fixed #25513 -- Extracted admin pagination to Paginator.get_elided_page_range()

Authored:
    https://github.com/django/djangoproject.com/pull/1012 - Updated download page for 3.1 release.
    https://github.com/django/djangoproject.com/pull/1013 - Updated robots.docs.txt for Django 3.1.
    https://github.com/django/djangoproject.com/pull/1014 - Updated docs-related model fixtures for 3.1 release.
    https://github.com/django/django/pull/13275 - Fixed #31854 -- Fixed wrapping of long model names in admin's sidebar.
    https://github.com/django/django/pull/13279 - Fixed #31864 -- Fixed encoding session data during transition to Django 3.1.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 17, 2020, 8:06:23 AM8/17/20
to Django developers (Contributions to Django itself)
Week ending August 16, 2020.
   
Triaged:
    https://code.djangoproject.com/ticket/31870 - App with default_app_config and without apps.py or with an empty apps.py crashes. (accepted)
    https://code.djangoproject.com/ticket/31872 - Postgres DecimalRangeField ignores bounds (wontfix)
    https://code.djangoproject.com/ticket/31873 - Count in query giving undesired results across models (invalid)
    https://code.djangoproject.com/ticket/31871 - SESSION_COOKIE_SAMESITE comment in global_settings is outdated. (accepted)
    https://code.djangoproject.com/ticket/31869 - Improving data migration using `dumpdata` and `loaddata` (wontfix)
    https://code.djangoproject.com/ticket/31874 - FK id is not used in update_or_create when id is not used directly (worksforme)
    https://code.djangoproject.com/ticket/31876 - UserManager._create_user does not respect USERNAME_FIELD. (invalid)
    https://code.djangoproject.com/ticket/31877 - TemplateView.get_context_data()'s kwargs returns SimpleLazyObjects that causes a crash when filtering. (accepted)
    https://code.djangoproject.com/ticket/31878 - Default username in createsuperuser command doesn't respect the --database option. (accepted)
    https://code.djangoproject.com/ticket/31882 - JSONField for SQLite on macos - cannot set DYLD_LIBRARY_PATH (invalid)
    https://code.djangoproject.com/ticket/31880 - QuerySet.aggregate() mixes annotated fields names. (accepted)
    https://code.djangoproject.com/ticket/31887 - OperationalError: (2006, 'MySQL server has gone away') (invalid)
    https://code.djangoproject.com/ticket/31888 - Test loader accesses MySQL before database is created. (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/13288 - Fixed #31871 -- Updated SESSION_COOKIE_SAMESITE comment in global_settings.py.
    https://github.com/django/django/pull/13287 - Fixed #31870 -- Fixed crash when populating app registry with empty or without apps module.
    https://github.com/django/django/pull/13283 - Fixed #31866 -- Fixed locking proxy models in QuerySet.select_for_update(of=())
    https://github.com/django/django/pull/13284 - Fixed #21181 -- Added Collate database function.
    https://github.com/django/django/pull/13281 - Fixed #31863 -- Prevented mutating model state by copies of model instances.
    https://github.com/django/django/pull/13295 - Fixed #31382 -- Made Model.save(update_fields=...) raise ValueError on non-concrete fields.
    https://github.com/django/django/pull/13297 - Fixes #31877 -- Used lazy() for TemplateView kwarg deprecation warning.
    https://github.com/django/django/pull/13236 - Fixed #31825 -- Made RenameField operation a noop for fields with db_column.
    https://github.com/django/django/pull/13300 - Fixed #31792 -- Made Exists() reuse QuerySet.exists() optimizations.
    https://github.com/django/django/pull/13301 - Fixed #31878 -- Made createsuperuser respect --database option in default usernames.
    https://github.com/django/django/pull/13302 - Removed unnecessary urlsplit() call and added missing items to __all__.
    https://github.com/django/django/pull/13237 - Fixed #31826 -- Made AlterField operation a noop when adding db_column.

Reviewed:
    https://github.com/django/django/pull/13292 - Fixed #31865 -- Adjusted admin sidebar template to reduce debug logging.
    https://github.com/django/django/pull/13224 - Fixed #31811 -- Added optional timing outputs to the test runner.

Authored:
    https://github.com/django/djangoproject.com/pull/1017 - Update isort, Python, and PostgreSQL.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 24, 2020, 8:39:25 AM8/24/20
to Django developers (Contributions to Django itself)
Week ending August 23, 2020.
   
Triaged:
    https://code.djangoproject.com/ticket/31892 - Added release notes about removing "type" attribute from rendered <script>'s. (accepted)
    https://code.djangoproject.com/ticket/31890 - Use keyring for setting SECRET_KEY. (wontfix)
    https://code.djangoproject.com/ticket/31893 - Django admin panel has weird look. (invalid)
    https://code.djangoproject.com/ticket/31881 - Raise Index name limit for postgres (needsinfo)
    https://code.djangoproject.com/ticket/31891 - Remove cached value of reverse side of 020 relation when updating attname. (accepted)
    https://code.djangoproject.com/ticket/31886 - Django test hits default database while running test - expecting `test_<defaultdatabasename>` (invalid)
    https://code.djangoproject.com/ticket/31895 - Process crash after upgrade to 3.1: Incorrect padding (needsinfo)
    https://code.djangoproject.com/ticket/31896 - Using unsafe PyYAML utils when loading fixtures. (wontfix)
    https://code.djangoproject.com/ticket/31897 - Example in `Using settings in Python code` documentation is misleading (invalid)
    https://code.djangoproject.com/ticket/31902 - ExclusionConstraint crashes on expression with params. (accepted)
    https://code.djangoproject.com/ticket/31899 - unexpected behaviour of get_or_create when one of the kwargs is None (duplicate)
    https://code.djangoproject.com/ticket/31903 - WebSocket OSError: headers already sent. (invalid)
    https://code.djangoproject.com/ticket/31904 - Django queryset cannot call distinct() and order_by() on separate fields. (invalid)
    https://code.djangoproject.com/ticket/31909 - Context processor mention in the AdminSite.enable_nav_sidebar requirements is incorrect. (accepted)
    https://code.djangoproject.com/ticket/31913 - PasswordResetConfirmView results in NoReverseMarch. (invalid)
    https://code.djangoproject.com/ticket/31914 - Django does not pick up .mo files when LOCALE_PATHS is unset (invalid)
    https://code.djangoproject.com/ticket/31923 - Add Support for Cross-Origin Embedder Policy and Cross-Origin Resource Policy Headers (someday/maybe)
    https://code.djangoproject.com/ticket/31922 - QuerySet.filter() against Q() with Subquery() and __in produces wrong results. (accepted)
    https://code.djangoproject.com/ticket/31921 - Python 3.7: new behavior of os.makedirs breaks FileSystemStorage permissions on intermediate directories (accepted)
    https://code.djangoproject.com/ticket/31916 - Combined queryset crash on combined querysets with ordering. (accepted)
    https://code.djangoproject.com/ticket/31927 - Table of Contents should be sticky in Django Docs (invalid)
    https://code.djangoproject.com/ticket/31929 - Cannot import Replace() from the django.db.models.functions. (invalid)
    https://code.djangoproject.com/ticket/31930 - Using a builtin callable as a default arg for JSONField. (wontfix)
    https://code.djangoproject.com/ticket/31931 - Django 3 performance regression. (needsinfo)
    https://code.djangoproject.com/ticket/31933 - Regression in Set-Cookie which affects Django users (wontfix)

Reviewed/committed:
    https://github.com/django/django/pull/13309 - Fixed #31888 -- Avoided module-level MySQL queries in tests.
    https://github.com/django/django/pull/13312 - Fixed #31892 -- Added backward incompatibility note about Media <script> tags changes.
    https://github.com/django/django/pull/13313 - Fixed #27679 -- Doc'd that empty formsets display extra + min_num forms.
    https://github.com/django/django/pull/13323 - Fixed #31902 -- Fixed crash of ExclusionConstraint on expressions with params.
    https://github.com/django/django/pull/13328 - Fixed #31909 -- Fixed typo in docs/ref/contrib/admin/index.txt.
    https://github.com/django/django/pull/13336 - Fixed #31906 -- Fixed typo in docs/ref/forms/fields.txt.
    https://github.com/django/django/pull/13337 - Fixed #31925 -- Fixed typo in docs/releases/3.0.txt.

Reviewed:
    https://github.com/django/django/pull/12387 - Fixed #31216 -- Added support for colorama terminal colors on Windows.

Authored:
    https://github.com/django/django/pull/13317 - Refs #9061, Refs #20347 -- Added absolute_max and can_delete_extra arguments to generic_inlineformset_factory().
    https://github.com/django/django/pull/13321 - Fixed #31895 -- Fixed crash when decoding invalid session data.

Best,
Mariusz

Mariusz Felisiak

unread,
Aug 31, 2020, 7:04:35 AM8/31/20
to Django developers (Contributions to Django itself)
Week ending August 30, 2020.

Triaged:
    https://code.djangoproject.com/ticket/31934 - Document that "SameSite" has defaults in some browsers. (accepted)
    https://code.djangoproject.com/ticket/31928 - Coroutine passed to the first middleware's process_response() instead of HttpResponse. (accepted)
    https://code.djangoproject.com/ticket/31932 - Unique checking in formsets should exclude forms marked for deletion. (accepted)
    https://code.djangoproject.com/ticket/31935 - The add link on sidebar are slipped when use japanese or chinese language (duplicate)
    https://code.djangoproject.com/ticket/19878 - Stop TemplateView automatically passing kwargs into the context (wontfix)
    https://code.djangoproject.com/ticket/31936 - JSONField not filtering correct with __in lookup on key transforms. (accepted)
    https://code.djangoproject.com/ticket/31939 - Allow to specify a custom --add-comments option to pass to xgettext in makemessages. (wontfix)
    https://code.djangoproject.com/ticket/31940 - Order of WHERE clauses do not match the order of the arguments to .filter(). (wontfix)
    https://code.djangoproject.com/ticket/31926 - Queryset crashes when recreated from a pickled query with FilteredRelation used in aggregation. (accepted)
    https://code.djangoproject.com/ticket/31924 - Support --force-color for runserver. (invalid)
    https://code.djangoproject.com/ticket/31917 - MySQL Operational Error: "Unknown column 'x' in 'having clause'" (invalid)
    https://code.djangoproject.com/ticket/31942 - SafeExceptionReporterFilter does not recurse into dictionaries with non-string keys (accepted)
    https://code.djangoproject.com/ticket/31945 - PermissionError due to unjustified attempt to access '/usr'. (duplicate)
    https://code.djangoproject.com/ticket/31946 - Admin Sidebar django 3.1 display errors (Panel is Overlapping) (duplicate)
    https://code.djangoproject.com/ticket/31947 - QuerySet.update_or_create() should use get_or_create() internally (accepted)
    https://code.djangoproject.com/ticket/31948 - Add support for tzinfo parameter to TruncDate() and TruncTime(). (accepted)
    https://code.djangoproject.com/ticket/31945 - PermissionError due to unjustified attempt to access '/usr'. (accepted)
    https://code.djangoproject.com/ticket/31951 - verbose_name_plural does not overwrite names on list (admin) (accepted)
    https://code.djangoproject.com/ticket/31952 - Using EmptyFieldListFilter with reverse relationship crashes (created)
    https://code.djangoproject.com/ticket/31953 - Model Inheritance and reverse relations (invalid)
    https://code.djangoproject.com/ticket/31943 - Queryset with values()/values_list() crashes when recreated from a pickled query. (accepted)
    https://code.djangoproject.com/ticket/31955 - Multiple email send issues (invalid)
    https://code.djangoproject.com/ticket/31954 - MigrationOptimizer mangles operation order if app name contains uppercase letters. (accepted)
    https://code.djangoproject.com/ticket/31956 - QuerySet.order_by() chained with values() crashes on JSONField with a custom decoder on PostgreSQL. (accepted)
    https://code.djangoproject.com/ticket/31959 - EmailValidator must not accept hyphen as first character (wontfix)
    https://code.djangoproject.com/ticket/31964 - NoReverseMatch at / Reverse for 'home-page' not found. 'home-page' is not a valid view function or pattern name. (invalid)
    https://code.djangoproject.com/ticket/31963 - Nested OuterRef not woking to access grandparent's ID. (worksforme)

Reviewed/committed:
    https://github.com/django/django/pull/13340 - Added assertions for the results of migrating an integer pk to AutoField.
    https://github.com/django/django/pull/13325 - Fixed #31907 -- Fixed missing validate_key() calls in cache backends.
    https://github.com/django/django/pull/13333 - Refs #30897 -- Added test for WAL option to Queryset.explain() on PostgreSQL 13+.
    https://github.com/django/django/pull/13339 - Fixed #24533 -- Dropped PostgreSQL sequence and Oracle identity when migrating away from AutoField.
    https://github.com/django/django/pull/13334 - Fixed #31905 -- Made MiddlewareMixin call process_request()/process_response() with thread sensitive.
    https://github.com/django/django/pull/13338 - Fixed #31918 -- Allowed QuerySet.in_bulk() to fetch on a single distinct field.
    https://github.com/django/django/pull/13347 - Fixed #31942 -- Made settings cleansing work with dictionary settings with non-string keys.
    https://github.com/django/django/pull/13349 - Fixed #31947 -- Made QuerySet.update_or_create() reuse get_or_create().
    https://github.com/django/django/pull/13344 - Fixed #31928 -- Fixed detecting an async get_response in various middlewares.
    https://github.com/django/django/pull/13354 - Fixed #31954 -- Fixed migration optimization for MTI model creation with parent model with mixed case app label.

Authored:
    https://github.com/django/django/pull/13341 - Fixed #31877 -- Reverted "Fixed #19878 -- Deprecated TemplateView passing URL kwargs into context."
    https://github.com/django/django/pull/13346 - Fixed #31936 -- Fixed __in lookup on key tranforms for JSONField.
    https://github.com/django/django/pull/13352 - Fixed #31912 -- Removed strict=True in Path.resolve() in project template and CommonPasswordValidator.
    https://github.com/django/django/pull/13358 - Fixed #31956 -- Fixed crash of ordering by JSONField with a custom decoder on PostgreSQL.

Best,
Mariusz
Reply all
Reply to author
Forward
0 new messages