Fellow Reports - December 2019

[Mariusz Felisiak]

Week ending December 8, 2019.

Triaged:

https://code.djangoproject.com/ticket/31049 - BooleanField error. (duplicate)
https://code.djangoproject.com/ticket/31046 - Support callable values in through_defaults. (accepted)
https://code.djangoproject.com/ticket/31045 - Squashing migrations returns "SyntaxError: Invalid token". (invalid)
https://code.djangoproject.com/ticket/29891 - Fix incorrect quoting in queryset.query (duplicate)
https://code.djangoproject.com/ticket/31053 - EmailValidator should not accept soft hyphen in email addresses. (invalid)
https://code.djangoproject.com/ticket/31050 - EmailMessage doesn't strip empty addresses from recipients in message headers (wontfix)
https://code.djangoproject.com/ticket/31056 - Add ability to override "async unsafe" checks. (accepted)
https://code.djangoproject.com/ticket/31057 - Choices enum - Inconsistent values. (invalid)
https://code.djangoproject.com/ticket/31058 - Ordering by the result of RawSQL with F expression and distinct. (duplicate)
https://code.djangoproject.com/ticket/31059 - Typo in django 3.0 releases notes. (accepted)
https://code.djangoproject.com/ticket/26424 - Allow URLValidator to skip schemes validation (wontfix)
https://code.djangoproject.com/ticket/31060 - Window expression are not allowed in conditional statements used only in the SELECT clause. (created)
https://code.djangoproject.com/ticket/31061 - Optional URL params crash some view functions. (accepted)
https://code.djangoproject.com/ticket/31063 - Make URL validators consistent. (duplicate)
https://code.djangoproject.com/ticket/30481 - Document that force_str() allows lone surrogates. (wontfix)
https://code.djangoproject.com/ticket/29039 - Disabling migrations doesn't work with --keepdb (fixed)
https://code.djangoproject.com/ticket/31064 - Migration doesn't detect precision changes in fields that ManyToMany points to. (accepted)
https://code.djangoproject.com/ticket/31065 - "django.db.utils.InterfaceError: connection already closed" in unittests. (invalid)
https://code.djangoproject.com/ticket/31067 - Python 3.7 crashes after trying to visit admin page on Windows and MacOS. (invalid)
https://code.djangoproject.com/ticket/31069 - Change in behavior for optional re matches. (accepted)
https://code.djangoproject.com/ticket/31066 - Add function docstring to manage.py main function template. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12128 - Fixed #31006 -- Doc'd backslash escaping in date/time template filters.
https://github.com/django/django/pull/12157 - Refs #29892 -- Made Selenium tests wait for popups to be ready.
https://github.com/django/djangoproject.com/pull/965 - Updated download page for 3.0 release.
https://github.com/django/django/pull/12172 - Fixed #31056 -- Allowed disabling async-unsafe check with an environment variable.
https://github.com/django/django/pull/12161 - Fixed #31046 -- Allowed RelatedManager.add()/create()/set() to accept callable values in through_defaults.
https://github.com/django/django/pull/12162 - Fixed #31024 -- Clarified {% firstof %} tag's handling of arguments.
https://github.com/django/django/pull/11582 - Fixed #23524 -- Allowed DATABASES['TIME_ZONE'] option on PostgreSQL.
https://github.com/django/django/pull/12132 - Fixed #31010 -- Allowed subdomains of localhost in the Host header by default when DEBUG=True.
https://github.com/django/django/pull/12158 - Fixed #31039 -- Added support for contained_by lookup with AutoFields, SmallIntegerField, and DecimalField.
https://github.com/django/django/pull/12009 - Fixed #23433 -- Deprecated django-admin.py entry point in favor of django-admin.
https://github.com/django/django/pull/12185 - Fixed #31060 -- Reallowed window expressions to be used in conditions outside of queryset filters.

Authored:

https://github.com/django/django/pull/12181 - Fixed #31062 -- Doc'd asgi.py in tutorials and project templates.
https://github.com/django/django/pull/12184 - Fixed #31061 -- Ignored positional args in django.urls.resolve() when all optional named parameters are missing.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending December 15, 2019.

Triaged:

https://code.djangoproject.com/ticket/31074 - Errors model abstract testing. (invalid)
https://code.djangoproject.com/ticket/31075 - CSRF token missing or incorrect when File upload path not exist. (worksforme)
https://code.djangoproject.com/ticket/31073 - SplitArrayField with BooleanField always has widgets checked after the first True value. (accepted)
https://code.djangoproject.com/ticket/31076 - dbshell crashes on Windows and Python < 3.8. (created)
https://code.djangoproject.com/ticket/31077 - Add a safeguard to debug decorators (sensitive_variables/sensitive_post_parameters) to prevent incorrect usage. (accepted)
https://code.djangoproject.com/ticket/31078 - Problem while deleting inline model record in admin model. (worksforme)
https://code.djangoproject.com/ticket/31079 - Boolean not right value in admin page. (invalid)
https://code.djangoproject.com/ticket/25361 - Unpickling of QuerySet fails in presence of abstract intermediate model (fixed)
https://code.djangoproject.com/ticket/31084 - ValueError: could not convert string to float. (invalid)
https://code.djangoproject.com/ticket/31085 - Prevent bots from submitting forms. (invalid)
https://code.djangoproject.com/ticket/31086 - Improve error message for admin.E202. (accepted)
https://code.djangoproject.com/ticket/31088 - Added support for webquery search to SearchQuery() on PostgreSQL 11+. (accepted)
https://code.djangoproject.com/ticket/12679 - In admin, inlines should be allowed to be properties (fixed)
https://code.djangoproject.com/ticket/31087 - SpatialLite backend raises ValueError when getting distance parameter. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/12188 - Fixed #31066 -- Added a docstring to main() function in manage.py template.
https://github.com/django/django/pull/12169 - Fixed #27430 -- Added -b/--buffer option to DiscoverRunner.
https://github.com/django/django/pull/12197 - Fixed #31044 -- Errored nicely when using Prefetch with a raw() queryset.
https://github.com/django/django/pull/12198 - Fixed #26480 -- Fixed crash of contrib.auth.authenticate() on decorated authenticate() methods of authentication backends.
https://github.com/django/django/pull/12193 - Fixed #31073 -- Prevented CheckboxInput.get_context() from mutating attrs.
https://github.com/django/django/pull/12196 - Fixed #31077 -- Made debug decorators raise TypeError if they're not called.
https://github.com/django/django/pull/12150 - Refs #28373 -- Stopped setting tzinfo in typecast_timestamp().
https://github.com/django/django/pull/12204 - Refs #25361 -- Added test for pickling queryset of abstract-inherited models with Meta.ordering.
https://github.com/django/django/pull/11894 - Fixed #30862 -- Allowed setting SameSite cookies flags to 'None'.
https://github.com/django/django/pull/12203 - Fixed #31069, Refs #26431 -- Doc'd RegexPattern behavior change in passing optional named groups in Django 3.0.
https://github.com/django/django/pull/12212 - Fixed #26743 -- Fixed UnboundLocalError crash when deserializing m2m fields and value isn't iterable.
https://github.com/django/django/pull/12213 - Added Algerian Arabic language.
https://github.com/django/django/pull/12216 - Refs #12679 -- Added test for using property as ModelAdmin.inlines.

Authored:

https://github.com/django/django/pull/12195 - Refs #23433 -- Fixed test_django_admin_py.DeprecationTest tests failures on Windows and Python < 3.8.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending December 22, 2019.

Released Django 3.0.1, 2.2.9, and 1.11.27.

Triaged:

https://code.djangoproject.com/ticket/31090 - Log when DB transactions are commited and rollbacked. (accepted)
https://code.djangoproject.com/ticket/31091 - ConnectionResetError: [Errno 104] Connection reset by peer with a simple GET call. (invalid)
https://code.djangoproject.com/ticket/31093 - Extend permission backend with get_queryset(user, model). (wontfix)
https://code.djangoproject.com/ticket/31094 - Subquery uses ungrouped column "table.column" from outer query. (accepted)
https://code.djangoproject.com/ticket/31095 - Related Manager set() should prepare values before checking for missing elements. (accepted)
https://code.djangoproject.com/ticket/31098 - has_add_permission() takes 2 positional arguments but 3 were given. (invalid)
https://code.djangoproject.com/ticket/31099 - ValueError: Non-reversible reg-exp portion: '(?i'. (invalid)
https://code.djangoproject.com/ticket/31015 - loss of precision of geometry coordinates on Oracle 18 (needsinfo)
https://code.djangoproject.com/ticket/31104 - OneToOneField strange behavior when saving reference. (duplicate)
https://code.djangoproject.com/ticket/31106 - Adding foreign keys and instances in the same migration crashes on PostgreSQL 10+. (accepted)
https://code.djangoproject.com/ticket/31107 - Autocomplete fields in the admin do not respect limit_choices_to. (duplicate)
https://code.djangoproject.com/ticket/31110 - Typo in docs/ref/models/expressions.txt. (accepted)
https://code.djangoproject.com/ticket/31111 - Schema Editor's add_field not able to add foreign key field (wontfix)
https://code.djangoproject.com/ticket/31113 - Throw warning when field length is greater than max_length in SQLite. (duplicate)
https://code.djangoproject.com/ticket/31112 - Schema Editor's add_field does not append "_id" to the foreign key column. (invalid)

Reviewed/committed:

https://github.com/django/django/pull/12220 - Fixed #31076 -- Fixed dbshell crash on Windows with Python < 3.8.
https://github.com/django/django/pull/12215 - Fixed #31088 -- Added support for websearch searching in SearchQuery.
https://github.com/django/django/pull/12225 - Fixed #31086 -- Improved error message for admin model inlines with more than one foreign key to the same parent.
https://github.com/django/django/pull/11811 - Fixed #30585 -- Added {% translate %} and {% blocktranslate %} template tags.
https://github.com/django/django/pull/12227 - Fixed #31094 -- Included columns referenced by subqueries in GROUP BY on aggregations.
https://github.com/django/django/pull/12231 - Fixed #31095 -- Made RelatedManager.set() preserve existing m2m relations with an invalid type.
https://github.com/django/django/pull/11791 - Documentation updates: Sites reference and assertNumQueries().
https://github.com/django/django/pull/11773 - Refs #30767 -- Improved deployment documentation.
https://github.com/django/django/pull/12236 - Fixed #31110 -- Fixed typo in docs/ref/models/expressions.txt.

Authored:

https://github.com/django/django/pull/12232 - Fixed #31106 -- Fixed migrations crash on PostgreSQL 10+ when adding FK constraints inline and changing data.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending December 29, 2019.

Triaged:

https://code.djangoproject.com/ticket/31116 - Running test in parallel seems broken. (invalid)
https://code.djangoproject.com/ticket/31115 - ORM generates wrong alias for subquery. (fixed)
https://code.djangoproject.com/ticket/31117 - ThreadTests fails due to double test_ prefix caused by TestDbCreationTests. (accepted)
https://code.djangoproject.com/ticket/31122 - Clarify how the Lookup class follow the Query Expression API. (accepted)
https://code.djangoproject.com/ticket/31124 - Model.get_FOO_display() does not work correctly with inherited choices. (needsinfo)
https://code.djangoproject.com/ticket/31118 - FileInput shouldn't display required attribute when initial data exists. (accepted)
https://code.djangoproject.com/ticket/31124 - Model.get_FOO_display() does not work correctly with inherited choices. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/12241 - Fixed #31109 -- Disabled grouping by aliases on QuerySet.exists().
https://github.com/django/django/pull/12088 - Fixed #30998 -- Added ModelChoiceIteratorValue to pass the model instance to ChoiceWidget.create_option().
https://github.com/django/django/pull/12252 - Fixed #31121 -- Cleared Site cache in SitesFrameworkTests.
https://github.com/django/django/pull/12246 - Fixed #31114 -- Fixed HttpRequest.build_absolute_uri() crash with reverse_lazy() locations.

Best regards,

Mariusz