Fellow Reports - February 2023

[Mariusz Felisiak]

Week ending February 5, 2023

Released Django 4.1.6, 4.0.9, and 3.2.17.

Triaged:
    https://code.djangoproject.com/ticket/34301 - "show_save_as_new" in admin can add without this permission (accepted)
    https://code.djangoproject.com/ticket/34304 - Adding and removing a conditional UniqueConstraint to ForeignKey multiple times crashes on MySQL (accepted)
    https://code.djangoproject.com/ticket/34307 - Issue with min_num logic in InlineFormsets (needsinfo)
    https://code.djangoproject.com/ticket/16180 - IGNORED_PARAMS customization (wontfix)
    https://code.djangoproject.com/ticket/34308 - Create Serializers for models (wontfix)
    https://code.djangoproject.com/ticket/34310 - Add deletion example at one_to_one relations documentation (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16499 - Fixed #34283 -- Escaped title in admin's changelist filters.
    https://github.com/django/django/pull/16510 - Fixed #34180 -- Added note about resetting language in test tear-downs.
    https://github.com/django/django/pull/16509 - Fixed #34304 -- Made MySQL's SchemaEditor.remove_constraint() don't create foreign key index when unique constraint is ignored.
    https://github.com/django/django/pull/16516 - Refs #33476 -- Applied Black's 2023 stable style.
    https://github.com/django/django/pull/16517 - Fixed #34286 -- Fixed admindocs markups for case-sensitive template/view names.
    https://github.com/django/django/pull/16454 - Fixed #34259 -- Passed called_from_command_line to command subparsers.

Authored:
    https://github.com/django/django/pull/16518 - Improved error message for ASCIIUsernameValidator.
    https://github.com/django/django/pull/16521 - [4.2.x] Increased the default PBKDF2 iterations for Django 4.2.
    https://github.com/django/django/pull/16522 - Increased the default PBKDF2 iterations for Django 5.0.

Best,
Mariusz

[Mariusz Felisiak]

Week ending February 12, 2023

Triaged:
   https://code.djangoproject.com/ticket/34312 - startapp/startproject template should support file renames with the full context (wontfix)
   https://code.djangoproject.com/ticket/32775 - LiveServerTestCase fails when query expressions are used for model ordering (fixed)
   https://code.djangoproject.com/ticket/34313 - Thousands separator for Spanish language is incorrect (accepted)
   https://code.djangoproject.com/ticket/34315 - Close button read only changeview of admin does not preserve filters (accepted)
   https://code.djangoproject.com/ticket/34316 - Visual regressions in admin's change password form (created)
   https://code.djangoproject.com/ticket/34318 - Add a release note that makemessages no longer changes .po files when up to date. (accepted)
   https://code.djangoproject.com/ticket/34319 - Model.validate_constraints() crashes when constraint's validate() raises ValidationError without a code. (accepted)
   https://code.djangoproject.com/ticket/34321 - Unexpected query result after call QuerySet.only() to ForeignKey() with 'self' reference (invalid)
   https://code.djangoproject.com/ticket/34320 - Renaming fields with truncated names don't remove old constraints on Oracle. (accepted)
   https://code.djangoproject.com/ticket/34325 - Clarify PercentRank() description. (accepted)
   https://code.djangoproject.com/ticket/34326 - Standardize case for commands (invalid)
   https://code.djangoproject.com/ticket/34329 - django-formset new app - i am facing the issue Uncaught (in promise) SyntaxError: JSON.parse (invalid)
   https://code.djangoproject.com/ticket/34330 - QuerySet of a model having Meta.ordering, returns the sortable field in values_list() and values() (duplicate)

Reviewed/committed:
   https://github.com/django/django/pull/16489 - Made PostgreSQL's SchemaEditor._create_index_sql() respect the "sql" argument.
   https://github.com/django/django/pull/16527 - Fixed #34301 -- Made admin's submit_row check add permission for "Save as new" button.
   https://github.com/django/django/pull/16334 - Fixed #34310 -- Added deletion example to one-to-one topic.
   https://github.com/django/django/pull/16519 - Fixed #33638 -- Fixed GIS lookups crash with geography fields on PostGIS.
   https://github.com/django/django/pull/16512 - Fixed #34285 -- Fixed index/slice lookups on filtered aggregates with ArrayField.
   https://github.com/django/django/pull/16529 - Fixed #34317 -- Renamed "instance" argument of BaseModelFormSet.save_existing() method.
   https://github.com/django/django/pull/16459 - Removed hardcoded date in SetCookieTests.test_far_expiration().
   https://github.com/django/django/pull/16531 - Fixed #34315 -- Preserved admin changelist filters on "Close" button.
   https://github.com/django/django/pull/16524 - Fixed #34311 -- Updated serialization docs from unique_together to UniqueConstraint.
   https://github.com/django/django/pull/16536 - Fixed #34248 -- Added tox.ini to MANIFEST.in.
   https://github.com/django/django/pull/16538 - Fixed #34324 -- Mentioned Discord server in contributing index.
   https://github.com/django/django/pull/16319 - Fixed #32813 -- Made runserver display port after binding.
   https://github.com/django/django/pull/16539 - Fixed #34325 -- Corrected wording in PercentRank() docs.
   https://github.com/django/django/pull/16537 - Refs #34140 -- Applied rst code-block to non-Python examples.
   https://github.com/django/django/pull/16435 - Fixed #33213 -- Doc'd testing code coverage in parallel and used it.

Reviewed:
   https://github.com/django/django/pull/16530 - Refs #34146 -- Fixed typos in tutorial.
   https://github.com/django/django/pull/16528 - Fixed #34313 -- Updated thousands separator for Spanish (ES) locale.
   https://github.com/django/django/pull/16534 - Added missing vars to AdminSite.each_context() docs.

Authored:
   https://github.com/django/django/pull/16533 - Fixed #34319 -- Fixed Model.validate_constraints() crash on ValidationError with no code.
   https://github.com/django/django/pull/16534 - Added missing vars to AdminSite.each_context() docs.

Best,
Mariusz

[Mariusz Felisiak]

Week ending February 19, 2023

Triaged:
   https://code.djangoproject.com/ticket/34332 - Migrations for fields with model-referencing defaults break later (needsinfo)
   https://code.djangoproject.com/ticket/34335 - Spurious error when using label_tag of CheckboxSelectMultiple widget (wontfix)
   https://code.djangoproject.com/ticket/34333 - Migrations tries to add constraint before adding a foreign key. (accepted)
   https://code.djangoproject.com/ticket/34328 - Class-based async-only middleware not detected as coroutine in MiddlewareMixin (invalid)
   https://code.djangoproject.com/ticket/34338 - Allow to customize the code attribute of ValidationError raised by BaseConstraint.validate (accepted)
   https://code.djangoproject.com/ticket/34336 - Reverting a migration with `replaces = [...]` set does not revert it (needsinfo)
   https://code.djangoproject.com/ticket/34337 - Documentation for custom related managers is contradictory (duplicate)
   https://code.djangoproject.com/ticket/34339 - Allow overriding construct_search(). (wontfix)
   https://code.djangoproject.com/ticket/34340 - Apparently wrong table name? (needsinfo)
   https://code.djangoproject.com/ticket/34341 - FileSystemFinder harsh regarding its input on Windows (invalid)
   https://code.djangoproject.com/ticket/34322 - ManifestStaticFilesStorage crashes on commented JavaScript import statements (duplicate)
   https://code.djangoproject.com/ticket/34344 - PostGIS Database Backend Overrides features_class, ops_class and introspection_class (needsinfo)
   https://code.djangoproject.com/ticket/34345 - Add system check for filter_horizontal/filter_vertical on ManyToManyFields with intermediary models.(accepted)
   https://code.djangoproject.com/ticket/34346 - QuerySet ordered by annotation with name used by select_related() field crashes with AmbiguousColumn. (accepted)
   https://code.djangoproject.com/ticket/34348 - Add medium path to the settings.py file from the time the project is created (wontfix)
   https://code.djangoproject.com/ticket/34349 - Formsets' add_fields() method fails in some circumstances if the argument index is None. (accepted)
   https://code.djangoproject.com/ticket/34350 - WSGIRequest crashes when "wsgi.input" is None. (invalid)
   https://code.djangoproject.com/ticket/34351 - Slash in constraint name results in invalid migration file naming (duplicate)

Reviewed/committed:
   https://github.com/django/django/pull/16548 - Fixed #34316 -- Fixed layout of admin password change forms and help texts.
   https://github.com/django/django/pull/16544 - Fixed #34318 -- Added release note for 4bfe8c0eec835b8eaffcda7dc1e3b203751a790a.
   https://github.com/django/django/pull/16550 - Bumped versions in pre-commit and npm configurations.
   https://github.com/django/django/pull/16551 - Fixed #29994 -- Added warning about performance of FileBasedCache with a large number of files.
   https://github.com/django/django/pull/16511 - Fixed #34280 -- Allowed specifying different field values for create operation in QuerySet.update_or_create().
   https://github.com/django/django/pull/16532 - Fixed #34250 -- Fixed renaming model with m2m relation to a model with the same name.
   https://github.com/django/django/pull/16555 - Bumped grunt-contrib-qunit versions in npm configurations.
   https://github.com/django/django/pull/16553 - Increase coverage.
   https://github.com/django/django/pull/16545 - Refs #16247 -- Updated docs to use default <div> style and refactored docs to have less emphasis on as_* methods.
   https://github.com/django/django/pull/16557 - Fixed #34320 -- Fixed introspection of constraints on truncated column names on Oracle.
   https://github.com/django/django/pull/16515 - Fixed #34045 -- Improved accessibility of selecting items in admin changelist.
   https://github.com/django/django/pull/16562 - Fixed #34343 -- Moved built-in templates to filesystem.
   https://github.com/django/django/pull/16559 - Fixed #34342, Refs #33735 -- Fixed test client handling of async streaming responses.
   https://github.com/django/django/pull/16564 - Fixed #34302 -- Fixed SpatialReference.srid for objects without top-level authority.
   https://github.com/django/django/pull/16565 - Fixed #34347 -- Added __all__ to django.contrib.gis.utils.
   https://github.com/django/django/pull/16572 - Refs #33308 -- Added tests for queryset ordered by annotation with nulls_first/nulls_last.

Reviewed:
   https://github.com/django/django/pull/16554 - Fixed #34328 -- Added async-only class-based middleware example.

Authored:
   https://github.com/django/django/pull/16561 - Refs #21080, Refs #34322 -- Added warning to ManifestStaticFilesStorage docs about paths in comments.

Best,
Mariusz

[Mariusz Felisiak]

Week ending February 26, 2023

Released Django 4.2b1.

Triaged:
    https://code.djangoproject.com/ticket/34354 - models. Manager annotate() queryset conflict with models.Model (duplicate)
    https://code.djangoproject.com/ticket/34352 - Unify terms in Signals docs. (accepted)
    https://code.djangoproject.com/ticket/34356 - Memory leak when generating PDFs (invalid)
    https://code.djangoproject.com/ticket/34344 - PostGIS Database Backend Overrides features_class, ops_class and introspection_class (accepted)
    https://code.djangoproject.com/ticket/34357 - UniqueConstraint doesn't violate NULL values on SQLite. (invalid)
    https://code.djangoproject.com/ticket/31445 - Chain of unions leads to incorrect SQL query on MySQL. (wontfix)
    https://code.djangoproject.com/ticket/34360 - Django development server doesn't reload on TypeError of a CharField (duplicate)
    https://code.djangoproject.com/ticket/34361 - Missing the package "gdal-bin" results in Segmentation fault. (needsinfo)
    https://code.djangoproject.com/ticket/34362 - FilteredRelation doesn’t support conditional expression (accepted)
    https://code.djangoproject.com/ticket/34363 - floatformat() crashes on "0.0000" (accepted)
    https://code.djangoproject.com/ticket/34364 - Add Today to ORM db.models.functions.datetime (wontfix)
    https://code.djangoproject.com/ticket/34365 - add_form_template used as change_form_template when adding object when only declaring change_form_template (wontfix)
    https://code.djangoproject.com/ticket/34368 - Subquery referencing WINDOW expression breaks query compilation (accepted)
    https://code.djangoproject.com/ticket/34371 - Support creating aware datetime objects using django.utils.timezone (wontfix)
    https://code.djangoproject.com/ticket/34370 - IntegerField validators don't work if the database is SQLite, leading to overflow errors (accepted)

Reviewed/committed:
    https://github.com/django/django/pull/16571 - Fixed #34346 -- Ordered selected expressions by position.
    https://github.com/django/django/pull/16569 - Fixed #34349 -- Fixed FormSet.empty_form crash when deleting extra forms is disabled.
    https://github.com/django/django/pull/16586 - Moved DatabaseIntrospection.get_table_description() internal_size release note to "Database backend API" section.
    https://github.com/django/django/pull/16578 - Fixed #34355 -- Deprecated passing positional arguments to BaseConstraint.
    https://github.com/django/django/pull/16588 - Fixed #34363 -- Fixed floatformat crash on zero with trailing zeros.
    https://github.com/django/django/pull/16591 - Refs #33829 -- Added violation_error_message to constraints' __repr__().
    https://github.com/django/django/pull/16560 - Fixed #34338 -- Allowed customizing code of ValidationError in BaseConstraint and subclasses.
    https://github.com/django/django/pull/16593 - Refs #34320 -- Added skipIf for a test requiring check constraints.
    https://github.com/django/django/pull/12716 - Doc'd that Meta.indexes is preferred to Field.db_index.
    https://github.com/django/django/pull/16595 - Fixed #34366 -- Reduced AlterField operations when optimizing migrations.

Reviewed:
    https://github.com/django/django/pull/16495 - Fixed #32539 -- Added toggleable facet filters to ModelAdmin.

Authored:
    https://github.com/django/django/pull/16582 - Refs #16969 -- Added test for not initializing PostGIS-specific stuff for non-db connections.
    https://github.com/django/django/pull/16583 - Refs #31233 -- Added DatabaseWrapper._maindb_cursor() on Oracle.
    https://github.com/django/django/pull/16584 - Refs #31445 -- Added test for nesting QuerySet.union().
    https://github.com/django/django/pull/16594 - Refs #34338 -- Fixed isolation of constraints tests.

Best,
Mariusz

[Mariusz Felisiak]

Week ending March 5, 2023

Triaged:

    https://code.djangoproject.com/ticket/34373 - Update docs on ForeignKey to suggest setting "to" and object before a string (wontfix)
    https://code.djangoproject.com/ticket/34374 - Windows 11 GIS Tests Failing (accepted)
    https://code.djangoproject.com/ticket/34376 - Admin has no support for unique constraint fields. (worksforme)
    https://code.djangoproject.com/ticket/34377 - AdminSite.catch_all_view() drops query string in redirects (accepted)
    https://code.djangoproject.com/ticket/34375 - GDAL and GIS missing LD Library error message. (invalid)
    https://code.djangoproject.com/ticket/34378 - Using in_bulk() with id_list and order_by() (accepted)
    https://code.djangoproject.com/ticket/34379 - Invalid regex pattern for password reset token in 4.2b1 (invalid)
    https://code.djangoproject.com/ticket/34381 - Postgres tests fail on Windows (accepted)
    https://code.djangoproject.com/ticket/34382 - DEFAULT_AUTO_FIELD ignored for new models (invalid)
    https://code.djangoproject.com/ticket/34385 - BaseTemporalField child fields causing AttributeError to be raised by calling form.is_valid(). (wontfix)
    https://code.djangoproject.com/ticket/34383 - Layout error in Admin when using help_text (needsinfo)
    https://code.djangoproject.com/ticket/34387 - DateFormat.P() does not follow PHP's date string format (wontfix)

Reviewed/committed:

    https://github.com/django/django/pull/16600 - Fixed #34372 -- Fixed queryset crash on order by aggregation using OrderBy.
    https://github.com/django/django/pull/16597 - Fixed #34368 -- Made subquery raise NotSupportedError when referencing outer window expression.
    https://github.com/django/django/pull/16605 - Refs #34140 -- Corrected rst code-block and various formatting issues in docs.
    https://github.com/django/django/pull/16596 - Fixed #34367 -- Updated instructions for installing GeoDjango on Windows.
    https://github.com/django/django/pull/16607 - Documented that django.setup() is called under ASGI.
    https://github.com/django/django/pull/16605 - Fixed #34374 -- Fixed GIS tests on Windows.
    https://github.com/django/django/pull/16613 - Fixed #34378 -- Made QuerySet.in_bulk() not clear odering when id_list is passed.
    https://github.com/django/django/pull/16612 - Fixed #34377 -- Fixed preserving query strings in AdminSite.catch_all_view().

    https://github.com/django/django/pull/16495 - Fixed #32539 -- Added toggleable facet filters to ModelAdmin.

    https://github.com/django/django/pull/16627 - Refs #34381, Refs #10929 -- Fixed postgres_tests.test_aggregates.TestGeneralAggretate.test_empty_result_set() on PostgreSQL 14+.

Authored:

    https://github.com/django/django/pull/16604 - Refs #34320 -- Stopped recreating check constraints when renaming fields.
    https://github.com/django/django/pull/16609 - Fixed #34140 -- Reformatted code blocks in docs with blacken-docs.
    https://github.com/django/django/pull/16616 - Moved duplicate user declarations to setUpTestData() in AdminSiteFinalCatchAllPatternTests.
    https://github.com/django/django/pull/16617 - Refs #34381 -- Fixed isolation of MigrateTests.test_migrate_fake_initial().
    https://github.com/django/django/pull/16624 - Refs #32539 -- Fixed facet filter tests on Oracle.

Best,
Mariusz