Bugfix on #29103 creates different bug

[Melvyn Sopacua | 3YOURMIND]

Hi,

I've added a comment on the commit: https://github.com/django/django/commit/3c4ff2176323dd20507e35658599da220fbe1741

Should I reopen the bug or create a new one? Also it would help to know what the return type is supposed to be or what the intention of the code is? Should the if clause be `not instance` and should we be decoding or is the test correct and should we be encoding?

--

Backend Developer

Mobile: +49 (0)160 179 6874
eMail: m...@3yourmind.com
Web: www.3yourmind.com

P.S. Ready for the #ManufacturingRevolution? Watch our new videos here.

 

P.P.S. Follow the top industry trends in our newsletter.

 

Meet us at:

Rapid+TCT | 20 - 23 May  | Detroit, USA| Booth 753

3D Print Lyon | 4 - 6 June | Lyon, FR

Rapid.Tech Fabcon 3.D  | 25 - 27 June | Erfurt, DE | Booth 2-415

 

We're hiring self-driven, innovative, AM-focused people here.

3YOURMIND GmbH

Bismarckstraße 10-12 | 10625 Berlin | Germany

 

VAT ID - USt-IdNr. gemäß § 27 a Umsatzsteuergesetz: DE296555110

Company with its registered seat in - Sitz der Gesellschaft: Berlin

Register court - Registergericht: Amtsgericht Charlottenburg (Berlin)

Register number - Registernummer: HRB 160616

Executive Manager - Geschäftsführer: Aleksander Ciszek & Stephan Kühr

[Claude Paroz]

Please create a new ticket (where you can reference the original one).

If you can provide a failing test case, it would be great.

Claude

[Melvyn Sopacua | 3YOURMIND]

Well, the testcase is a bit hard. I can reproduce it by calling `sqlmigrate` on any migration that adds a char or text field with a default value. The migration it self will go through, but sqlmigrate will fail.

I'll look into testcasing that.

--
You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group.
To unsubscribe from this group and stop receiving emails from it, send an email to django-develop...@googlegroups.com.
To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/3324c145-6f7b-468f-b98a-df738f33a557%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Claude Paroz]

For the record, the ticket is https://code.djangoproject.com/ticket/30371. The discussion continues there.

Claude

To unsubscribe from this group and stop receiving emails from it, send an email to django-d...@googlegroups.com.

To post to this group, send email to django-d...@googlegroups.com.
Visit this group at https://groups.google.com/group/django-developers.
To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/3324c145-6f7b-468f-b98a-df738f33a557%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.