Fellow Reports - June 2019

107 views
Skip to first unread message

Mariusz Felisiak

unread,
Jun 10, 2019, 3:37:14 AM6/10/19
to Django developers (Contributions to Django itself)
Week ending June 9, 2019.

Triaged:
https://code.djangoproject.com/ticket/30535 - Czech plural-forms is incorrect in translations. (invalid)
https://code.djangoproject.com/ticket/30537 - ForeignKey: inconsistent handling of referenced obj. id. (duplicate)
https://code.djangoproject.com/ticket/30539 - Django - “with / as” to fill block is not working. (duplicate)
https://code.djangoproject.com/ticket/30533 - Delete cascade on large tables can cause process termination on PostgreSQL. (wontfix)
https://code.djangoproject.com/ticket/30538 - Inconsistent slug generation behaviour of slugify() and prepopulated fields in Django Admin. (wontfix)
https://code.djangoproject.com/ticket/30534 - Allow `cleaned_data` to overwrite fields' default values. (accepted)
https://code.djangoproject.com/ticket/30540 - Django left join with AND condition. (invalid)
https://code.djangoproject.com/ticket/30541 - Django MultiDB tests not loading fixtures as expected. (invalid)
https://code.djangoproject.com/ticket/30543 - admin.E108 is raised on fields accessible only via instance. (accepted)
https://code.djangoproject.com/ticket/30544 - Django 2.1 release notes don't mention the BooleanField(blank=False) default change. (duplicate)
https://code.djangoproject.com/ticket/30545 - admin.E108 is raised on fields accessible only via instance. (duplicate)
https://code.djangoproject.com/ticket/30546 - isinstance() call on SimpleLazyObject doesn't swallow evaluation exceptions on Python3. (wontfix)
https://code.djangoproject.com/ticket/30547 - Document what happens during model validation with Meta.constraints. (accepted)
https://code.djangoproject.com/ticket/30548 - Improve exceptions about mixed types in Expressions. (accepted)
https://code.djangoproject.com/ticket/30550 - TestClient's response.json() should decode content using the response charset. (accepted)
https://code.djangoproject.com/ticket/30551 - urlize on URL with incomplete query string adds equal sign. (wontfix)
https://code.djangoproject.com/ticket/30552 - GEOSGeometry.reverse() loses SRID. (accepted)
https://code.djangoproject.com/ticket/30553 - Misleading logging documentation about disable_existing_loggers default value. (accepted)

Reviewed/committed:
https://github.com/django/django/pull/11216 - Fixed #28604 -- Prevented ManifestStaticFilesStorage from leaving intermediate files.
https://github.com/django/django/pull/11433 - Fixed #30534 -- Fixed overriding a field's default in ModelForm.cleaned_data()
https://github.com/django/django/pull/11427 - Fixed #30520 -- Fixed crash of admin model inlines on custom fields without labels.
https://github.com/django/django/pull/11429 - Fixed #30505 -- Doc'd how changes in the order of Field.choices affect migrations.
https://github.com/django/django/pull/11443 - Fixed #30542 -- Fixed crash of numerical aggregations with filter.
https://github.com/django/django/pull/11037 - Fixed #30226 -- Added BaseBackend for authentication.
https://github.com/django/django/pull/11066 - Fixed #29706 -- Made RenameContentType._rename() save to the correct database.
https://github.com/django/django/pull/11449 - Fixed #30550 -- Fixed decoding of non-UTF-8 bytes objects in response.json().
https://github.com/django/django/pull/11446 - Fixed #30521 -- Fixed invalid HTML in default error pages.

Reviewed:
https://github.com/django/django/pull/11438 - Updated release process for oss-security list content guidelines.

Authored:
https://github.com/django/django/pull/11439 - Removed redundant object descriptions to prevent warnings with Sphinx 2.1.0.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jun 17, 2019, 1:49:24 AM6/17/19
to Django developers (Contributions to Django itself)
Week ending June 16, 2019.

Updated MariaDB to 10.2.24 on Jenkins.

Triaged:
https://code.djangoproject.com/ticket/30557 - order_by() a parent model crash when Meta.ordering contains expressions. (accepted)
https://code.djangoproject.com/ticket/30559 - Django 2.2 | Auto-reload doesn't detect changes in new apps. (needsinfo)
https://code.djangoproject.com/ticket/30558 - Autocompletion should be disabled in the "Add user" form. (duplicate)
https://code.djangoproject.com/ticket/30560 - Error: Submission rejected as potential spam. (invalid)
https://code.djangoproject.com/ticket/30562 - Document MariaDB support for GIS spatial lookups. (created)
https://code.djangoproject.com/ticket/30563 - Optimize django.forms.widgets.Media.__add__. (accepted)
https://code.djangoproject.com/ticket/30564 - Cannot create custom field that returns a queryset AND uses pre_save(). (invalid)
https://code.djangoproject.com/ticket/24386 - Querysets with filters and exclusions based on deep relations build invalid queries. (duplicate)
https://code.djangoproject.com/ticket/30569 - Count and Sum annotation interfere with each other. (duplicate)

Reviewed/committed:
https://github.com/django/django/pull/11451 - Avoided useless query and hasher call in ModelBackend.authenticate() when credentials aren't provided.
https://github.com/django/djangoproject.com/pull/914 - Removed Chinese How-to from robots.docs.txt.
https://github.com/django/django/pull/11456 - Fixed #30553 -- Clarified the default value of disable_existing_loggers.
https://github.com/django/django/pull/11457 - Fixed #30548 -- Improved exception when expression contains mixed types.
https://github.com/django/django/pull/11376 - Fixed #30486 -- Fixed the default value of Aggregate.distinct and updated example of custom aggregate functions.
https://github.com/django/django/pull/11459 - Fixed #27486 -- Fixed Python 3.7 DeprecationWarning in intword and filesizeformat filters.
https://github.com/django/django/pull/10910 - Fixed #30128 -- Fixed handling timedelta timezone in database functions.

Reviewed:
https://github.com/django/django/pull/11417 - Fixed #30512 -- Used email.headerregistry.parser for parsing emails in sanitize_address().

Authored:
https://github.com/django/django/pull/11467 - Fixed GISFunctionsTests.test_asgeojson() crash on MariaDB 10.2+.
https://github.com/django/django/pull/11468 - Added missing support for PointOnSurface function on MariaDB.
https://github.com/django/django/pull/11469 - Refs #29548 -- Doc'd MariaDB support for GIS database functions.

I was off on Friday.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jun 24, 2019, 1:52:37 AM6/24/19
to Django developers (Contributions to Django itself)
Week ending June 23, 2019.

Triaged:
https://code.djangoproject.com/ticket/30570 - Integrity errors in Django project with custom User model. (worksforme)
https://code.djangoproject.com/ticket/30568 - Definition of URLconf appears in tutorial 3; first mention is in tutorial 1. (wontfix)
https://code.djangoproject.com/ticket/30567 - Start passing FileResponse.block_size to wsgi.file_wrapper. (accepted)
https://code.djangoproject.com/ticket/30571 - Incorrect value of kwargs in pre_init signal documentation. (invalid)
https://code.djangoproject.com/ticket/30572 - Composed queries cannot change the list of columns with values()/values_list(). (created)
https://code.djangoproject.com/ticket/30573 - Don't assume that things are "easy"/"obvious"/"simple" in the docs. (accepted)
https://code.djangoproject.com/ticket/30574 - Support join tables query over two tables without foreign key. (invalid)
https://code.djangoproject.com/ticket/30575 - Union of TruncBase annotations with different tzinfo apply `convert_value` of last tzinfo. (wontfix)
https://code.djangoproject.com/ticket/30576 - Code not working on Django Tutorial part 6. (worksforme)
https://code.djangoproject.com/ticket/30578 - SelectDateWidget doesn't use DATE formats properly when settings.USE_L10N=False. (accepted)
https://code.djangoproject.com/ticket/30579 - Add management command to delete all tables. (wontfix)
https://code.djangoproject.com/ticket/30582 - Redirect by using 307/308 instead of 301/302. (wontfix)
https://code.djangoproject.com/ticket/30583 - XML serializer doesn't handle JSONFields. (accepted)

Reviewed/committed:
https://github.com/django/django/pull/11483 - Fixed typos and example in signals.pre_init docs.
https://github.com/django/django/pull/10554 - Fixed #29834 -- Fixed column mismatch crash with QuerySet.values()/values_list() and order_by() on combined querysets.
https://github.com/django/django/pull/11209 - Fixed #30451 -- Added ASGI handler and coroutine-safety.
https://github.com/django/django/pull/11298 - Fixed #30421 -- Allowed symmetrical intermediate table for self-referential ManyToManyField.
https://github.com/django/django/pull/11498 - Bumped minimum ESLint version to 4.18.2.

Reviewed:
https://github.com/django/django/pull/11478 - Fixed #30547 -- Doc'd how Meta.constraints affect model validation.
https://github.com/django/django/pull/11484 - Fixed #30565 -- Closed HttpResponse when wsgi.file_wrapper closes file-like object.

Authored:
https://github.com/django/django/pull/11485 - Fixed LiveWidgetTests.test_textarea_trailing_newlines() crash on Chrome 75+.
https://github.com/django/django/pull/11490 - Fixed #30572 -- Prevented values()/values_list() on combined queryset from mutating the list of columns in querysets.

Best regards,
Mariusz

Mariusz Felisiak

unread,
Jul 1, 2019, 5:46:08 AM7/1/19
to Django developers (Contributions to Django itself)
Week ending June 30, 2019.

Triaged:
https://code.djangoproject.com/ticket/30586 - Django 2.2 compatibility with PyMySQL. (duplicate)
https://code.djangoproject.com/ticket/30587 - Cloaking exceptions raised by get_object_or_404(). (duplicate)
https://code.djangoproject.com/ticket/30588 - ipdb breaks the autoreloader. (accepted)
https://code.djangoproject.com/ticket/30584 - call_command raises ValueError when subparser dest is passed in options. (accepted)
https://code.djangoproject.com/ticket/30589 - urlize parses email addresses with apostrophes incorrectly. (accepted)
https://code.djangoproject.com/ticket/30590 - Error in the documentation of the polling app. (invalid)
https://code.djangoproject.com/ticket/30593 - Add support for check constraints on MariaDB 10.2+. (created)
https://code.djangoproject.com/ticket/30591 - MySQL: 1215 - "Cannot add foreign key constraint" when altering type of unique field referenced by ForeignKey. (accepted)
https://code.djangoproject.com/ticket/30594 - Add Cache-Control: private to never_cache decorator. (accepted)
https://code.djangoproject.com/ticket/30595 - sqlsequencereset should inform that no sequences found. (accepted)
https://code.djangoproject.com/ticket/30596 - SplitArrayField.has_changed() is always True for numeric fields. (accepted)
https://code.djangoproject.com/ticket/30598 - Create new files when overriding the default admin site. (wontfix)
https://code.djangoproject.com/ticket/30599 - Cloaking PermissionErrors raised in ManifestFilesMixin.read_manifest(). (accepted)
https://code.djangoproject.com/ticket/30597 - Improve documentation on reseting an app's migrations to zero. (accepted)
https://code.djangoproject.com/ticket/30600 - Clarifiy that ValueError raised by converter.to_python() causes 404. (accepted)
https://code.djangoproject.com/ticket/30602 - Raise ValueError in Extract lookups that don't work properly with DurationField. (accepted)
https://code.djangoproject.com/ticket/26539 - Using Annotation As Update Parameter Generates Invalid SQL. (duplicate)
https://code.djangoproject.com/ticket/30603 - Stored file locking issue when using Django on Windows with the youtube_dl package. (needsinfo)
https://code.djangoproject.com/ticket/30604 - Raise exceptions in mail_admins()/mail_managers() when settings are not in expected formats. (accepted)

Reviewed/committed:
https://github.com/django/django/pull/11477 - Fixed #26431 -- Prevented django.urls.resolve() from returning missing optional parameters.
https://github.com/django/django/pull/11510 - Fixed #30477 -- Made reverse lookup use Field.get_db_prep_value() from the target field.
https://github.com/django/django/pull/11507 - Fixed #30588 -- Fixed crash of autoreloader when __main__ module doesn't have __file__ attribute.
https://github.com/django/django/pull/11514 - Fixed #30594 -- Added 'private' Cache-Control directive to never_cache() decorator.
https://github.com/django/django/pull/11496 - Fixed #30578 -- Made SelectDateWidget respect a custom date format when USE_L10N is disabled.
https://github.com/django/django/pull/11518 - Fixed #28725 -- Prevented serializing inherited ManyToManyFields in child model.
https://github.com/django/django/pull/11129 - Fixed #28408 -- Added error message when updating with annotated expressions on joined fields.
https://github.com/django/django/pull/11517 - Fixed #30584 -- Fixed management command when using subparsers with dest parameter.
https://github.com/django/django/pull/11281 - Fixed #30400 -- Improved typography of user facing strings.

Authored:
https://github.com/django/django/pull/11520 - Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.

Best regards,
Mariusz
Reply all
Reply to author
Forward
0 new messages