Fellow Reports - May 2019

[Mariusz Felisiak]

Week ending May 5, 2019.

Released Django 2.2.1.

Triaged:

https://code.djangoproject.com/ticket/30414 - Please document scripts being used on djangoci.com. (wontfix)
https://code.djangoproject.com/ticket/30417 - Documentation missing for TemplateCommand. (wontfix)
https://code.djangoproject.com/ticket/30418 - Add --skip-checks option to management commands. (accepted)
https://code.djangoproject.com/ticket/30421 - Allow ManyToManyField using a intermediary table to be defined as symmetrical. (accepted)
https://code.djangoproject.com/ticket/30413 - admin_views.test_multidb fails with persistent test SQLite database. (accepted)
https://code.djangoproject.com/ticket/30422 - Temporary files do not get deleted on canceled upload request. (accepted)
https://code.djangoproject.com/ticket/30423 - Make PasswordResetTokenGenerator's timeout extendable. (wontfix)
https://code.djangoproject.com/ticket/30425 - Handle `jinja2.TemplateSyntaxError` when rendering a template with or without a source. (accepted)

https://code.djangoproject.com/ticket/30427 - Descriptors not accessible for inherited models. (accepted)
https://code.djangoproject.com/ticket/30428 - Custom tags not loaded. (worksforme)
https://code.djangoproject.com/ticket/30430 - Make the admin URL wrap() decorator accessible from anywhere. (wontfix)
https://code.djangoproject.com/ticket/26488 - migrate crashes when renaming a multi-table inheritance base model (duplicate)
https://code.djangoproject.com/ticket/30429 - Allow different response classes in render(). (wontfix)
https://code.djangoproject.com/ticket/30431 - Migration hangs on non default database. (worksforme)
https://code.djangoproject.com/ticket/30432 - Django development server shutdown on error. (duplicate)
https://code.djangoproject.com/ticket/30435 - __iexact not working inside validator function. (worksforme)
https://code.djangoproject.com/ticket/30433 - Authentication system is not working with Google Chrome for django 2.1 and 2.2.1. (needsinfo)
https://code.djangoproject.com/ticket/11929 - manage.py dumpdata outputs YAML in unhelpful order (fixed)

Reviewed/committed:

https://github.com/django/django/pull/11177 - Fixed #30323 -- Fixed spurious autoreload failures.
https://github.com/django/django/pull/10920 - Fixed #30148 -- Logged COPY ... TO statements in connection.queries on PostgreSQL.
https://github.com/django/django/pull/11306 - Fixed #30408 -- Fixed crash when adding check constraints with LIKE operator on Oracle and PostgreSQL.
https://github.com/django/django/pull/11295 - Fixed #20629 -- Rephrased custom user models admonition.
https://github.com/django/django/pull/11292 - Fixed #30418 -- Added --skip-checks argument to management commands.
https://github.com/django/django/pull/11299 - Fixed #30412 -- Fixed #30412 -- Fixed crash when adding check constraints with OR'ed condition on Oracle and SQLite.
https://github.com/django/django/pull/11067 - Fixed #30245 -- Added -k option to DiscoverRunner.

https://github.com/django/django/pull/11308 - Fixed #30409 -- Allowed using foreign key's attnames in unique/index_together and Index's fields.
https://github.com/django/django/pull/11278 - Fixed #30396 -- Added system checks for uniqueness of indexes and constraints names.
https://github.com/django/django/pull/10924 - Fixed #29529 -- Allowed models.fields.FilePathField to accept a callable path.
https://github.com/django/django/pull/11001 - Fixed #29692 -- Fixed removing ordering parts for multiline RawSQL expressions.
https://github.com/django/django/pull/11294 - Fixed #20122 -- Made pluralize template filter return '' on invalid input.
https://github.com/django/django/pull/11303 - Ignored pywatchman.SocketTimeout in Watchman autoreloader.

Reviewed:

https://github.com/django/django/pull/11285 - Fixed #11929 -- Make sure YAML output order is helpful.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending May 12, 2019.

Triaged:

https://code.djangoproject.com/ticket/30443 - Negative durations are displayed counterintuitively. (duplicate)
https://code.djangoproject.com/ticket/30445 - RunSQL Migration should accept psycogp2 sql.Composable object. (wontfix)
https://code.djangoproject.com/ticket/30436 - on_delete attribute must be callable. (accepted)
https://code.djangoproject.com/ticket/30441 - Persistent connections not reused on request. (accepted)
https://code.djangoproject.com/ticket/30447 - Add is_in_european_union to GeoIP2.city() dict. (accepted)
https://code.djangoproject.com/ticket/30437 - Document that urlpatterns can be an iterable object. (accepted)
https://code.djangoproject.com/ticket/30442 - Add additional validators to auth/password_validation.py (wontfix)
https://code.djangoproject.com/ticket/30440 - Temporary "required" attr is not removed if the browser doesn't supported ":valid" selector. (accepted)
https://code.djangoproject.com/ticket/30438 - GeoDjango .SHP file Specifications. (invalid)
https://code.djangoproject.com/ticket/30451 - Add ASGI support to Django. (accepted)
https://code.djangoproject.com/ticket/30450 - Cannot import AbstractBaseUser. (invalid)
https://code.djangoproject.com/ticket/30455 - Django ModelForm with multiple ForeignKey query optimisation issue.  (invalid)
https://code.djangoproject.com/ticket/30454 - doc error about "Cache key prefixing". (invalid)
https://code.djangoproject.com/ticket/30456 - Doing a select_related() after a union() results in an IndexError. (invalid)
https://code.djangoproject.com/ticket/30458 - Allow JsonResponse to automatically serialize querysets. (wontfix)
https://code.djangoproject.com/ticket/30462 - Conditional aggregation doesn't work with subquery annotations. (fixed)
https://code.djangoproject.com/ticket/30463 - Deprecation message crashes when using a query expression in Model.ordering. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/11185 - Fixed #30339 -- Made Model.delete(keep_parents=True) preserves nested parent reverse relationships.
https://github.com/django/django/pull/11194 - Fixed #29352 -- Allowed specifying a Feed language.
https://github.com/django/django/pull/11331 - Fixed #30440 -- Prevented any_selected() in SelectFilter2.js from leaving temporary required attribute.
https://github.com/django/django/pull/11245 - Fixed #26678 -- Doc'd that RelatedManager.add()/remove()/set() accepts the field the relation points to.
https://github.com/django/django/pull/11329 - Fixed #30444 -- Moved SQL generation for tables to BaseDatabaseSchemaEditor.table_sql().
https://github.com/django/django/pull/11327 - Fixed #30447 -- Added 'is_in_european_union' in GeoIP2.city() dict.
https://github.com/django/django/pull/11265 - Fixed #30349 -- Fixed QuerySet.exclude() on FilteredRelation.
https://github.com/django/django/pull/11277 - Refs #27753 -- Deprecated django.utils.text.unescape_entities().
https://github.com/django/django/pull/11323 - Fixed #29056 -- Fixed HTML5 validation of required SelectDateWidget.
https://github.com/django/django/pull/11215 - Fixed #6785 -- Made QuerySet.get() fetch a limited number of rows.

Reviewed:

https://github.com/django/django/pull/11209 - Fixed #30451 -- Implemented ASGI handler and coroutine-safety.

I was off from Thursday.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending May 19, 2019.

Triaged:

https://code.djangoproject.com/ticket/30473 - len() and count() yield different results on randomly ordered QuerySet with annotation. (duplicate)
https://code.djangoproject.com/ticket/30474 - Minor change to documentation on many-to-many relationships. (invalid)
https://code.djangoproject.com/ticket/30477 - Filtering on reverse ForeignKey relation uses get_db_prep_value from a wrong field. (accepted)
https://code.djangoproject.com/ticket/30476 - Add introspection of "json" (like "jsonb") data type as JSONField on PostgreSQL. (wontfix)
https://code.djangoproject.com/ticket/30482 - prefetch_related_objects evaluates queryset when checking for invalid prefetch ordering. (accepted)
https://code.djangoproject.com/ticket/30480 - Discrepancy in `DateTime` field value If the django orm union() is used with the empty array in the filter. (worksforme)
https://code.djangoproject.com/ticket/30479 - Autoreloader with StatReloader doesn't track changes in manage.py. (accepted)
https://code.djangoproject.com/ticket/30487 - Using more than 245 functions in CombinedExpressions causes RecursionError. (wontfix)
https://code.djangoproject.com/ticket/30488 - SearchVector lookup is generating redundent Coalesce wrapper. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/11356 - Fixed #30436 -- Added check that on_delete is callable in ForeignKey and OneToOneField.
https://github.com/django/django/pull/11330 - Fixed #30437 -- Clarified that urlpatterns can be a sequence.
https://github.com/django/django/pull/11305 - Refs #27685 -- Logged unexpected Watchman autoreloader errors.
https://github.com/django/django/pull/11338 - Fixed #30316 -- Added source code link to the default logging configuration in logging docs.
https://github.com/django/django/pull/11369 - Fixed #30482 -- Prevented unnecessary evaluation of lookup.queryset in prefetch_related_objects().
https://github.com/django/django/pull/11353 - Fixed #30459 -- Delegated hide/show JS toggle to parent div.
https://github.com/django/django/pull/11033 - Fixed #30220 -- Added support for headless mode in selenium tests.
https://github.com/django/django/pull/11334 - Fixed #30453 -- Fixed crash of simple_tag() and inclusion_tag() when function is wrapped.
https://github.com/django/django/pull/11293 - Fixed #30395 -- Doc'd a limitation of ModelForm.Meta.widgets.
https://github.com/django/django/pull/11377 - Fixed #30463 -- Fixed crash of deprecation message when Meta.ordering contains expressions.

I was off for almost entire week.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending May 26, 2019.

Triaged:

https://code.djangoproject.com/ticket/30490 - migrations unique_index on (app, name). (wontfix)
https://code.djangoproject.com/ticket/30491 - Document changing primary key behavior in "How Django knows to UPDATE vs. INSERT" section. (accepted)
https://code.djangoproject.com/ticket/30492 - "B" seen as time-related format specifier. (invalid)
https://code.djangoproject.com/ticket/30495 - Use self-closing br in linebreaksbr templatetag. (wontfix)
https://code.djangoproject.com/ticket/30493 - GenericRelation and prefetch_related: wrong caching with cyclic prefetching. (accepted)
https://code.djangoproject.com/ticket/30497 - assertXMLEqual fails on document type declaration. (accepted)
https://code.djangoproject.com/ticket/30498 - lazy() class preparation is not being cached correctly. (accepted)
https://code.djangoproject.com/ticket/30501 - Queryset ordering and Meta.ordering are mutable on expressions with reverse() (created).
https://code.djangoproject.com/ticket/30502 - Admin interface hangs on models with "parentNode" field. (invalid)
https://code.djangoproject.com/ticket/30503 - ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host. (invalid)
https://code.djangoproject.com/ticket/9982 - Inconsistent behavior on model save depending on whether OneToOneField is a primary key (fixed)
https://code.djangoproject.com/ticket/29085 - Possible data loss on .save() with unsaved related model. (duplicate)
https://code.djangoproject.com/ticket/30507 - Update admin's jQuery to 3.4.X. (created)
https://code.djangoproject.com/ticket/30506 - Auto-reloading with StatReloader very intermittently throws "ValueError: embedded null byte". (needsinfo)

Reviewed/committed:

https://github.com/django/django/pull/11380 - Fixed #30488 -- Removed redundant Coalesce call in SQL generated by SearchVector.
https://github.com/django/django/pull/11368 - Fixed #27635 -- Used secrets module in django.utils.crypto.
https://github.com/django/django/pull/11393 - Fixed #29396, #30494 -- Added indirect values support to __year lookups.
https://github.com/django/django/pull/11389 - Fixed #28763 -- Allowed overriding the session cookie age with SessionStore.get_session_cookie_age().
https://github.com/django/django/pull/11383 - Fixed #28147 -- Fixed loss of assigned parent when saving child after parent.
https://github.com/django/django/pull/11355 - Fixed #28816 -- Prevented silencing data loss when decreasing CharField.max_length on PostgreSQL.
https://github.com/django/django/pull/11296 - Fixed #30419 -- Favored Meta.indexes over Meta.index_together in optimization docs.
https://github.com/django/django/pull/11399 - Fixed #30498 -- Fixed proxy class caching in lazy().
https://github.com/django/django/pull/11402 - Fixed #30497 -- Ignored document type in assertXMLEqual()/assertXMLNotEqual().
https://github.com/django/django/pull/11410 - Fixed #30504 -- Corrected redirect() signature in docs.
https://github.com/django/django/pull/11189 - Fixed #28780 -- Allowed specyfing a token parameter displayed in password reset URLs.

Authored:

https://github.com/django/django/pull/11384 - Fixed #26192 -- Raised a FieldError when ordering by expressions with unresolved output_field.
https://github.com/django/django/pull/11401 - Fixed #29548 -- Updated docs for MariaDB support.
https://github.com/django/django/pull/11405 - Fixed #30501 -- Preventing QuerySet.reverse() from mutating expressions in QuerySet.order_by and Meta.ordering.

Best regards,

Mariusz

[Mariusz Felisiak]

Week ending June 2, 2019.

Triaged:

https://code.djangoproject.com/ticket/30508 - Add Password Reset Via Email to documentation. (invalid)
https://code.djangoproject.com/ticket/30510 - bulk_create() crashes with mixed length arguments on LOB fields on Oracle. (accepted)
https://code.djangoproject.com/ticket/30512 - Update mail backend to use modern standard library parsing approach. (accepted)
https://code.djangoproject.com/ticket/30475 - Use of i18n_patterns and a buggy 404 template trigger internal server error without a backtrace. (invalid)
https://code.djangoproject.com/ticket/30499 - PasswordResetView should be allowed to set `domain_override`. (invalid)
https://code.djangoproject.com/ticket/30513 - Impossible migration (with a change of model base) is not noticed. (duplicate)
https://code.djangoproject.com/ticket/30515 - Document django.shortcuts.resolve_url. (wontfix)
https://code.djangoproject.com/ticket/30516 - Autoreloader crashes on re-raising exceptions with custom signature. (accepted)
https://code.djangoproject.com/ticket/30517 - Add Redis cache backend. (wontfix)
https://code.djangoproject.com/ticket/30518 - Multiple Count annotation with filter doesn't work properly. (duplicate)
https://code.djangoproject.com/ticket/30520 - ModelForm with field without label crashes when used in InlineModelAdmin. (accepted)
https://code.djangoproject.com/ticket/30521 - Default error webpages are not correctly-formed html pages. (accepted)
https://code.djangoproject.com/ticket/30522 - How to use Custom install Sqlite3 in Django. (invalid)
https://code.djangoproject.com/ticket/30526 - migration to UUID id field doesn't properly convert integers (SQLite). (invalid)
https://code.djangoproject.com/ticket/30523 - StatReloader does not update file times if notify_file_changed() is triggered. (accepted)
https://code.djangoproject.com/ticket/30511 - Support Identity columns on PostgreSQL. (accepted)
https://code.djangoproject.com/ticket/30527 - Problem with creating migrations for subclassed field changes. (invalid)
https://code.djangoproject.com/ticket/30532 - Union queryset should raise on filter() and exclude(). (duplicate)

Reviewed/committed:

https://github.com/django/django/pull/11406 - Refs #24944 -- Added test for overriding domain in email context in PasswordResetView.
https://github.com/django/django/pull/11422 - Fixed #30479 -- Fixed detecting changes in manage.py by autoreloader when using StatReloader.
https://github.com/django/django/pull/11413 - Fixed crash of ArrayAgg and StringAgg with ordering when used in Subquery.
https://github.com/django/django/pull/11390 - Fixed #30491 -- Clarified when save() on object with pk executes INSERT.
https://github.com/django/django/pull/11428 - Fixed #30516 -- Fixed crash of autoreloader when re-raising exceptions with custom signature.
https://github.com/django/django/pull/11419 - Fixed #30523 -- Fixed updating file modification times on seen files in auto-reloader when using StatReloader.
https://github.com/django/django/pull/11415 - Fixed #28520 -- Added --start-at/--start-after options to runtests.py.
https://github.com/django/django/pull/11431 - Fixed #28831 -- Doc'd that InlineModelAdmin methods' obj argument is the parent object.
https://github.com/django/django/pull/11423 - Fixed #30493 -- Fixed prefetch_related() for GenericRelation with different content types.

Best regards,

Mariusz