Fellow Reports - April 2019

[Mariusz Felisiak]

Week ending April 7, 2019.

Triaged:

https://code.djangoproject.com/ticket/30302 - model_to_dict() should return an empty dict for an empty list of fields. (accepted)
https://code.djangoproject.com/ticket/30304 - Support setting Secure, HttpOnly, SameSite on the language cookie (accepted)
https://code.djangoproject.com/ticket/30305 - Feature to set the returncode of a django custom command (invalid)
https://code.djangoproject.com/ticket/30307 - dbshell doesn't pass password properly on Oracle 18c. (accepted)
https://code.djangoproject.com/ticket/30309 - Remove hasattr reference in One-to-One documentation example (invalid)
https://code.djangoproject.com/ticket/30315 - StringAgg with ordering in subquery generates invalid string_agg() SQL function call (accepted)
https://code.djangoproject.com/ticket/30319 - model.save() surprising behavior with update_fields specified and auto_now field in model (wontfix)
https://code.djangoproject.com/ticket/30325 - Inconsistent count() behaviour on reverse relations in ManyToManyFields with custom model manager (accepted)
https://code.djangoproject.com/ticket/30327 - Failing collectstatic with ManifestFilesMixin (invalid)
https://code.djangoproject.com/ticket/30328 - Integer field range validators crash when limit_value is callable. (accepted)
https://code.djangoproject.com/ticket/30322 - DEBUG=False + csrf_exempt(GraphqlView) + gunicorn == crash (needsinfo)
https://code.djangoproject.com/ticket/30329 - ImproperlyConfigured exceptions should be raised immediately. (accepted)
https://code.djangoproject.com/ticket/30330 - delete() on instances of models without any dependencies doesn't clear PKs. (accepted)
https://code.djangoproject.com/ticket/30333 - __hash__ is not inherited from model.Model if __eq__ is defined (accepted)
https://code.djangoproject.com/ticket/30326 - Document how to avoid F() assignments persistence (accepted)
https://code.djangoproject.com/ticket/30321 - Add example to Form.changed_data (accepted)
https://code.djangoproject.com/ticket/30332 - Postgres ordering ARRAY_AGG and STRING_AGG do not support expression. (accepted)

Reviewed/committed:

https://github.com/django/djangoproject.com/pull/894 - Updated robots.docs.txt for Django 2.2.
https://github.com/django/django/pull/11163 - Fixed forms.model_to_dict() result if empty list of fields is passed.
https://github.com/django/django/pull/11158 - Fixed #30307 -- Fixed incorrect quoting of database user password when using dbshell on Oracle.
https://github.com/django/django/pull/11175 - Fixed bidirectionality on the congrats page.
https://github.com/django/django/pull/11172 - Fixed #30332 -- Fixed crash of ordering by expressions with params in ArrayAgg and StringAgg.

Reviewed:

https://github.com/django/django/pull/11170 - Forced utf-8 encoding when loading debug templates.
https://github.com/django/django/pull/11155 - Fixed #30304 -- Added support for the HttpOnly, SameSite, and Secure flags on language cookies.
https://github.com/django/django/pull/11138 - Fixed #28373 -- Used connection timezone instead of UTC when making dates timezone-aware on MySQL, SQLite, and Oracle.
https://github.com/django/django/pull/11095 - Added ModelAdmin.get_inlines() hook.

Authored:

https://github.com/django/django/pull/11154 - Fixed #30259 -- Fixed crash of admin views when properties don't have admin_order_field attribute.
https://github.com/django/django/pull/11161 - Made minor fixes in the "How is Django Formed?" documentation.
https://github.com/django/django/pull/11171 - Fixed #30331 -- Added support for Psycopg 2.8+.
https://github.com/django/django/pull/11174 - [2.1.x] Refs #30331 -- Doc'd that psycopg2 < 2.8 is required.

Best regards,
Mariusz

[Mariusz Felisiak]

Week ending April 14, 2019.

I was in Copenhagen as a coach at DjangoGirls event and I participated in the DjangoCon Europe conference.

Triaged:

https://code.djangoproject.com/ticket/30336 - F() expression wrong result on postgres JSONField (duplicate)
https://code.djangoproject.com/ticket/30337 - Django Admin - Migrations: default value for models.DateTime() with auto_add_now=True (worksforme)
https://code.djangoproject.com/ticket/30341 - Add support for furlongs unit to Distance objects. (accepted)
https://code.djangoproject.com/ticket/30343 - Prefetch related is not working when used GFK for model that uses UUID field as PK. (accepted)
https://code.djangoproject.com/ticket/30345 - documentation mistake (worksforme)
https://code.djangoproject.com/ticket/30346 - InspectDB doesn't test for UUID (at least) on PostgreSQL (duplicate)
https://code.djangoproject.com/ticket/30347 - A typo in Aggregation document. (accepted)
https://code.djangoproject.com/ticket/30353 - Recursion Error while running tests (invalid)
https://code.djangoproject.com/ticket/30350 - Migration re-add check constraint continuously when check condition contains iterator. (accepted)
https://code.djangoproject.com/ticket/30357 - Admin of app does not recognize Foreign_key field (needsinfo)
https://code.djangoproject.com/ticket/30358 - Remove redundant assertion from django/tests/forms_tests/tests/test_utils.py. (accepted)
https://code.djangoproject.com/ticket/30362 - Partial indexes and check constraints crash when inherited from abstract models. (accepted)

   
Reviewed/committed:

https://github.com/django/django/pull/11179 - Fixed #30330 -- Fixed setting of primary key to None during fast-delete.
https://github.com/django/django/pull/11098 - Fixed #30266 -- Kept a sequence owner when altering an AutoField/BigAutoField on PostgreSQL.
https://github.com/django/django/pull/11186 - Fixed #30321 -- Added example of changed_data to forms docs.
https://github.com/django/django/pull/11204 - Fixed #30347 -- Fixed typo in docs/topics/db/aggregation.txt.
https://github.com/django/django/pull/11210 - Fixed #25941 -- Improved error message for runtests.py when django is not on path.
https://github.com/django/django/pull/11213 - Fixed #30358 -- Removed redundant assertion in FormsUtilsTestCase.test_error_dict_copy().

https://github.com/django/django/pull/11214 - Fixed #30350 -- Prevented recreation of migration for operations with a range object.

   
Authored:

https://github.com/django/django/pull/11211 - Fixed #30343 -- Fixed prefetch_related() for GenericForeignKey when PK of related field is UUIDField.

[Mariusz Felisiak]

Week ending April 21, 2019.

Triaged:

https://code.djangoproject.com/ticket/30360 - Support rotation of secret keys. (accepted)
https://code.djangoproject.com/ticket/30351 - Migration auth.0011_update_proxy_permissions fails for models recreated as a proxy. (accepted)
https://code.djangoproject.com/ticket/30365 - Sphinx interprets some "%[a-z]" in SQL statements as "Literal.String.Interpol" which breaks highlighting. (accepted)
https://code.djangoproject.com/ticket/30368 - Prefetch related is not working when used GFK for model that uses FK as PK. (accepted)
https://code.djangoproject.com/ticket/30370 - Add support for postgresql client certificates and key to dbshell. (accepted)
https://code.djangoproject.com/ticket/30352 - Error al ejecutar python manage.py sin sealizar cambios (needsinfo)
https://code.djangoproject.com/ticket/30374 - Paginator UnorderedObjectListWarning on union(all=True) of two sorted queries (invalid)
https://code.djangoproject.com/ticket/30376 - Saving ModelForm with missing, non-optional fields does not trigger a validation error. (invalid)
https://code.djangoproject.com/ticket/30378 - AttributeError: 'NoneType' object has no attribute 'split'. (duplicate)
https://code.djangoproject.com/ticket/30377 - Exceptions when viewing project on local machine. (worksforme)
https://code.djangoproject.com/ticket/30379 - ProgrammingError from exclude using models.F with long relation. (duplicate)
https://code.djangoproject.com/ticket/30380 - Support mysql query objects as strings in addition to bytes, for PyMySQL support. (accepted)
https://code.djangoproject.com/ticket/28767 - Incorrect value when annotating empty list as Value() on ArrayField. (fixed)
https://code.djangoproject.com/ticket/28762 - Can't aggregate annotations with array parameters. (fixed)
https://code.djangoproject.com/ticket/30382 - force_insert flag is not passed when saving parents on inherited models. (accepted)
https://code.djangoproject.com/ticket/30354 - Filter not displayed when admin.RelatedOnlyFieldListFilter is used for auth.models.User (worksforme)
https://code.djangoproject.com/ticket/25507 - count() crashes with a RawSQL annotation. (fixed)
https://code.djangoproject.com/ticket/30373 - "Save as new" with read-only fields. (wontfix)
https://code.djangoproject.com/ticket/30390 - makemigrations requires default when adding non-nullable field even when there are no rows. (wontfix)

Reviewed/committed:

https://github.com/django/django/pull/11201 - Fixed #30326 -- Doc'd how to avoid persistence of F() assignment.
https://github.com/django/django/pull/11205 - Fixed #30325 -- Fixed inconsistent count()/exists() behavior on reverse M2M relations with custom managers.
https://github.com/django/django/pull/11173 - Refs #27149 -- Based recursive nested subquery detection of sys.getrecursionlimit().
https://github.com/django/django/pull/11235 - Fixed #14009 -- Fixed custom formset validation example in docs.
https://github.com/django/django/pull/11234 - Fixed #30368 -- Fixed prefetch_related() for GenericForeignKey when PK is also a FK.
https://github.com/django/django/pull/11236 - Fixed #14808 -- Doc'd that trans and blocktrans tags don't escape translations.
https://github.com/django/django/pull/11095 - Fixed #27755 -- Added ModelAdmin.get_inlines() hook.
https://github.com/django/django/pull/11232 - Updated SpatiaLite install instructions to suggest first package from recent Debian-based distributions.
https://github.com/django/django/pull/11087 - Fixed #30191 -- Selected only referenced fields during cascade deletion.
https://github.com/django/django/pull/11181 - Fixed #30335, #29139 -- Fixed crash when ordering or aggregating over a deep JSONField key transform.
https://github.com/django/django/pull/11239 - Fixed #30370 -- Added dbshell support for client TLS certificates on PostgreSQL.
https://github.com/django/django/pull/11231 - Fixed #30367 -- Changed "pip install" to "python -m pip install" in docs, comments and hints.
https://github.com/django/django/pull/11180 - Fixed #30328 -- Fixed crash of IntegerField.validators when limit_value in a custom validator is callable.
https://github.com/django/django/pull/11187 - Fixed #30341 -- Added support for the furlong unit in Distance.

Authored:

https://github.com/django/django/pull/11255 - Fixed #30380 -- Handled bytes in MySQL backend for PyMySQL support.

[Mariusz Felisiak]

Week ending April 28, 2019.

Triaged:

https://code.djangoproject.com/ticket/30387 - Move more Windows-specific docs to use Python official launcher. (accepted)
https://code.djangoproject.com/ticket/30388 - inspectdb generates unique ForeignKey instead of OneToOneField. (accepted)
https://code.djangoproject.com/ticket/30391 - .get() ignores .using(). (worksforme)
https://code.djangoproject.com/ticket/30386 - Admin foreign key widgets don't quote keys. (accepted)
https://code.djangoproject.com/ticket/30369 - Creating database tables from queries based on ORM API (wontfix)
https://code.djangoproject.com/ticket/30393 - Add validation of target argument in startapp command. (accepted)
https://code.djangoproject.com/ticket/30396 - Add a system check for uniqueness of partial indexes and constraints names. (created)
https://code.djangoproject.com/ticket/30397 - Allow app_label and class to be specified in the name argument for indexes and constraints. (created)
https://code.djangoproject.com/ticket/30400 - Improve typography of user facing strings. (accepted)
https://code.djangoproject.com/ticket/30401 - Clarification about when a default value is assigned to a ModelField (wontfix)
https://code.djangoproject.com/ticket/30383 - Performance issue with ThreadPoolExecutor/Multiprocessing. (worksforme)
https://code.djangoproject.com/ticket/30404 - "Using a model formset in a view" example doesn't handle invalid formset. (worksforme)
https://code.djangoproject.com/ticket/30403 - Test namespace packages discover fails to load module. (invalid)
https://code.djangoproject.com/ticket/30402 - Django default_site admin configuration doesn't register anything (worksforme)
https://code.djangoproject.com/ticket/30406 - Charfield max length error. (invalid)
https://code.djangoproject.com/ticket/30407 - Modelform initial values override instance values when both are set. (wontfix)
https://code.djangoproject.com/ticket/30408 - CheckConstraint with lookup using LIKE & % crash on PostgreSQL. (accepted)

Reviewed/committed:

https://github.com/django/django/pull/11254 - Fixed #30385 -- Restored SearchVector(config) immutability.
https://github.com/django/django/pull/11258 - Fixed #30387 -- Enhanced docs CLI examples in Unit tests and Install Django on Windows.
https://github.com/django/django/pull/11217 - Fixed #30365 -- Fixed syntax highlighting in SQL examples.
https://github.com/django/django/pull/11079 - Fixed #29810 -- Fixed crash of select_related() on FilteredRelation with empty result.
https://github.com/django/django/pull/11267 - Changed tuple Mate.unique_together/permissions to lists in docs.
https://github.com/django/django/pull/11244 - Fixed #30342 -- Removed a system check for LANGUAGES_BIDI setting.
https://github.com/django/django/pull/11273 - Refs #30241 -- Fixed BytesWarning emitted in test_translation tests.
https://github.com/django/django/pull/11260 - Fixed #30388 -- Made inspectdb generate OneToOneFields rather than ForeignKey(unique/primary_key=True).
https://github.com/django/django/pull/11270 - Fixed #30393 -- Added validation of startapp's directory option.
https://github.com/django/django/pull/11169 - Fixed #30318 -- Added check for importability of arguments of custom error handler views.
https://github.com/django/django/pull/11166 - Fixed #30312 -- Relaxed admin check from django.contrib.sessions to SessionMiddleware subclasses.
https://github.com/django/django/pull/11263 - Fixed #30361 -- Increased the default timeout of watchman client to 5 seconds and made it customizable.
https://github.com/django/django/pull/11283 - Fixed #30351 -- Handled pre-existing permissions in proxy model permissions data migration.

Reviewed:

https://github.com/django/django/pull/11276 - Fixed #30399 -- Changed django.utils.html.escape()/urlize() to use html.escape()/unescape().

Authored:

https://github.com/django/django/pull/11275 - Fixed #30362 -- Noted partial indexes and constraints restrictions with abstract base classes.

Best regards,

Mariusz