Logged out sessions are resurrected by concurrent requests (ticket 21608)

[Tore Lundqvist]

Hi, everyone!

I confirmed this (21608) non critical security bug a while ago and have sense then made a unit test and a fix for it.

I have not gotten any feedback on my PR yet, is there something more I need to do to have someone look at this?

Best Regards

Tore Lundqvist

[Tore Lundqvist]

Thanks for the feedback!

I have updated the PR, can someone have a look at it again?

I noticed that there where failing checks (flake8, isort) but it does not say why that it, do I need to fix something?

Cheers 

Tore Lundqvist

[James Pic]

Just click "Details" and then "Console output". You'll find this:

+ flake8
./django/contrib/sessions/backends/db.py:91:30: E901 SyntaxError: invalid syntax

ERROR: /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py
Imports are incorrectly sorted.
--- /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:before
2016-02-01 16:04:24.701654
+++ /home/jenkins/workspace/isort/django/contrib/sessions/backends/db.py:after
2016-02-01 16:04:30.952126
@@ -1,8 +1,10 @@
import logging

-from django.contrib.sessions.backends.base import CreateError,
SessionBase, UpdateError
+from django.contrib.sessions.backends.base import (
+ CreateError, SessionBase, UpdateError,
+)
from django.core.exceptions import SuspiciousOperation
-from django.db import IntegrityError, router, transaction, DatabaseError
+from django.db import DatabaseError, IntegrityError, router, transaction
from django.utils import timezone
from django.utils.encoding import force_text
from django.utils.functional import cached_property

[Tore Lundqvist]

Ok, got that sorted now. How about the fix, is it reasonable?

[Tore Lundqvist]

Thanks for all the help with the patch! I hope its close to being acceptable now. Can someone have a look at the PR?

[Tore Lundqvist]

Is there something I can do to move this forward?

[Tim Graham]

You could ask a friend or colleague to review the patch using the patch review checklist [1] and mark it "Ready for checkin" if it looks good. Otherwise, you just wait for someone to review it.

[1] https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#patch-review-checklist