Missing Deadline warnings

[Andy Zaidi]

On my device (latest Diplicity build 497, Android 8.0, Honor 7X), I have the "Push notifications" box checked, and "Deadline warnings minutes ahead" set to 60. While I always get notifications for new phases and messages from other users, I have never received a warning (60 min or otherwise) of a deadline.

I'm writing because I just NMRed again and had to deal with the consequences, and while that's obviously mostly on me, I'd prefer a little help from the app (especially since it seems to be a feature that already exists and just isn't working correctly).

Please let me know if I'm doing something wrong or if you need more information, thanks.

[Martin Bruse]

Thanks for the report!

First of all, is there anyone able to report that this feature works for them? Or is it completely broken?

I'm not in any real games so I myself wouldn't notice that the alarm was broken :/

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/diplicity-dev/48d79ffa-efa3-4acd-bf75-f73d8687806e%40googlegroups.com.

[Martin Bruse]

Since this feature is obnoxious to test, it always runs the risk of silently breaking.

How about this suggested fix:

In the menu, under dev options, add a checkbox for "debug phase deadline alarms", which makes all games, when loading, setup alarms for "when loaded plus 30 seconds" instead of "x minutes before deadline".

That way you see if they work, and the easier that is the likelier bugs will get fixed quickly.

Comments?

[Andy Zaidi]

That makes sense to me; I apologise if I should have posted this as an issue on github

[Ttt Ppp]

This sounds like it might have been caused by the target SDK upgrade. I had to change it from 26 to 28 due to Play Store restrictions.

Do you have anything in your error log? (Main ... menu / Error log)

There are a few things here that we might need to do: https://developer.android.com/about/versions/pie/android-9.0-changes-28

Thanks for reporting! On here is just as good as on GitHub, possibly even better.

On Sat, 4 Apr 2020, 15:15 Andy Zaidi, <andy...@gmail.com> wrote:

That makes sense to me; I apologise if I should have posted this as an issue on github

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/diplicity-dev/ced013a0-9e0c-4ebd-a9e8-52a50fcaea3b%40googlegroups.com.

[Martin Bruse]

I think I found it, nowadays you need to register notification channels to show notifications. I'm working on it...

To view this discussion on the web visit https://groups.google.com/d/msgid/diplicity-dev/CAOXZdj_K7bokUkxDGprcwG4RY2rYN6u7XWOZO33mRnhCxc66ug%40mail.gmail.com.

[Andy Zaidi]

Nothing in the error log that I could see; I did a couple experiments

[Martin Bruse]

I added the debug feature and used it to fix the problem. Woohoo!

Rolled out to prod, new version should be available soonish.

On Sat, Apr 4, 2020, 18:10 Andy Zaidi <andy...@gmail.com> wrote:

Nothing in the error log that I could see; I did a couple experiments

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/diplicity-dev/631d39ee-4624-420e-9f1c-282a56e0f255%40googlegroups.com.

[Andy Zaidi]

Just tried the new build, warnings work great. Thanks for the quick response!

[Martin Bruse]

No problem, thanks for reporting the bug and verifying the fix!

On Sun, Apr 5, 2020, 02:14 Andy Zaidi <andy...@gmail.com> wrote:

Just tried the new build, warnings work great.  Thanks for the quick response!

--
You received this message because you are subscribed to the Google Groups "diplicity-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to diplicity-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/diplicity-dev/9cc3a1ff-d9ab-425e-8199-784ff58c077d%40googlegroups.com.