[Deluge] #3530: Trackers are not added through magnets.

Deluge

unread,

Jul 1, 2022, 2:39:00 PM7/1/22

to delug...@googlegroups.com

#3530: Trackers are not added through magnets.
----------------------------+-------------------
Reporter: mhertz | Type: bug
Status: new | Priority: minor
Milestone: needs verified | Component: Core
Version: develop | Keywords:
----------------------------+-------------------
As title, optional trackers defined in magnet URI's with '&tr=' args,
isn't applied e.g. in GTK-UI when pressing 'add' without metadata-
prefetching finished yet / filelist empty. If in GTK-UI waiting until
prefetching finished / file(s) listed, then does work however. Same issue
when adding magnets with optional trackers through 'deluge-console add'
command.

It's irrelevant which libtorrent version used, but happens in deluge 2.1.0
but not 2.0.5 and down. I narrowed it further down specifically to commit
2bd095e being the culprit: https://github.com/deluge-
torrent/deluge/commit/2bd095e5bfc49cbe178fc0ba9df38b88afc238aa

Issue originally found and reported by nemonein in following forum-thread:
https://forum.deluge-torrent.org/viewtopic.php?f=7&p=235005#p235005

Thanks alot in advance!

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3530>
Deluge <https://deluge-torrent.org/>
Deluge Project

Deluge

unread,

Jul 1, 2022, 9:08:01 PM7/1/22

to delug...@googlegroups.com

#3530: Trackers are not added through magnets.

---------------------+----------------------------
Reporter: mhertz | Owner:

Type: bug | Status: new
Priority: minor | Milestone: needs verified
Component: Core | Version: develop

Resolution: | Keywords:
---------------------+----------------------------

Comment (by mhertz):

Just wanted to add that I found the culprit from commit 2bd095e being this
removed line from torrentmanager.py:
{{{
@@ -436,14 +438,10 @@ def _build_torrent_params(
elif magnet:
magnet_info = get_magnet_info(magnet)
if magnet_info:
- add_torrent_params['url'] = magnet.strip().encode('utf8')
add_torrent_params['name'] = magnet_info['name']
torrent_id = magnet_info['info_hash']

}}}
Adding back said line into new line 438 of torrentmanager.py in current
develop fixes issue.

--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3530#comment:1>

Deluge

unread,

Jul 8, 2022, 3:47:48 AM7/8/22

to delug...@googlegroups.com

#3530: Trackers are not added through magnets.

* status: new => closed
* version: develop => 2.1.0
* resolution: => Fixed
* milestone: needs verified => 2.1.1

Comment:

Thanks for investigating, it does look like while removing deprecated url
param the trackers were overlooked since lt would normally extract them
from url.