[Deluge] #3303: Notification-plugin mailing-bug.
Deluge
----------------------------+--------------------
Reporter: mhertz | Type: bug
Status: new | Priority: minor
Milestone: needs verified | Component: Plugin
Version: 2.0.0 | Keywords:
----------------------------+--------------------
The notification plugin fails sending mail when downloads finish, when
having set everything properly up for such. I tested it with gmail and on
the forum another user tested it with yahoo and gmail with same result. We
both have the same log elements. Thanks in advance. -Martin.
{{{
21:42:41 [DEBUG ][deluge_notifications.common :52 ] Calling CORE
custom email providers for TorrentFinishedEvent:
('0f2a3adfe82e1c92b390cdcaaec3cdc0dd3ebfd7',) {}
21:42:41 [DEBUG ][deluge_notifications.common :56 ] Found handler
for kind email: <bound method CoreNotifications._on_torrent_finished_event
of <deluge_notifications.core.Core object at 0x7febbf7cadd0>>
21:42:41 [DEBUG ][deluge_notifications.core :177 ] Handler for
TorrentFinishedEvent called for CORE
21:42:41 [DEBUG ][deluge_notifications.common :116 ] Notification
failure using email: [Failure instance: Traceback: <class 'KeyError'>:
'name'
/usr/lib/python3.7/site-
packages/deluge/core/torrentmanager.py:1296:on_alert_torrent_finished
/usr/lib/python3.7/site-packages/deluge/core/eventmanager.py:37:emit
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:70:wrapper
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:58:_handle_custom_providers
--- <exception caught here> ---
/usr/lib/python3.7/site-
packages/twisted/internet/defer.py:151:maybeDeferred
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/core.py:181:_on_torrent_finished_event
]
21:42:41 [CRITICAL][twisted :154 ] Unhandled
error in Deferred:
21:42:41 [CRITICAL][twisted :154 ] Unhandled
error in Deferred:
21:42:41 [CRITICAL][deluge.log :93 ]
twisted.internet.defer
[Failure instance: Traceback: <class 'KeyError'>: 'name'
/usr/lib/python3.7/site-
packages/deluge/core/torrentmanager.py:1296:on_alert_torrent_finished
/usr/lib/python3.7/site-packages/deluge/core/eventmanager.py:37:emit
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:70:wrapper
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:58:_handle_custom_providers
--- <exception caught here> ---
/usr/lib/python3.7/site-
packages/twisted/internet/defer.py:151:maybeDeferred
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/core.py:181:_on_torrent_finished_event
]
21:42:41 [CRITICAL][deluge.log :93 ]
twisted.internet.defer
[Failure instance: Traceback: <class 'KeyError'>: 'name'
/usr/lib/python3.7/site-
packages/deluge/core/torrentmanager.py:1296:on_alert_torrent_finished
/usr/lib/python3.7/site-packages/deluge/core/eventmanager.py:37:emit
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:70:wrapper
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/common.py:58:_handle_custom_providers
--- <exception caught here> ---
/usr/lib/python3.7/site-
packages/twisted/internet/defer.py:151:maybeDeferred
/usr/lib/python3.7/site-
packages/deluge/plugins/Notifications-0.3-py3.7.egg/deluge_notifications/core.py:181:_on_torrent_finished_event
]
21:42:41 [DEBUG ][deluge_notifications.common :52 ] Calling CORE
custom blink providers for TorrentFinishedEvent:
('0f2a3adfe82e1c92b390cdcaaec3cdc0dd3ebfd7',) {}
21:42:41 [DEBUG ][deluge_notifications.common :52 ] Calling CORE
custom sound providers for TorrentFinishedEvent:
('0f2a3adfe82e1c92b390cdcaaec3cdc0dd3ebfd7',) {}
21:42:41 [DEBUG ][deluge_notifications.common :52 ] Calling CORE
custom popup providers for TorrentFinishedEvent:
('0f2a3adfe82e1c92b390cdcaaec3cdc0dd3ebfd7',) {}
}}}
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303>
Deluge <https://deluge-torrent.org/>
Deluge Project
Deluge
---------------------+----------------------------
Reporter: mhertz | Owner:
Type: bug | Status: new
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.0
---------------------+----------------------------
Changes (by arcticslush):
* cc: mail@… (added)
Comment:
I've run into the same problem. For reference, here are my version
numbers:
{{{
deluged 2.0.3
libtorrent: 1.1.12.0
Python: 3.7.3
OS: Linux Arch Linux
}}}
I believe I've managed to isolate where the bug is coming from and will be
working on a patch to address it. Will update with my findings once I know
more.
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:1>
Deluge
---------------------+----------------------------
Reporter: mhertz | Owner:
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.0
---------------------+----------------------------
Comment (by kevindd992002):
Any updates to this?
@arcticslush, have you got any progress?
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:2>
Deluge
---------------------+----------------------------
Reporter: mhertz | Owner:
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.0
---------------------+----------------------------
Comment (by dakkar):
My Python is very rusty, but my best guess is:
[[https://git.deluge-
torrent.org/deluge/tree/deluge/plugins/Notifications/deluge_notifications/core.py#n179|CoreNotifications._on_torrent_finished_event]]
calls `torrent.get_status({})` but the `Torrent.get_status` method expects
a //list// of field names to return, not a dictionary. Therefore, the
dictionary `torrent_status` is empty, and causes that `KeyError`.
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:3>
Deluge
---------------------+----------------------------
Reporter: mhertz | Owner:
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.0
---------------------+----------------------------
Comment (by kevindd992002):
I don't get it. Why is notifications not a priority? It's been more than a
year! My God.
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:4>
Deluge
---------------------+----------------------------
Reporter: mhertz | Owner:
Priority: minor | Milestone: needs verified
Component: Plugin | Version: 2.0.0
---------------------+----------------------------
Comment (by mhertz):
Thanks alot dakkar for your hints, much appreciated! I have workaround'ed
the issue, though currently doesn't report num_files anymore and only
torrent-name in sent mail. Plugin is uploaded with more info at this forum
thread by kevindd992002: https://forum.deluge-
torrent.org/viewtopic.php?f=7&t=55458
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:5>
Deluge
---------------------+-------------------
Reporter: mhertz | Owner:
Type: bug | Status: new
Priority: minor | Milestone: 2.0.4
Component: Plugin | Version: 2.0.0
Resolution: | Keywords:
---------------------+-------------------
* milestone: needs verified => 2.0.4
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:6>
Deluge
---------------------+--------------------
Reporter: mhertz | Owner:
Type: bug | Status: closed
Priority: minor | Milestone: 2.0.4
Component: Plugin | Version: 2.0.0
---------------------+--------------------
Changes (by Cas):
* status: new => closed
* resolution: => Fixed
Comment:
Deployed fix to develop: [e38f1173cf470]
--
Ticket URL: <https://dev.deluge-torrent.org/ticket/3303#comment:7>