Possible typo in step 26 tutorial

62 views
Skip to first unread message

Kyle Schwiebert

unread,
Mar 22, 2024, 9:10:08 AM3/22/24
to deal.II User Group
Hello,

I'm sorry for not just mentioning this on github. If I'm honest I wasn't sure of the procedure for such a small change. I think there is a typo in: The deal.II Library: The step-26 tutorial program (dealii.org). Regarding the first test case in "What could possibly go wrong?" it seems that the coefficient on a(t) should be +1 rather than -1 (or the initial condition should be a(0) = -1).

Regards,
Kyle

Daniel Arndt

unread,
Mar 22, 2024, 10:36:43 AM3/22/24
to dea...@googlegroups.com
Kyle,

Why don't you just submit a pull request for this fix?

Best,
Daniel

--
The deal.II project is located at http://www.dealii.org/
For mailing list/forum options, see https://groups.google.com/d/forum/dealii?hl=en
---
You received this message because you are subscribed to the Google Groups "deal.II User Group" group.
To unsubscribe from this group and stop receiving emails from it, send an email to dealii+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/dealii/ad2938d8-e04f-4695-a2e0-1668ae67b4f9n%40googlegroups.com.

Kyle Schwiebert

unread,
Mar 22, 2024, 7:56:07 PM3/22/24
to deal.II User Group
Daniel,

Thanks. I wasn't sure if that was the procedure for such a small change. Went ahead and did this.

-Kyle

Wolfgang Bangerth

unread,
Mar 22, 2024, 8:38:16 PM3/22/24
to dea...@googlegroups.com
On 3/22/24 17:56, Kyle Schwiebert wrote:
>
> Thanks. I wasn't sure if that was the procedure for such a small change. Went
> ahead and did this.

No special procedure -- we're grateful for all changes anyone would like to
contribute, however small!

Your patch at
https://github.com/dealii/dealii/pull/16778
looks correct. Someone will merge it once it's passed some basic tests!

Thanks for helping improve the documentation!
W.

--
------------------------------------------------------------------------
Wolfgang Bangerth email: bang...@colostate.edu
www: http://www.math.colostate.edu/~bangerth/


Reply all
Reply to author
Forward
0 new messages