Clarification in Step-45 of tutorial

[Raghunandan Pratoori]

Hello,

Why is VectorTools::interpolate_boundary_values used twice - once before DoFTools::make_periodicity_constraints and once after in setup_dofs?

Best,

Raghunandan.

[Wolfgang Bangerth]

On 10/7/21 8:10 PM, Raghunandan Pratoori wrote:
>
> Why is VectorTools::interpolate_boundary_values
> <https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.dealii.org%2Fcurrent%2Fdoxygen%2Fdeal.II%2FnamespaceVectorTools.html%23af27ac28c698a9ed0199faed50a204538&data=04%7C01%7CWolfgang.Bangerth%40colostate.edu%7C7ddff1f7c1c9426d581708d98a00d98f%7Cafb58802ff7a4bb1ab21367ff2ecfc8b%7C0%7C0%7C637692559418379919%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UWRTkmhaarWHXm2JZe34AUbqwqBV4kx0n7fdaju6KbU%3D&reserved=0>

> used twice - once before DoFTools::make_periodicity_constraints and once after
> in setup_dofs?

That seems like a mistake. Can you try what happens if you remove the second
set of calls and whether that changes the output of the program?

Best
Wolfgang

--
------------------------------------------------------------------------
Wolfgang Bangerth email: bang...@colostate.edu
www: http://www.math.colostate.edu/~bangerth/

[Raghunandan Pratoori]

Hello Dr. Bangertt,

I tried by removing the second occurrence of VectorTools::interpolate_boundary_values and got the same results.

Best,

[Wolfgang Bangerth]

On 10/8/21 11:57 AM, Raghunandan Pratoori wrote:
>
> I tried by removing the second occurrence

> ofVectorTools::interpolate_boundary_values and got the same results.

Great, thanks for trying this out. Would you like to submit a patch to
deal.II that fixes this? You'd become one of the authors of deal.II this
way :-)

Best
W.

[Raghunandan Pratoori]

Sure! I would be happy to that! I will submit a pull request. I am currently working on v9.3.0. Will submitting a pull request on that work or should it be based on the master branch?

Best,

[Wolfgang Bangerth]

On 10/8/21 2:21 PM, Raghunandan Pratoori wrote:
> Sure! I would be happy to that! I will submit a pull request. I am currently
> working on v9.3.0. Will submitting a pull request on that work or should it be
> based on the master branch?
>

If you can, base it on master. That's where changes should go that should be
in future releases.

[Raghunandan Pratoori]

Sure. I can do that.