Negative and Positive blocks formatting

[ahmad.ta...@gmail.com]

Is anyone having an issue with the negative and positive blocks formatting? Using the latest claat version they no longer show on the final rendered view. 

Thanks!

[Ria Galanos]

I also lost the formatting for these blocks.  I use them everywhere so I hope this can be fixed soon.

[Marc Cohen]

If someone can share a (non-proprietary) markdown example, I can try to reproduce and debug.

--
You received this message because you are subscribed to the Google Groups "codelab-authors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codelab-autho...@googlegroups.com.
To view this discussion on the web, visit https://groups.google.com/d/msgid/codelab-authors/6872f13a-356c-443f-9088-badee1e9d340n%40googlegroups.com.

[Paul Eldridge]

I never did get those to work correctly -- a friend suggested I just use asides instead in the markdown and it works. Like this:

<aside class="positive">
Note: Your snappy text would go here.
</aside>

<aside class="negative">
Note: Your snappy text would go here.
</aside>

Then when you run claat export on the markdown file, it catches those asides and correctly renders the blocks.

[Tamimi Ahmad]

yeaah the <aside class="positive"> works... I'll have to fix it in all our codelabs now unfortunately :/ and if we use this html notation then links in negative and positive blocks should now be changed to <a href="url">content</a>

[Tony Beaumont]

Yes, the negative and positive blocks no longer work with the current version of claat.

There is a workaround enclosing Positive or Negative sections in <aside class="positive"> or <aside class="negative"> elements, but all the internal markup also needs to be written in HTML.
The issue is reported on GitHub (https://github.com/googlecodelabs/tools/issues/627) but I'm not sure anyone is working on a fix.

On Sat, Nov 5, 2022 at 3:35 PM ahmad.ta...@gmail.com <ahmad.ta...@gmail.com> wrote:

Is anyone having an issue with the negative and positive blocks formatting? Using the latest claat version they no longer show on the final rendered view. 

Thanks!

--

You received this message because you are subscribed to the Google Groups "codelab-authors" group.
To unsubscribe from this group and stop receiving emails from it, send an email to codelab-autho...@googlegroups.com.

To view this discussion on the web, visit https://groups.google.com/d/msgid/codelab-authors/89412041-0f9b-4da1-bd48-284febcdf069n%40googlegroups.com.

[Ria Galanos]

Thanks for the info about the <aside> tags.  They work nicely - though it's a bit annoying that I now have to change 100+ files.  The pretty green checkmarks are also not rendering in my "You will learn" section.  I will go and search for a fix to this but if someone happens to know offhand, please let me know.

Ria

[Ria Galanos]

In my comment above, I meant to say in my "What you'll learn" section.  Regardless, I have had no luck finding out why the green checks stopped rendering.  The bullets aren't even rendering.  

Thanks!

Ria

[Tamimi Ahmad]

I did some further investigation in this and went back to older versions of claat (when Positive: and Negative: were working) and confirmed that the issue is still there. I suspect that this broke when the css files hosting changed to storage.googleapis.com/claat-public/*.css. I cant find the old version of the css files that were hosted on storage.googleapis.com/codelab-elements/*.css to do a diff and investigate what changed. Can we look into the changes in these files to see what might be the issue?

The markdown to html parser is not converting Positive: and Negative: to <aside class="special"><p> text </p></aside> and <aside class="warning"><p> text </p></aside> respectively, instead its rendering it directly to <p> Negative: text </p>

[Marc Cohen]

Ok, that took only, what, a year and a half to debug? Sorry about the delay, I work on claat as a (very) part time thing.

So it appears this was broken not by the css change, but rather by this PR way back in 2020, which changed the markdown format for specifying infoboxes. Unfortunately, it didn't preserve backward compatibility and no one seems to have caught that at the time.  One interesting thing to note is this change introduced a different markdown syntax for specifying infoboxes:

> aside positive

>

>  Note: Your snappy text would go here.

> aside negative

>

>  Note: Your snappy text would go here.

So, point number one is you can use the above native markdown syntax (I verified it works for me) if you prefer that for specifying infoboxes over embedded html aside elements (which people realized upstream is another workaround).

Point number two is I'm sorry we broke this, didn't make it more clear what was changing. and took so long to figure out what happened.

Marc

To view this discussion on the web, visit https://groups.google.com/d/msgid/codelab-authors/9a58e8a4-20e9-4f69-a941-22600b78f608n%40googlegroups.com.

--

Marc Cohen (he/him)

Web: mco.dev

Email: ma...@mco.dev

Q: Why is this email three sentences or less?

A: three.sentenc.es

[Tamimi Ahmad]

Hmm thanks for the update on this Marc. Can we please update the documentation here as well to reflect this https://github.com/googlecodelabs/tools/blob/main/claat/parser/md/README.md?

I am not sure where there are references as well so this, I will check to see if we need to update it somewhere else. 

I confirmed on my end and it works 👍

--

Best Regards,

Tamimi, Ahmad

[Marc Cohen]

Thanks Tamini, PR submitted. Should be merged shortly.

To view this discussion on the web, visit https://groups.google.com/d/msgid/codelab-authors/CAMAqEE%3DyMBUjh0TiGF2vJt__yVE8iNd0nST_0mJL0GmGuWxPtA%40mail.gmail.com.