Build issue after update to 23.master.0.308477

[Jake]

I am merging in changes from the latest commit to master and am encountering this build issue:

Traceback (most recent call last):
  File "C:\work\cobalt\dev\starboard\tools\app_launcher_packager.py", line 30, in <module>
    from starboard.tools import command_line
ModuleNotFoundError: No module named 'starboard'
ERROR at //starboard/tools/BUILD.gn:18:15: Script returned non-zero exit code.
  file_list = exec_script(script, [ "-l" ], "trim string")
              ^----------

I don't recall this being an issue before. Can someone give provide some info on this? What exactly is being packaged, and why do I need it?

Thanks,

-Jake 

[Kaido Kert]

The issue itself seems to be a Python module path problem. Current trunk and Cobalt 23 code requires Python import path to include the Cobalt code checkout directory.

On linux hosts to solve this, 
export PYTHONPATH=${PWD}

On Windows hosts, please use equivalent cmd or powershell stanza to set the env var.

app_launcher_packager is a build tool that generates zip archives that are specific to Cobalt CI and test infrastructure.
It's not strictly necessary for the binary build itself, but does currently get invoked at GN execution time by default.

Kaido

You received this message because you are subscribed to the Google Groups "cobalt-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cobalt-dev+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/cobalt-dev/97c5257f-4a5c-4aa9-a25e-4f0c0475b406n%40googlegroups.com.

[Jake]

So $PWD in this case is the repo root?

Also, can you point to a spot in a .gn file where I could comment out the app launcher specific stuff? 

[Kaido Kert]

Correct, PWD refers to the repo root here.

The applauncher is included here : https://github.com/youtube/cobalt/blob/master/starboard/BUILD.gn#L72
However removing that line alone will not fully remove the need for Python modules to be in path, other build scripts will still need it.

To view this discussion on the web visit https://groups.google.com/d/msgid/cobalt-dev/44bb910a-813b-4bf0-a422-78c5b5173339n%40googlegroups.com.

[Jake]

Kaido,

Thanks for your help! That got me past the python issue. I understand that python is still required, which isn't an issue.

-Jake