GSOC 2025 - Improve modules in google-style implementation

[Mohit Attry]

Thursday, June 05 report

1. I finished reviewing latest version of the Google-style guide and opened three issues on rules which are currently not being covered. I tagged mentors wherever I had doubts and waiting for their reponses.
2. Created "Under-review" section in the project dashboard for keeping track of issues which are currently being discussed, tested or waiting for response from the mentors.
3. Working on 8965

Blockers:
the most confusing part for me in the triage process is to determine how to deal with issues which are caused by design issues in Check and a consensus has not been reached. For example: there are lot of issues raised on RightCurlyCheck in the tracker, but plan to make a new RightCurlyCheck has also been proposed, so is it worth to spend time on resolving issues on old Check and flawed Check ?

Sorry for delay in the report.

[Mohit Attry]

Monday, June 09 report
1. Raised a on google-java formatter tool for incorrect behaviour on text-blocks
2. Raised Pr adding inputs for section "4.5.1 where to break" for record-class
3. Continued working on Issue , on following the suggestions by mentors.

This week:

Next week, I'll prioritise more on fixing issues from GSOC 25 file, adding supplemental input files and continue triaging issues from the tracker.

[Mohit Sharma]

Thursday, June 12 report

What I did:
1. Raised a Pr enforcing whitespace after the double slashes of the comments. I tried RegexpMultiline initially, but now MatchXPath seems a more viable option.
2. There are two Java-text-blocks issues I'm working on: , and #11867

    First issue is about demanding opening and closing quotes of text-block on new lines. I tried resolving it using regex and some suppressions, but we figured that creating a new check.

 

Next steps:

1. One major regarding placement of the arrow in lambda and case is left to be made issue into. I'll ask for clarification on this from mentors.
2. Issue #11867 issue is about LineLengh Check giving violations on text-blocks, I'll use SuppressWithNearbyTextFilter suppression to find a workaround.

3. Follow-up on existing PRs.

--
You received this message because you are subscribed to the Google Groups "checkstyle-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to checkstyle-dev...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/checkstyle-devel/401de803-9af6-4268-b922-a1f1a63a0851n%40googlegroups.com.

[Mohit Sharma]

Monday, June 16 Report

What I did:
1. Implemented the fix for using MatchXPath Check.
2. Investigated issue and sent 'supplemental' Pr.

This Week:

1. I will finish the remaining work on the indentation-on-annotation-arrays issue  and try to get it merged. It is a high priority issue for users.

2. I will send the first version of the new check TextBlockFormattingCheck. but first I need to get the design of it reviewed from mentors.

3. Continue to work on existing issues.

[Mohit Sharma]

Thursday, June 19 Report

What I did:
1. Worked on #17181 and #17206. These are almost ready to be merged.
2. Raised supplemental pr: adding inputs for 4.6.2 single whitespace arrow.
3. Currently working on #17158.

Plan for the remaining week:
Get new-check  approved from mentors and start working on it.

[Mohit Sharma]

Monday, June 23 Report

What I did last week:
1. Raised pr fixing invalid javadoc position for compact constructor.

2. Raised pr adding IT for space between '//' and 'non-compiled' comments

3. Raised pr adding IT for 4.5.1 where-to-break for lambda arrow

3. Sent changes and fixed CIs on my other opened PRs

This week:
Backlog from last week: new check TextBlockGoogleStyleFormattingCheck could not get approved. I need to present the design to the mentors and get their feedback.

[Mohit Sharma]

Tuesday, June 26 report

1. Designed TextBlockGoogleStyleFormattingCheck(we will change the name).

2. IT for above check.

Merged PRs since last report:

1. https://github.com/checkstyle/checkstyle/pull/17264

2. https://github.com/checkstyle/checkstyle/pull/17236

3. https://github.com/checkstyle/checkstyle/pull/17181

4. https://github.com/checkstyle/checkstyle/pull/17135

Plan for the remaining week:

Keep working on the new check and try to send the first working version in the next few days.

[Mohit Sharma]

Monday, June 30 report

We found that google-formatter CI runs only on compilable inputs. This causes problems because non-compilable inputs easily escape the formatter validation. It's been addressed here. It is a high priority issue because my two PRs are blocked because of it.

Plan for the week:

1. Discuss with mentors: https://github.com/checkstyle/checkstyle/issues/17253

2. Keep working on https://github.com/issues/created?issue=checkstyle%7Ccheckstyle%7C17223

[Mohit Sharma]

Thursday, July 3 report

What I did:

1. We found that resources-noncompilable inputs in src/it/ are not getting compiled against the latest JDKs. Today I Sent the Fix adding these files to the validation.sh. Removing compilation errors from the inputs took most of the time.

2. Send fix for: no whitespace before ellipsis.

Plan for the remaining week:

1. TextBlockGoogleStyleFormattingCheck is finally approved and I've started working on it.