Issue #193: beancount.prices.sources.google.Source.get_historical_price() is no longer working as expected (blais/beancount)

29 views
Skip to first unread message

Zhuoyun Wei

unread,
Sep 15, 2017, 10:43:25 AM9/15/17
to bean...@googlegroups.com
New issue 193: beancount.prices.sources.google.Source.get_historical_price() is no longer working as expected
https://bitbucket.org/blais/beancount/issues/193/beancountpricessourcesgooglesourceget_hist

Zhuoyun Wei:

Hi,

I found a bug where `bean-price` always returns today's price no matter what date I provided. I root the cause here: https://bitbucket.org/blais/beancount/src/621cec5ed38bcd128a3502a3b5c367f283deffe2/beancount/prices/sources/google.py?at=default&fileviewer=file-view-default#google.py-181:184

The Google Finance API now (since when? I have no idea) always returns a full year's data (from ~365 days ago to today), ignoring `startdate` and `enddate` parameters. So fetching the most recent record (line 1) is always to get today's price.

Responsible: blais
Reply all
Reply to author
Forward
0 new messages