sysctl.conf

172 views
Skip to first unread message

Mzp45

unread,
Dec 9, 2014, 10:41:27 AM12/9/14
to ansible...@googlegroups.com
Hello,
Is there a way to create a backup of /etc/sysctl.conf when making a change using the sysctl core module? If not can this feature be added?

Thanks

Toshio Kuratomi

unread,
Dec 9, 2014, 7:08:46 PM12/9/14
to ansible...@googlegroups.com
In general, ansible modules do not perform backups of files that they
modify. I'm not sure that sysctl is especially special in this
regard. Is there a reason you need this for sysctl but not for copy,
or any of the other modules?

-Toshio
> --
> You received this message because you are subscribed to the Google Groups
> "Ansible Project" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to ansible-proje...@googlegroups.com.
> To post to this group, send email to ansible...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/ansible-project/dacf22c0-e242-4cf8-9618-6e9678485f61%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Mzp45

unread,
Dec 10, 2014, 11:20:43 AM12/10/14
to ansible...@googlegroups.com
I was thinking an implementation along the lines of the "lineinfile" module where you can edit a file and create a backup at the same time. For the sysctl module if you have to edit a sysctl.conf file then a backup seems like a good failsafe. 

Toshio Kuratomi

unread,
Dec 10, 2014, 1:17:42 PM12/10/14
to ansible...@googlegroups.com
Yeah, I just noticed that backup actually does exist on a lot of the
file-like modules. I just hadn't noticed them before. So yeah,
adding a backup parameter that does the same thing for sysctl seems
like a good idea. Could you open a pull request if you can code it or
an issue if you can't so that hte idea doesn't get lost?

Thanks,
-Toshio
> https://groups.google.com/d/msgid/ansible-project/d08acda3-d1d5-465e-bb0f-60d301dfca5a%40googlegroups.com.

Mzp45

unread,
Dec 12, 2014, 12:51:43 PM12/12/14
to ansible...@googlegroups.com
Sure, I'll work on the pull request. 

Michael DeHaan

unread,
Dec 15, 2014, 6:51:20 AM12/15/14
to ansible...@googlegroups.com
Let's not add a new backup parameter.

The existing backup=yes/no parameter that only creates local backups needs to be overhauled to do remotes, and we can generalize it at this time.



Mzp45

unread,
Dec 15, 2014, 1:35:38 PM12/15/14
to ansible...@googlegroups.com
In which release would the overall be completed? 

Thanks

Michael DeHaan

unread,
Dec 15, 2014, 1:42:25 PM12/15/14
to ansible...@googlegroups.com
Honestly, no idea.

We need to get the v2 refactoring out in 1.9 (worst case 2.0) first, and then we'll be in a good position to make a generalized backup mechanism.

Until then, something like a "fetch" module call to manually do it would be a good solution.



Mzp45

unread,
Dec 16, 2014, 1:41:22 PM12/16/14
to ansible...@googlegroups.com
I dont know if fetch itself will work for me. All i want to do is create a backup of a file on the client before i edit it using sysctl. 
I guess i could try a fetch first and then a copy back to the destination. 

For the overall are you going to add a backup option every time a file gets modified (file modules, sysctl moudles, etc.) ?

Thanks 
Reply all
Reply to author
Forward
0 new messages