Trailing white space policy

[Berend de Boer]

Hello All,

Would it be a good idea to have a policy that files cannot have trailing white space? The problem is that some editors are set up to remove this automatically, and when changing a file introduce a patch with trailing white space removed.

If files do not have trailing white space (and there is no good reason to have them, then simply using an editor that doesn't remove them automatically), then this would never be a problem.

That would make contributing to ansible easier: you will never have to tell a person to keep white space. Trailing white space can also be removed automatically upon commit perhaps, so it can never be introduced inadvertedly, or else such a commit can be rejected.

What does ansible think?

All the best,

Berend.

[Michael DeHaan]

Ansible doesn't care about trailing whitespace, and enjoys annoying those that have a problem with it.

We do not accept patches to fix because that breaks line attribution.

--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/baa04a08-f2c5-4241-bd3d-2fe72e13e52d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Brian Coca]

turn it off on your editor, but if you contribute any changes remove the trailing whitespace from those lines, eventually most of it will be removed.
​

[Berend de Boer]

if you contribute any changes remove the trailing whitespace from those lines, eventually most of it will be removed.

If there is no policy from now on not to accept trailing white spaces, it will continually be introduced again.

[Michael DeHaan]

I think you miss the point where we don't care about removing trailing whitespace.

So many millions of things that are a better use of our time, in the face of some absolutely awesome contributions and things to work on.

On Mon, Jul 28, 2014 at 5:07 PM, Berend de Boer <berend...@gmail.com> wrote:

if you contribute any changes remove the trailing whitespace from those lines, eventually most of it will be removed.

If there is no policy from now on not to accept trailing white spaces, it will continually be introduced again.

--

You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/86ab1f13-3c64-4c8b-bbf0-b5bc419ccd12%40googlegroups.com.

[Berend de Boer]

On Tuesday, 29 July 2014 09:10:35 UTC+12, Michael DeHaan wrote:

I think you miss the point where we don't care about removing trailing whitespace.

I got that loud and clear, and respect that. I simply responded to Brian who thought the trailing white space would disappear with edits over time.

All the best,

Berend.

[Brian Coca]

Just cause they bug me and find excuses to send PRs for code all over ansible 😡

Brian Coca

[Michael DeHaan]

You have discovered my evil scheme to convince you to patch all the things!

On Mon, Jul 28, 2014 at 6:26 PM, Brian Coca <bria...@gmail.com> wrote:

Just cause they bug me and find excuses to send PRs for code all over ansible 😡

Brian Coca

--

You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To post to this group, send email to ansible...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/CADn%2BHswboS1Mnz%2B978_03b4JDO5pwmGgXaeNRB9qSNiSbb8_Vw%40mail.gmail.com.

[Brian Coca]

I KNEW IT!​