Ansible lininfile behavior
125 views
Skip to first unread message
Justin Nelson
May 4, 2020, 2:55:19 PM5/4/20
to Ansible Project
I have a simple playbook that I'm testing with in an attempt to update a file that has some test strings mapped to mac addresses. When I run my playbook I can only seem to get one of my two hosts to write the test string into the playbook and not both. If I run it a second time, I can get the second host in there.
The plybook looks similar to the following:
---
- name: Update File
hosts:
- test_group
connection: local
gather_facts: no
vars:
user_home: "{{ lookup('env', 'HOME') }}"
config_file: "{{ inventory_hostname }}.conf"
tasks:
- name: Load device vars from config file
include_vars: "{{ user_home }}/{{ config_file }}"
- name: Update test file
lineinfile:
path: /var/tmp/test.yaml
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"The config file has multiple variables for each host in it including the 'test_string' and 'mac'.
My test_group has two hosts:
[test_group]
host1
host2And each host has a config file in my home directory 'host[12].conf' with the following:
host1.conf
test_string: abc
mac: 01:23:45:67:89:ab
test_string: abc
mac: 01:23:45:67:89:ab
host2.conf
test_string: xyz
mac: ab:09:87:65:43:21
test_string: xyz
mac: ab:09:87:65:43:21
When run, I expect to have both hosts with an entry in /var/tmp/test.yaml similar to:
mac_list:
test-abc: 01:23:45:67:89:ab
test-xyz: ab:09:87:65:43:21
But I can only get one host to update at a time although the task, when run in debug mode, showing that both hosts were changed. I have to run it a second time to get lineinfile to write the second host
What am I missing to make this work for both hosts?
Vladimir Botka
May 4, 2020, 4:03:15 PM5/4/20
to Justin Nelson, ansible...@googlegroups.com
On Mon, 4 May 2020 11:55:19 -0700 (PDT)
Justin Nelson <omeg...@gmail.com> wrote:
> ... When I run my playbook I can only seem to get one of my two hosts ...
>
> [test_group]
> host1
> host2
>
> [...]
https://docs.ansible.com/ansible/latest/plugins/connection/local.html#local-execute-on-controller
"... allows ansible to execute tasks on the Ansible ‘controller’ instead of
on a remote host."
HTH,
-vlado
Justin Nelson <omeg...@gmail.com> wrote:
> ... When I run my playbook I can only seem to get one of my two hosts ...
>
> - name: Update File
> hosts:
> - test_group
> connection: local
>
> [...]
> - name: Update File
> hosts:
> - test_group
> connection: local
>
>
> [test_group]
> host1
> host2
>
> [...]
>
> What am I missing to make this work for both hosts?
Remove "connection: local". See "local – execute on controller"
> What am I missing to make this work for both hosts?
https://docs.ansible.com/ansible/latest/plugins/connection/local.html#local-execute-on-controller
"... allows ansible to execute tasks on the Ansible ‘controller’ instead of
on a remote host."
HTH,
-vlado
Vladimir Botka
May 4, 2020, 4:17:57 PM5/4/20
to Justin Nelson, ansible...@googlegroups.com
> - name: Update File
> hosts: test_group
> ...
> tasks:
> ...
own instance. I can only assume the file should be on the controller, e.g.
- name: Update test file
lineinfile:
path: /var/tmp/test.yaml
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
delegate_to: localhost
HTH,
-vlado
> hosts: test_group
> ...
> tasks:
> ...
> - name: Update test file
> lineinfile:
> path: /var/tmp/test.yaml
> regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
> line: " test-{{ test_string|lower }}: {{ mac }}"
>
> lineinfile:
> path: /var/tmp/test.yaml
> regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
> line: " test-{{ test_string|lower }}: {{ mac }}"
>
> My test_group has two hosts:
>
> [test_group]
> host1
> host2
>
> ...
>
> [test_group]
> host1
> host2
>
>
> When run, I expect to have both hosts with an entry in /var/tmp/test.yaml
> similar to:
>
> mac_list:
> test-abc: 01:23:45:67:89:ab
> test-xyz: ab:09:87:65:43:21
The file '/var/tmp/test.yaml' is on the remote host. Each host updates its
> When run, I expect to have both hosts with an entry in /var/tmp/test.yaml
> similar to:
>
> mac_list:
> test-abc: 01:23:45:67:89:ab
> test-xyz: ab:09:87:65:43:21
own instance. I can only assume the file should be on the controller, e.g.
- name: Update test file
lineinfile:
path: /var/tmp/test.yaml
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
HTH,
-vlado
Justin Nelson
May 4, 2020, 4:20:05 PM5/4/20
to Ansible Project
My apologies for not being a little more clear, Vlado.
I
do want this to execute on the local host and not on the remote hosts.
Ultimately this will be setting up a file that will be used later for
building a remote host's config file using the template module. It's all a part
of an attempt at a somewhat zero touch provisioning model for switches
we deploy.
Essentially the work flow would look similar to:
a
new device needs to be added => user builds initial config file
specific to device location and requirements => user runs playbook
The playbook would then locally:
load the device variables from the config file
take user's config file and make a backup to the host_vars directory for later use, if necessary
take a short hostname (test_string) and MAC address and append them to the file
Later in the playbook other plays will have tasks that load the variables in these files generate a config from a template that gets copied to the remote host. This one file and its contents is, sort of, a living file that gets updated every time we add or replace a device.
Hope that makes sense.
Justin Nelson
May 4, 2020, 4:26:42 PM5/4/20
to Ansible Project
So I added the delegate_to: localhost but I still only get one added on the first pass:
And when I run it a second time:
With the file contents now the following:
PLAY [Test Playbook] ************************************************************************************************************************************
TASK [Load device vars from config] *********************************************************************************************************************
ok: [host1]
ok: [host2]
TASK [Update tmp file] **********************************************************************************************************************************
changed: [host1 -> localhost]
changed: [host2 -> localhost]
PLAY RECAP **********************************************************************************************************************************************
host1 : ok=2 changed=1 unreachable=0 failed=0
host2 : ok=2 changed=1 unreachable=0 failed=0
The file contents after that pass are:
1 macs:
2 test-host222: ab:09:87:65:43:21And when I run it a second time:
PLAY [Test Playbook] ************************************************************************************************************************************
TASK [Load device vars from config] *********************************************************************************************************************
ok: [host1]
ok: [host2]
TASK [Update tmp file] **********************************************************************************************************************************
changed: [host1 -> localhost]
ok: [host2 -> localhost]
PLAY RECAP **********************************************************************************************************************************************
host1 : ok=2 changed=1 unreachable=0 failed=0
host2 : ok=2 changed=0 unreachable=0 failed=0 With the file contents now the following:
1 macs:
2 test-host222: ab:09:87:65:43:21
3 test-host111: 12:34:56:78:90:abVladimir Botka
May 4, 2020, 4:26:50 PM5/4/20
to Justin Nelson, ansible...@googlegroups.com
> - name: Update File
> hosts: test_group
> ...
> tasks:
> ...
try this
- name: Update test file
lineinfile:
path: /var/tmp/test.yaml
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
loop: "{{ ansible_play_hosts }}"
vars:
mac: "{{ hostvars[item]['mac'] }}"
test_string: "{{ hostvars[item]['test_string'] }}"
HTH,
-vlado
> hosts: test_group
> ...
> tasks:
> ...
> - name: Update test file
> lineinfile:
> path: /var/tmp/test.yaml
> regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
> line: " test-{{ test_string|lower }}: {{ mac }}"
>
> lineinfile:
> path: /var/tmp/test.yaml
> regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
> line: " test-{{ test_string|lower }}: {{ mac }}"
>
> My test_group has two hosts:
>
> [test_group]
> host1
> host2
>
> ...
>
> [test_group]
> host1
> host2
>
>
> When run, I expect to have both hosts with an entry in /var/tmp/test.yaml
> similar to:
>
> mac_list:
> test-abc: 01:23:45:67:89:ab
> test-xyz: ab:09:87:65:43:21
If the file '/var/tmp/test.yaml' shall be created on both 'host1' and 'host2'
> When run, I expect to have both hosts with an entry in /var/tmp/test.yaml
> similar to:
>
> mac_list:
> test-abc: 01:23:45:67:89:ab
> test-xyz: ab:09:87:65:43:21
try this
- name: Update test file
lineinfile:
path: /var/tmp/test.yaml
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
vars:
mac: "{{ hostvars[item]['mac'] }}"
test_string: "{{ hostvars[item]['test_string'] }}"
HTH,
-vlado
Kai Stian Olstad
May 4, 2020, 4:33:06 PM5/4/20
to ansible...@googlegroups.com
file at the same time, and only one of them will win.
Add "throttle: 1" to you lineinfile task and it will work.
--
Kai Stian Olstad
Vladimir Botka
May 4, 2020, 4:49:56 PM5/4/20
to Kai Stian Olstad, ansible...@googlegroups.com
On Mon, 4 May 2020 22:31:49 +0200
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> > [test_group]
> > host1
> > host2
>
> Since you have two host you will have two tasks that tries to write to the same
> file at the same time, and only one of them will win.
>
> Add "throttle: 1" to you lineinfile task and it will work.
I don't need "throttle" with 2.9.6. The playbook
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> > [test_group]
> > host1
> > host2
>
> Since you have two host you will have two tasks that tries to write to the same
> file at the same time, and only one of them will win.
>
> Add "throttle: 1" to you lineinfile task and it will work.
shell> cat pb.yml
- hosts:
- test_01
- test_02
gather_facts: false
tasks:
- lineinfile:
path: test-file
line: "{{ inventory_hostname }}"
delegate_to: localhost
gives
shell> cat test-file
shell> ansible-playbook pb.yml
PLAY [test_01,test_02]
*******************************
TASK [lineinfile]
*******************************
changed: [test_01 -> localhost]
changed: [test_02 -> localhost]
PLAY RECAP
*******************************
test_01 : ok=1 changed=1 unreachable=0 failed=0
skipped=0 rescued=0 ignored=0 test_02 : ok=1
changed=1 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
shell> cat test-file
test_01
test_02
--
Justin Nelson
May 4, 2020, 5:02:13 PM5/4/20
to Ansible Project
The two hosts I have to test with are running 2.7.4 and 2.8.2. I don't have a 2.9.x host available to test the throttle command but it makes sense.
However, when I updated the playbook to the following:
---
- name: Test Playbook
hosts:
- test_group
gather_facts: no
connection: local
vars:
user_home: "{{ lookup('env', 'HOME') }}"
config_file: "{{ inventory_hostname }}.conf"
tasks:
- name: Load device vars from config
include_vars: "{{ user_home }}/{{ inventory_hostname }}.conf"
- name: Update tmp file
lineinfile:
path: "{{ playbook_dir }}/macs.yaml"
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{test_string|lower}}: {{mac}}"
create: yes
loop: "{{ ansible_play_hosts }}"
vars:
test_string: "{{ hostvars[item]['test_string'] }}"
mac: "{{ hostvars[item]['mac'] }}"It ran as follows:
PLAY [Test Playbook] ************************************************************************************************************************************
TASK [Load device vars from config] *********************************************************************************************************************
ok: [host1]
ok: [host2]
TASK [Update tmp file] **********************************************************************************************************************************
changed: [host2] => (item=host1)
changed: [host1] => (item=host1)
changed: [host1] => (item=host2)
ok: [host2] => (item=host2)
PLAY RECAP **********************************************************************************************************************************************
host1 : ok=2 changed=1 unreachable=0 failed=0
host2 : ok=2 changed=1 unreachable=0 failed=0 And wrote to the file on the controller as I would have expected it to.
shell> cat macs.yaml
macs:
test-host222: ab:09:87:65:43:21
test-host111: 12:34:56:78:90:abI'll see if I can find a host that has 2.9 on it to test with the throttle command.
Vladimir Botka
May 4, 2020, 5:04:52 PM5/4/20
to Justin Nelson, ansible...@googlegroups.com
On Mon, 4 May 2020 13:26:41 -0700 (PDT)
Justin Nelson <omeg...@gmail.com> wrote:
> The file contents after that pass are:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
>
> And when I run it a second time:
>
Justin Nelson <omeg...@gmail.com> wrote:
> The file contents after that pass are:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
>
> And when I run it a second time:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
> 3 test-host111: 12:34:56:78:90:ab
It's working for me as expected
> 2 test-host222: ab:09:87:65:43:21
> 3 test-host111: 12:34:56:78:90:ab
shell> cat test_01.conf
test_string: abc
mac: 01:23:45:67:89:ab
shell> cat test_02.conf
test_string: xyz
mac: ab:09:87:65:43:21
shell> cat pb.yml
- hosts:
- test_01
- test_02
- include_vars: "{{ inventory_hostname }}.conf"
- name: Update test file
lineinfile:
path: test-file
lineinfile:
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
delegate_to: localhost
line: " test-{{ test_string|lower }}: {{ mac }}"
delegate_to: localhost
shell> cat test-file
shell> ansible-playbook pb.yml
PLAY [test_01,test_02]
***************************
TASK [include_vars]
shell> ansible-playbook pb.yml
PLAY [test_01,test_02]
***************************
***************************
ok: [test_01] ok: [test_02]
TASK [Update test file]
***************************
changed: [test_01 -> localhost]
changed: [test_02 -> localhost]
PLAY RECAP
***********************************************************************************
changed: [test_01 -> localhost]
changed: [test_02 -> localhost]
PLAY RECAP
test_01 : ok=2 changed=1 unreachable=0 failed=0
skipped=0 rescued=0 ignored=0 test_02 : ok=2
changed=1 unreachable=0 failed=0 skipped=0 rescued=0 ignored=0
shell> cat test-file
shell> cat test-file
test-abc: 01:23:45:67:89:ab
test-xyz: ab:09:87:65:43:21
--
test-xyz: ab:09:87:65:43:21
Kai Stian Olstad
May 4, 2020, 5:09:00 PM5/4/20
to ansible...@googlegroups.com
On Mon, May 04, 2020 at 10:49:38PM +0200, Vladimir Botka wrote:
> On Mon, 4 May 2020 22:31:49 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > > [test_group]
> > > host1
> > > host2
> >
> > Since you have two host you will have two tasks that tries to write to the same
> > file at the same time, and only one of them will win.
> >
> > Add "throttle: 1" to you lineinfile task and it will work.
>
> I don't need "throttle" with 2.9.6. The playbook
>
> shell> cat pb.yml
> - hosts:
> - test_01
> - test_02
> gather_facts: false
> tasks:
> - lineinfile:
> path: test-file
> line: "{{ inventory_hostname }}"
> delegate_to: localhost
That is just pure luck, try running it 100 times and count how many times it
> On Mon, 4 May 2020 22:31:49 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > > [test_group]
> > > host1
> > > host2
> >
> > Since you have two host you will have two tasks that tries to write to the same
> > file at the same time, and only one of them will win.
> >
> > Add "throttle: 1" to you lineinfile task and it will work.
>
> I don't need "throttle" with 2.9.6. The playbook
>
> shell> cat pb.yml
> - hosts:
> - test_01
> - test_02
> gather_facts: false
> tasks:
> - lineinfile:
> path: test-file
> line: "{{ inventory_hostname }}"
> delegate_to: localhost
fails.
--
Kai Stian Olstad
Kai Stian Olstad
May 4, 2020, 5:18:20 PM5/4/20
to ansible...@googlegroups.com
So here you need to add "run_once: yes" to the lineinfile task.
--
Kai Stian Olstad
Vladimir Botka
May 4, 2020, 5:20:11 PM5/4/20
to Justin Nelson, ansible...@googlegroups.com
On Mon, 4 May 2020 13:26:41 -0700 (PDT)
Justin Nelson <omeg...@gmail.com> wrote:
> The file contents after that pass are:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
>
Justin Nelson <omeg...@gmail.com> wrote:
> The file contents after that pass are:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
>
> With the file contents now the following:
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
> 3 test-host111: 12:34:56:78:90:ab
Bingo! I'm able to reproduce the problem with Ansible running on controller
>
> 1 macs:
> 2 test-host222: ab:09:87:65:43:21
> 3 test-host111: 12:34:56:78:90:ab
with Python 2.7
shell> ansible --version
ansible 2.9.6
config file = /export/scratch/tmp/ansible.cfg
configured module search path = [u'/home/vlado/.ansible/plugins/modules',
u'/usr/share/ansible/plugins/modules'] ansible python module location =
/usr/lib/python2.7/dist-packages/ansible executable location =
/usr/bin/ansible python version = 2.7.17 (default, Nov 7 2019, 10:07:09)
[GCC 7.4.0]
There is no such problem with Ansible running on controller with Python 3
shell> ansible --version
ansible 2.9.6
config file = /home/vlado/.ansible.cfg
configured module search path = ['/home/vlado/.ansible/my_modules']
ansible python module location = /usr/lib/python3/dist-packages/ansible
executable location = /usr/bin/ansible
python version = 3.8.2 (default, Apr 27 2020, 15:53:34) [GCC 9.3.0]
HTH,
-vlado
Justin Nelson
May 4, 2020, 5:46:08 PM5/4/20
to Ansible Project
The main one I'm testing with is running python 3.6
shell>$ ansible --version
ansible 2.7.4
config file = /etc/ansible/ansible.cfg
configured module search path = ['/home/ofoo/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python3.6/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 3.6.9 (default, Apr 18 2020, 01:56:04) [GCC 8.4.0]
ansible 2.7.4
config file = /etc/ansible/ansible.cfg
configured module search path = ['/home/ofoo/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
ansible python module location = /usr/local/lib/python3.6/dist-packages/ansible
executable location = /usr/local/bin/ansible
python version = 3.6.9 (default, Apr 18 2020, 01:56:04) [GCC 8.4.0]
Vladimir Botka
May 4, 2020, 5:55:34 PM5/4/20
to Kai Stian Olstad, ansible...@googlegroups.com
On Mon, 4 May 2020 23:06:50 +0200
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> > > Add "throttle: 1" to you lineinfile task and it will work.
> >
> > I don't need "throttle" with 2.9.6. The playbook
>
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> > > Add "throttle: 1" to you lineinfile task and it will work.
> >
> > I don't need "throttle" with 2.9.6. The playbook
>
> That is just pure luck, try running it 100 times and count how many times it
> fails.
Well, I tried and it's working properly with Python3. There is no problem with
> fails.
Ansible 2.9.6 and Python 3.8 on the controller ( the redirection in the script
'2>/dev/null' is there because of annoying 3.8 RuntimeWarning).
#!/bin/bash
export ANSIBLE_STDOUT_CALLBACK=null
for i in {1..99}; do
ansible-playbook pb.yml 2>/dev/null
no_lines=`cat test-file | wc -l`
[ $no_lines -ne 2 ] && echo "ERROR File 2 lines missing"
cat /dev/null > test-file
no_lines=`cat test-file | wc -l`
[ $no_lines -ne 0 ] && echo "ERROR File not empty"
done
But, you were right with "throttle". With Ansible 2.9.6 and Python 2.7 on the
controller "throttle: 1" fixed the problem
- name: Update test file
lineinfile:
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{ test_string|lower }}: {{ mac }}"
delegate_to: localhost
line: " test-{{ test_string|lower }}: {{ mac }}"
throttle: 1
Thank you,
-vlado
Kai Stian Olstad
May 4, 2020, 6:02:59 PM5/4/20
to ansible...@googlegroups.com
On Mon, May 04, 2020 at 11:19:53PM +0200, Vladimir Botka wrote:
> On Mon, 4 May 2020 13:26:41 -0700 (PDT)
> Justin Nelson <omeg...@gmail.com> wrote:
>
> > The file contents after that pass are:
> >
> > 1 macs:
> > 2 test-host222: ab:09:87:65:43:21
> >
> > With the file contents now the following:
> >
> > 1 macs:
> > 2 test-host222: ab:09:87:65:43:21
> > 3 test-host111: 12:34:56:78:90:ab
>
> Bingo! I'm able to reproduce the problem with Ansible running on controller
> with Python 2.7
>
<snip />
> On Mon, 4 May 2020 13:26:41 -0700 (PDT)
> Justin Nelson <omeg...@gmail.com> wrote:
>
> > The file contents after that pass are:
> >
> > 1 macs:
> > 2 test-host222: ab:09:87:65:43:21
> >
> > With the file contents now the following:
> >
> > 1 macs:
> > 2 test-host222: ab:09:87:65:43:21
> > 3 test-host111: 12:34:56:78:90:ab
>
> Bingo! I'm able to reproduce the problem with Ansible running on controller
> with Python 2.7
>
> There is no such problem with Ansible running on controller with Python 3
$ ansible-playbook --version | awk 'NR==1; END{print}'
ansible-playbook 2.9.7
python version = 3.7.5 (default, Apr 19 2020, 20:18:17) [GCC 9.2.1 20191008]
$ cat test.yml
- hosts: a1,a2
tasks:
- lineinfile:
path: /tmp/txt
line: "{{ inventory_hostname }}"
delegate_to: localhost
$ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
4 763950971c8c6d8df8a87a1e752799a9 /tmp/txt
11 1597a5a9948014489de663c8fb4438db /tmp/txt
36 ac34af7b876f793d09a2225e23f43088 /tmp/txt
49 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
So as you can see I get 4 different result as expected.
$ cat a1; md5sum a1
a1
763950971c8c6d8df8a87a1e752799a9 a1
$ cat a2; md5sum a2
a2
1597a5a9948014489de663c8fb4438db a2
$ cat a1a2; md5sum a1a2
a1
a2
317f53fd9236220d0ab65e4aac4b3c5a a1a2
$ cat a2a1; md5sum a2a1
a2
a1
ac34af7b876f793d09a2225e23f43088 a2a1
--
Kai Stian Olstad
Vladimir Botka
May 4, 2020, 6:47:29 PM5/4/20
to Kai Stian Olstad, ansible...@googlegroups.com
On Tue, 5 May 2020 00:02:40 +0200
get correct results only.
shell> for i in {1..100}; do >test-file; ansible-playbook pb.yml 2>/dev/null; md5sum test-file; done | sort | uniq -c | sort -n
18 82de37d1deac8c90573c35e5637839d7 test-file
82 6f4e9c06436257db5ba34d527bd3b211 test-file
shell> cat test_01test_02; md5sum test_01test_02
test_01
test_02
6f4e9c06436257db5ba34d527bd3b211 test_01test_02
shell> cat test_02test_01; md5sum test_02test_01
test_02
test_01
82de37d1deac8c90573c35e5637839d7 test_02test_01
shell> ansible --version
ansible 2.9.6
config file = /home/vlado/.ansible.cfg
configured module search path = ['/home/vlado/.ansible/my_modules']
ansible python module location = /usr/lib/python3/dist-packages/ansible
executable location = /usr/bin/ansible
python version = 3.8.2 (default, Apr 27 2020, 15:53:34) [GCC 9.3.0]
--
> On Mon, May 04, 2020 at 11:19:53PM +0200, Vladimir Botka wrote:
> > There is no such problem with Ansible running on controller with Python 3
>
> That's just not true, your test method is flawed, you need to test it more than one time.
>
> > There is no such problem with Ansible running on controller with Python 3
>
> That's just not true, your test method is flawed, you need to test it more than one time.
>
> $ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
> 4 763950971c8c6d8df8a87a1e752799a9 /tmp/txt
> 11 1597a5a9948014489de663c8fb4438db /tmp/txt
> 36 ac34af7b876f793d09a2225e23f43088 /tmp/txt
> 49 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
>
> So as you can see I get 4 different result as expected.
> $ cat a1; md5sum a1
> a1
> 763950971c8c6d8df8a87a1e752799a9 a1
> $ cat a2; md5sum a2
> a2
> 1597a5a9948014489de663c8fb4438db a2
> $ cat a1a2; md5sum a1a2
> a1
> a2
> 317f53fd9236220d0ab65e4aac4b3c5a a1a2
> $ cat a2a1; md5sum a2a1
> a2
> a1
> ac34af7b876f793d09a2225e23f43088 a2a1
Well, it is true. There are no problems reported with your method either. I
> 4 763950971c8c6d8df8a87a1e752799a9 /tmp/txt
> 11 1597a5a9948014489de663c8fb4438db /tmp/txt
> 36 ac34af7b876f793d09a2225e23f43088 /tmp/txt
> 49 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
>
> So as you can see I get 4 different result as expected.
> $ cat a1; md5sum a1
> a1
> 763950971c8c6d8df8a87a1e752799a9 a1
> $ cat a2; md5sum a2
> a2
> 1597a5a9948014489de663c8fb4438db a2
> $ cat a1a2; md5sum a1a2
> a1
> a2
> 317f53fd9236220d0ab65e4aac4b3c5a a1a2
> $ cat a2a1; md5sum a2a1
> a2
> a1
> ac34af7b876f793d09a2225e23f43088 a2a1
get correct results only.
shell> for i in {1..100}; do >test-file; ansible-playbook pb.yml 2>/dev/null; md5sum test-file; done | sort | uniq -c | sort -n
18 82de37d1deac8c90573c35e5637839d7 test-file
82 6f4e9c06436257db5ba34d527bd3b211 test-file
shell> cat test_01test_02; md5sum test_01test_02
test_01
test_02
6f4e9c06436257db5ba34d527bd3b211 test_01test_02
shell> cat test_02test_01; md5sum test_02test_01
test_02
test_01
82de37d1deac8c90573c35e5637839d7 test_02test_01
shell> ansible --version
ansible 2.9.6
config file = /home/vlado/.ansible.cfg
configured module search path = ['/home/vlado/.ansible/my_modules']
ansible python module location = /usr/lib/python3/dist-packages/ansible
executable location = /usr/bin/ansible
python version = 3.8.2 (default, Apr 27 2020, 15:53:34) [GCC 9.3.0]
Vladimir Botka
May 5, 2020, 3:20:11 AM5/5/20
to Kai Stian Olstad, ansible...@googlegroups.com
On Tue, 5 May 2020 00:47:10 +0200
Vladimir Botka <vbo...@gmail.com> wrote:
> On Tue, 5 May 2020 00:02:40 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > On Mon, May 04, 2020 at 11:19:53PM +0200, Vladimir Botka wrote:
> > > There is no such problem with Ansible running on controller with Python 3
> >
> > That's just not true, your test method is flawed, you need to test it more than one time.
> >
> > $ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
> > 4 763950971c8c6d8df8a87a1e752799a9 /tmp/txt
> > 11 1597a5a9948014489de663c8fb4438db /tmp/txt
> > 36 ac34af7b876f793d09a2225e23f43088 /tmp/txt
> > 49 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
>
Vladimir Botka <vbo...@gmail.com> wrote:
> On Tue, 5 May 2020 00:02:40 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > On Mon, May 04, 2020 at 11:19:53PM +0200, Vladimir Botka wrote:
> > > There is no such problem with Ansible running on controller with Python 3
> >
> > That's just not true, your test method is flawed, you need to test it more than one time.
> >
> > $ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
> > 4 763950971c8c6d8df8a87a1e752799a9 /tmp/txt
> > 11 1597a5a9948014489de663c8fb4438db /tmp/txt
> > 36 ac34af7b876f793d09a2225e23f43088 /tmp/txt
> > 49 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
>
> Well, it is true. There are no problems reported with your method either. I
> get correct results only.
>
> shell> for i in {1..100}; do >test-file; ansible-playbook pb.yml 2>/dev/null; md5sum test-file; done | sort | uniq -c | sort -n
> 18 82de37d1deac8c90573c35e5637839d7 test-file
> 82 6f4e9c06436257db5ba34d527bd3b211 test-file
To be sure, I let it run overnight
> get correct results only.
>
> shell> for i in {1..100}; do >test-file; ansible-playbook pb.yml 2>/dev/null; md5sum test-file; done | sort | uniq -c | sort -n
> 18 82de37d1deac8c90573c35e5637839d7 test-file
> 82 6f4e9c06436257db5ba34d527bd3b211 test-file
shell> for i in {1..10000}; do >test-file; ansible-playbook -i hosts77 test77.yml 2>/dev/null; md5sum test-file; done | sort | uniq -c | sort -n
2689 82de37d1deac8c90573c35e5637839d7 test-file
7311 6f4e9c06436257db5ba34d527bd3b211 test-file
Kai Stian Olstad
May 5, 2020, 4:06:35 PM5/5/20
to ansible...@googlegroups.com
On Mon, May 04, 2020 at 11:55:14PM +0200, Vladimir Botka wrote:
> On Mon, 4 May 2020 23:06:50 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > > > Add "throttle: 1" to you lineinfile task and it will work.
> > >
> > > I don't need "throttle" with 2.9.6. The playbook
> >
> > That is just pure luck, try running it 100 times and count how many times it
> > fails.
>
> Well, I tried and it's working properly with Python3. There is no problem with
> Ansible 2.9.6 and Python 3.8 on the controller ( the redirection in the script
> '2>/dev/null' is there because of annoying 3.8 RuntimeWarning).
That is not true and has nothing to do with Python version, and everything with
> On Mon, 4 May 2020 23:06:50 +0200
> Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
>
> > > > Add "throttle: 1" to you lineinfile task and it will work.
> > >
> > > I don't need "throttle" with 2.9.6. The playbook
> >
> > That is just pure luck, try running it 100 times and count how many times it
> > fails.
>
> Well, I tried and it's working properly with Python3. There is no problem with
> Ansible 2.9.6 and Python 3.8 on the controller ( the redirection in the script
> '2>/dev/null' is there because of annoying 3.8 RuntimeWarning).
a little luck and a fast computer.
The test case is flawed for your Ansible controller, if it had more load and/or
more hosts you would get a completely different result.
The reason why this i not reliable is that Ansible is default running forks of
5, that mean that if you had 5 or more hosts it will run/fork out 5 commands.
This 5 commands will try to edit the same file at the same time.
Reason it works for you is that the first fork is finished before the second
has time to start.
This is how Ansible work, and now Python version is going to alter that.
And I'm going to prove it.
Since my machine doesn't have Python 3.8 I created a VM, with 2 cores.
$ ansible-playbook --version | awk 'NR==1; END{print}'
ansible-playbook 2.9.7
So when I run my playbook with two host I get this
$ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
39 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
60 ac34af7b876f793d09a2225e23f43088 /tmp/txt
and the next time
$ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; md5sum /tmp/txt; done | sort | uniq -c | sort -n
1 1597a5a9948014489de663c8fb4438db /tmp/txt
43 317f53fd9236220d0ab65e4aac4b3c5a /tmp/txt
56 ac34af7b876f793d09a2225e23f43088 /tmp/txt
As you can see it fails i 1 % of the cases.
Lets up the stake and go for 6 hosts, the playbook is the same, but since 6 hosts
make potensial a lot of combination, I sort the file before I run md5sum.
So if everything is working OK I should only get one line with one hash like this
100 aae4eb078da77ff549495a60be1a52c2
$ for i in {1..100}; do >/tmp/txt; ansible-playbook test.yml &>/dev/null; sort /tmp/txt | md5sum; done | sort | uniq -c | sort -n
1 2465fc0f03254f2bf915a04c762c9d49 -
2 254316531e34aa3ce563c22cf636ea01 -
2 31f07322fb0283ee5475e5acc74de059 -
2 ab8ecb5209d15e9852be208b79f309eb -
3 7abbd5c371c5e4ccb8bc965105148605 -
90 aae4eb078da77ff549495a60be1a52c2 -
Not even close, it fails in 10% of the runs.
So lets make the machine even more busy.
To do that I shutdown the VM and reduced the cores count from 2 to 1.
Now we have 5 forks at the same time "fighting" for this 1 core and trying to
write to the same file at the same time.
This is the result.
1 254316531e34aa3ce563c22cf636ea01 -
1 6c5ffba74557139441576f9f6536c536 -
1 8da4fee8643e840ae60169eac2d60afd -
1 9a7861beaa38064dd7179cf66b90173f -
1 aae4eb078da77ff549495a60be1a52c2 -
1 d5fad8b2b8f31c4d201309e2261ee362 -
2 2465fc0f03254f2bf915a04c762c9d49 -
2 2ea77912754b2a786046ece007bfd0a7 -
2 6503321b7879267a6a5eb06411e09b5e -
2 9ce72c8f1a3f059db908868df22c2618 -
2 ab8ecb5209d15e9852be208b79f309eb -
2 adc72709b7b7cdc8aaad85c01b66e38d -
2 c4b05365f19a397fc9b2dda817219d49 -
2 cf2b918385c6d1f75d7a0630d8881422 -
2 d678deb816d9433ff1c61d60ec1073f1 -
3 83758fc71d9927b3141c325692534add -
3 989fe3db59b18149e58657daab4721dc -
3 a421781f0d1512c9c66e9f7714bed570 -
4 7bc2be35864ae017608466e62dd680aa -
5 83ba567764a618ec0a0b405d49de8fa9 -
5 c98ae97d4888d870d9a05fe7f9b339a3 -
5 d336136909e4067c35858990dd4f9211 -
6 31f07322fb0283ee5475e5acc74de059 -
6 76aabdf63a1f041f6572fb51fb496283 -
6 cce45b22f8bc7806e3dc1128980f33f6 -
6 cce83e09262e3efced931d81c85ac809 -
6 decd8e81f11339ba387cb7cf61a28f34 -
7 aed3d7850c9c5478d84bf78fdc922328 -
11 d8ee7367ba9763647a58ab23a6f01c5f -
Yeah, it fails miserably, in 99% of the cases.
The correct md5sum is this one
$ cat sorted.txt
a1
a2
a3
a4
a5
a6
$ md5sum sorted.txt
aae4eb078da77ff549495a60be1a52c2 sorted.txt
So no combination of Ptyhon and Ansible released will alter this,
it's just how it work.
That is why we have serial, fork and throttle to tune the behavior to avoid race
conditions.
--
Kai Stian Olstad
Kai Stian Olstad
May 5, 2020, 4:10:19 PM5/5/20
to ansible...@googlegroups.com
fail if you controller had some more load that just 2 hosts.
--
Kai Stian Olstad
Justin Nelson
May 7, 2020, 2:23:23 PM5/7/20
to ansible...@googlegroups.com
Kai,
I just wanted to say thanks for your help in pointing out where I went wrong. Setting the play that was contending for a single file to serial: 1 did the trick. When our ansible controller gets upgraded to 2.9 I'll use throttle to limit just that one task.
Everything is working as expected, and better than it was before.
Thanks again.
--
You received this message because you are subscribed to the Google Groups "Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ansible-proje...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ansible-project/20200504211803.rnrw6wb4rkawvmyo%40olstad.com.
Kai Stian Olstad
May 7, 2020, 2:46:12 PM5/7/20
to ansible...@googlegroups.com
On Thu, May 07, 2020 at 02:22:54PM -0400, Justin Nelson wrote:
> I just wanted to say thanks for your help in pointing out where I went
> wrong. Setting the play that was contending for a single file to serial: 1
> did the trick. When our ansible controller gets upgraded to 2.9 I'll use
> throttle to limit just that one task.
>
> Everything is working as expected, and better than it was before.
You don't need run with serial: 1 if you use your loop below and add
> I just wanted to say thanks for your help in pointing out where I went
> wrong. Setting the play that was contending for a single file to serial: 1
> did the trick. When our ansible controller gets upgraded to 2.9 I'll use
> throttle to limit just that one task.
>
> Everything is working as expected, and better than it was before.
run_once: yes.
That is what I do in cases like this because it's lot faster than serial: 1.
> > On Mon, May 04, 2020 at 02:02:13PM -0700, Justin Nelson wrote:
> > > - name: Update tmp file
> > > lineinfile:
> > > path: "{{ playbook_dir }}/macs.yaml"
> > > regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
> > > line: " test-{{test_string|lower}}: {{mac}}"
> > > create: yes
> > > loop: "{{ ansible_play_hosts }}"
> > > vars:
> > > test_string: "{{ hostvars[item]['test_string'] }}"
> > > mac: "{{ hostvars[item]['mac'] }}"
- name: Update tmp file
lineinfile:
path: "{{ playbook_dir }}/macs.yaml"
regexp: "^\ \ test[.-]{{ test_string|lower }}:.*"
line: " test-{{test_string|lower}}: {{mac}}"
create: yes
loop: "{{ ansible_play_hosts }}"
vars:
test_string: "{{ hostvars[item]['test_string'] }}"
mac: "{{ hostvars[item]['mac'] }}"
--
test_string: "{{ hostvars[item]['test_string'] }}"
mac: "{{ hostvars[item]['mac'] }}"
Kai Stian Olstad
Vladimir Botka
May 10, 2020, 8:48:12 AM5/10/20
to Kai Stian Olstad, ansible...@googlegroups.com
On Tue, 5 May 2020 22:06:04 +0200
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> On Mon, May 04, 2020 at 11:55:14PM +0200, Vladimir Botka wrote:
> > Well, I tried and it's working properly with Python3. There is no problem with
> > Ansible 2.9.6 and Python 3.8 on the controller
>
Kai Stian Olstad <ansible-pr...@olstad.com> wrote:
> On Mon, May 04, 2020 at 11:55:14PM +0200, Vladimir Botka wrote:
> > Well, I tried and it's working properly with Python3. There is no problem with
> > Ansible 2.9.6 and Python 3.8 on the controller
>
> That is not true and has nothing to do with Python version, and everything with
> a little luck and a fast computer.
Right. Python is irrelevant. Your results proved it. I took the slowest
> a little luck and a fast computer.
one I've got (Intel(R) Core(TM) i5-8200Y CPU @ 1.30GHz) XPS 13 9365 Ubuntu
20.04.
> The test case is flawed for your Ansible controller, if it had more load and/or
> more hosts you would get a completely different result.
the result failed:6 ok:4 (number of hosts written
(18,19,18,19,19,19,20,20,20,20).
> The reason why this i not reliable is that Ansible is default running forks of
> 5, that mean that if you had 5 or more hosts it will run/fork out 5 commands.
> This 5 commands will try to edit the same file at the same time.
6th host started to write about the time the 1st one finished. The playbook
below
- hosts: all
gather_facts: false
tasks:
- lineinfile:
path: "{{ playbook_dir }}/test_file"
tasks:
- lineinfile:
line: "{{ inventory_hostname }}"
create: true
delegate_to: localhost
gave the "runner_on_ok" events (counter,pid,host,start,end,duration) in the
table below selected from the ansible-runner artifacts.
010 104710 test_01 27:33.764342 27:34.826178 1.061836
012 104710 test_04 27:33.804294 27:34.892333 1.088039
014 104710 test_05 27:33.831383 27:34.983917 1.152534
016 104710 test_03 27:33.790178 27:35.017124 1.226946
018 104710 test_02 27:33.774777 27:35.048550 1.273773
020 104710 test_06 27:34.808575 27:35.716538 0.907963
022 104710 test_07 27:34.884775 27:35.788730 0.903955
024 104710 test_08 27:34.969329 27:35.819368 0.850039
026 104710 test_09 27:35.006282 27:35.906473 0.900191
028 104710 test_10 27:35.042953 27:35.974963 0.93201
030 104710 test_12 27:35.781438 27:36.713863 0.932425
032 104710 test_11 27:35.708957 27:36.747040 1.038083
034 104710 test_14 27:35.894955 27:36.770536 0.875581
036 104710 test_13 27:35.811156 27:36.793905 0.982749
038 104710 test_15 27:35.967495 27:36.921133 0.953638
039 104710 test_17 27:36.737726 27:37.517073 0.779347
040 104710 test_16 27:36.704352 27:37.524634 0.820282
041 104710 test_19 27:36.786723 27:37.533726 0.747003
042 104710 test_18 27:36.763620 27:37.549728 0.786108
043 104710 test_20 27:36.914053 27:37.694404 0.780351
Link to 200 (10 x playbook x 20 hosts) events sorted by the end-time
https://gist.github.com/vbotka/31ccd5380a2b230be11b1df78cc402a1
(incl. the playbook to select events and the script to run the test)
> Reason it works for you is that the first fork is finished before the second
> has time to start.
needed to interpret the results, I think.
> This is how Ansible work, and now Python version is going to alter that.
> And I'm going to prove it.
> [...]
> Yeah, it fails miserably, in 99% of the cases.
> The correct md5sum is this one
I can not confirm such a high percentage of failures.
> The correct md5sum is this one
> So no combination of Ptyhon and Ansible released will alter this,
> it's just how it work.
> That is why we have serial, fork and throttle to tune the behavior to avoid race
> conditions.
Thank you,
-vlado
Reply all
Reply to author
Forward
0 new messages