Vagrant Ansible Provisioner - best practice

[chinedu uzoka]

Ive been asked to use Ansible to create a CI and CD pipeline - i have extensive knowledge of Puppet and know experience of Ansible - im almost two weeks in and after trying to model Ansible with same concepts derived from Puppet im almost happy

Some frustrations aside i wondered whether I am doing things a ok

My setup is thus -

I have a Packer repo to build OS
I have an Ansible repo using ansible-galaxy (like i did with r10k)
Vagrant repo and ansible is including in the project as a submodule

I have a nodes.yaml file like so:

---
inv:
  groups:
    webserver:
      web1:
        memory: 256
    dbs:
      db1:
    varnish:
      varnish:
  child_groups:
    all_groups: ['webserver','dbs', 'varnish']

I have code (its in a separate file ) that Vagrant uses to create nodes and ansible groups while still relying on Vagrants auto generated inventory to manage the whole affair. 

So the only file that needs modifying is nodes.yaml and hopefully in this environment will reman static

What I would like to know is Im i going about this well as in is this the best practice way of doing things