Exception - Batch rate limit hit by User _ID_

[Miroslav (Code for Croatia, ImamoPravoZnati.org)]

Hello,

We received exception for Batch Requests Pro functionality saying:

INCIDENT #56

[ERROR] [imamopravoznati.org] info_request_batches create (Exception) "Batch rate limit hit by User: 1274"

View Incident

DETAILS

An Exception occurred in info_request_batches#create:   

  Batch rate limit hit by User: _ID_

From Parameters I can see that batch request had 67 requests:

* Parameters : {"utf8"=>"✓", "authenticity_token"=>"[REDACTED]", "draft_id"=>"26", "commit"=>"Pošaljite 67 zahtjeva", "controller"=>"alaveteli_pro/info_request_batches", "action"=>"create"}

Our batch limit is set to 500, and user said they were making smaller batch requests 50-100 each, and cumulative all his requests in total didn't reach 500 requests.

So is this error related to hitting some other limit (and not one set in general.yml)?

Thanks,

Miroslav

[Graeme Porteous]

Hi Miroslav,

This is misleading but this isn't actually an error. It is a warning to the site admins about potential abuse of the batch functionality.

It doesn't prevent the user from actually creating their batch request.

Graeme

--
Graeme Porteous
gra...@mysociety.org

Code for Croatia brine o zaštiti Vaše privatnosti. Molimo vas da ograničite dijeljenje svojih osobnih podataka putem elektroničke pošte.

Vodite računa o okolišu. Ne tiskajte ovu poruku ako nije neophodno.

--
You received this message because you are subscribed to the Google Groups "Alaveteli Dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to alaveteli-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/alaveteli-dev/34cf2041-3e04-46be-96ff-779a7f65bae9n%40googlegroups.com.

[Miroslav (Code for Croatia, ImamoPravoZnati.org)]

Hi Graeme,

got it, right. From the code I see this is actually some soft of "fair use warning" which triggers if user makes more than 5 batches in an hour and also more than 5 batches in the week?

Do I read it correctly?

https://github.com/mysociety/alaveteli/blob/5ff29c6b7fc1c57ac9500e1706e4f1ee923ee153/app/controllers/alaveteli_pro/info_request_batches_controller.rb#L55

If that is the case, I would maybe suggest to change text from:

"Batch rate limit hit by User"

to something like:

"Batch fair use warning for soft rate limit hit by Pro User"

(specifically to say "soft rate limit" to indicate it's not hard limit and that user will not be blocked)

Thanks,

Miroslav