Graphana docker image ?

10 views
Skip to first unread message

Matthias Wessendorf

unread,
Mar 14, 2018, 11:15:26 AM3/14/18
to AeroGear Developer Mailing List, Aerogear
Hi,

I am not able to find the image for this container:

If not an automated build repo, we should at least point to the actual aerogear GH repository, where the thing is located.

Thanks

--
Matthias Wessendorf

github: https://github.com/matzew 
twitter: http://twitter.com/mwessendorf

David Martin

unread,
Mar 15, 2018, 5:27:44 AM3/15/18
to Matthias Wessendorf, Dara Hayes, Steven Tobin, AeroGear Developer Mailing List, Aerogear
I remember a rember there's a reason for having a custom image built
(we need specific features that aren't in latest upstream image), but
I'm not sure who pushed it up and from where.

@Dara @Steven, is there a fork of grafana or some repo where we have
the Dockerfile?
> --
> You received this message because you are subscribed to the Google Groups
> "Aerogear" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to aerogear+u...@googlegroups.com.
> To post to this group, send email to aero...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)

Matthias Wessendorf

unread,
Mar 15, 2018, 6:08:45 AM3/15/18
to David Martin, Matthias Wessendorf, Dara Hayes, Steven Tobin, AeroGear Developer Mailing List, Aerogear
custom image is all fine - but we should share what we did, and have a (forked) repo :-) 

Also, in the long run - this needs to be "reproducable" in terms of builds ;-)

On Thu, Mar 15, 2018 at 10:27 AM, David Martin <davm...@redhat.com> wrote:
I remember a rember there's a reason for having a custom image built
(we need specific features that aren't in latest upstream image), but
I'm not sure who pushed it up and from where.

@Dara @Steven, is there a fork of grafana or some repo where we have
the Dockerfile?

On 14 March 2018 at 15:15, Matthias Wessendorf <mat...@apache.org> wrote:
> Hi,
>
> I am not able to find the image for this container:
> https://hub.docker.com/r/aerogearcatalog/grafana/
>
> If not an automated build repo, we should at least point to the actual
> aerogear GH repository, where the thing is located.
>
> Thanks
>
> --
> Matthias Wessendorf
>
> github: https://github.com/matzew
> twitter: http://twitter.com/mwessendorf
>
> --
> You received this message because you are subscribed to the Google Groups
> "Aerogear" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> To post to this group, send email to aero...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)
--
You received this message because you are subscribed to the Google Groups "Aerogear" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aerogear+unsubscribe@googlegroups.com.

To post to this group, send email to aero...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
Project lead AeroGear.org

Dara Hayes

unread,
Mar 15, 2018, 6:19:44 AM3/15/18
to David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
TL;DR: We forked the grafana build tools [0] and built a commit off the master branch that we knew to be stable. In addition we modified the build scripts to include some Grafana plugins inside the container image. There were two reasons we did this.

1. We were depending on new features in Grafana that were only available on the master branch. Grafana was under very heavy development as they geared up towards their 5.0 release and we were finding new problems arising every few days while we worked off the master branch. This was really slowing down APB development. 

2. We needed to install additional plugins required by some dashboards. Grafana's docker image provides a way to install plugins using environment variables fed into the container at runtime but this requires root access which is not feasible in Openshift. The only way we could do it at the time was by baking in the plugins as part of the docker build. It's a terrible solution but it was the only way at the time to continue the very fast pace of development of the APBs.

There are still a some questions to be answered:

* How are we going to distribute Grafana on OpenShift such that it doesn't require root access?
* What is the best way to install plugins? There was some discussion about the different options and the consequences of those options in this document [1]

This all arose during a sprint where one of the primary goals was to deliver an APB that could provision Grafana + Prometheus and display dashboard discovery and some other features. We decided at the time that we were not prepared to answer those bigger questions so we knowingly put this technical debt on ourselves and implemented a quick and dirty solution.

This entire thing was discussed publicly in a Github PR: https://github.com/aerogearcatalog/keycloak-apb/pull/33 But perhaps it should also have been mentioned on list at the time. Hope this clears things up.


On Thu, Mar 15, 2018 at 9:27 AM, David Martin <davm...@redhat.com> wrote:
I remember a rember there's a reason for having a custom image built
(we need specific features that aren't in latest upstream image), but
I'm not sure who pushed it up and from where.

@Dara @Steven, is there a fork of grafana or some repo where we have
the Dockerfile?

On 14 March 2018 at 15:15, Matthias Wessendorf <mat...@apache.org> wrote:
> Hi,
>
> I am not able to find the image for this container:
> https://hub.docker.com/r/aerogearcatalog/grafana/
>
> If not an automated build repo, we should at least point to the actual
> aerogear GH repository, where the thing is located.
>
> Thanks
>
> --
> Matthias Wessendorf
>
> github: https://github.com/matzew
> twitter: http://twitter.com/mwessendorf
>
> --
> You received this message because you are subscribed to the Google Groups
> "Aerogear" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> To post to this group, send email to aero...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)



--

Dara Hayes

Associate software engineer

TRIED. TESTED. TRUSTED.

Matthias Wessendorf

unread,
Mar 15, 2018, 6:25:04 AM3/15/18
to Dara Hayes, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
there is no issue w/ forks etc :-)

I just found it very annoying not seeing any hint on the repo, in dockerhub :-)

I will update it 


For more options, visit https://groups.google.com/d/optout.



--
Project lead AeroGear.org

Matthias Wessendorf

unread,
Mar 15, 2018, 6:26:03 AM3/15/18
to Dara Hayes, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
The other question is ... is "aerogearcatalog" the right choice ? 

IMO no - since that https://github.com/aerogear/grafana-docker is not an APB

IMO it would be better in "aerogear" dh org ;-) 
--
Project lead AeroGear.org
Message has been deleted

Dara Hayes

unread,
Mar 15, 2018, 6:51:05 AM3/15/18
to Matthias Wessendorf, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
I 100% agree that it should be in the aerogear org and I suggested it at the time. However, we were never given access (even though we asked) :)

Phil Brookes

unread,
Mar 15, 2018, 6:58:40 AM3/15/18
to Dara Hayes, Matthias Wessendorf, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear

Hey Dara,

I have added you to the developers teams in the aerogear org now. Let me know if any others need to be added, or if it is not working correctly for you.

Regards,
Phil.


--
You received this message because you are subscribed to a topic in the Google Groups "Aerogear" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/aerogear/uG4KaT_EYGg/unsubscribe.
To unsubscribe from this group and all its topics, send an email to aerogear+unsubscribe@googlegroups.com.

To post to this group, send email to aero...@googlegroups.com.

Matthias Wessendorf

unread,
Mar 15, 2018, 6:59:32 AM3/15/18
to Dara Hayes, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
I see you on the team -> https://hub.docker.com/u/darahayes/ (at least this account) 
--
Project lead AeroGear.org

Dara Hayes

unread,
Mar 15, 2018, 8:24:04 AM3/15/18
to Matthias Wessendorf, David Martin, Matthias Wessendorf, Steven Tobin, AeroGear Developer Mailing List, Aerogear
Thanks Phil!

@Matthias: yes I got added to the dockerhub one recently for the aerogear app metrics service :)

- Dara

Dara Hayes

unread,
Mar 22, 2018, 7:22:05 AM3/22/18
to pbro...@redhat.com, Aerogear
Hey Phil,

I've been catching up on some housekeeping tasks. I think we all agree that the aerogearcatalog organisation was not the right place to host the image.

Now that I have access, I've pushed it to https://hub.docker.com/r/aerogear/grafana/ and I've opened a PR against the metrics-apb (I've pinged you for review). Once that's been merged we can remove the image from aerogearcatalog.

Kindest Regards,

Dara

On Thu, Mar 15, 2018 at 10:33 AM, <pbro...@redhat.com> wrote:
Hey Guys,

I agree with Matthias on this. When we had the discussion that lead to the creation of aerogearcatalog - we agreed that we would create this org so that we would have a undiluted index of APBs.

Based on this I would say that anything that is not an APB does not belong in the aerogearcatalog organisation.

The aerogear org seems like a fine location for it though.

Regards,
Phil.

> To post to this group, send email to aero...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/aerogear/CAAg5f2RgsYFDWqG%3DX%3Dj%3D48fVhCH2nrgjRuXNdNF9za3nt8uhSQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.



--
David Martin
Red Hat Mobile
Twitter: @irldavem
IRC: @irldavem (#aerogear)



--

Dara Hayes

Associate software engineer

TRIED. TESTED. TRUSTED.

--
You received this message because you are subscribed to the Google Groups "Aerogear" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aerogear+u...@googlegroups.com.

To post to this group, send email to aero...@googlegroups.com.



--
Project lead AeroGear.org



--
Project lead AeroGear.org

--
You received this message because you are subscribed to the Google Groups "Aerogear" group.
To unsubscribe from this group and stop receiving emails from it, send an email to aerogear+unsubscribe@googlegroups.com.
To post to this group, send email to aero...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.



--
Reply all
Reply to author
Forward
0 new messages