Feedback for google-ads-ruby

[Don Mitchell]

I believe the resources should define getters and setters for all the attributes which do the appropriate wrapper calls rather than expecting the user of the api to tediously call wrapper as in the following

payload = client.resource(:CampaignBudget)

payload.name = client.wrapper.string(name)

which should just be imho

payload.name = name

Similarly, resource and operation should take hashes as args and set the corresponding attributes

payload = client.resource(:CampaignBudget, {name: name, amount_micros: amount, delivery_method: 'ACCELERATED', explicitly_shared: true})

You'll note that I expect the setter for 'delivery_method' to know how to find its enum and lookup the value.

[Dannison Yao (AdWords API Team)]

Hi Don,

It seems that your concern is more related to the Ruby client library. With this said, I would suggest that you reach out to the client library owners via this link as they are better equipped to assist you regarding this matter.

Regards,

Dannison

AdWords API Team

[Dannison Yao (AdWords API Team)]

Hi Don,

It appears that you also created the same feedback on the client library github tracker and the team is currently aware about the issue you submitted.

Regards,

Dannison

AdWords API Team