So many bugs & broken things

122 views
Skip to first unread message

Deny Watanabe

unread,
May 25, 2021, 12:47:22 PM5/25/21
to AdWords API and Google Ads API Forum
1) google_ads changed to googleads in class path: REALLY guys, you couldn't live with an old name, you had to go ahead and BREAK THINGS for users? If we are so irrelevant, why bother developing stuff and releasing it publicly?

2) To whom it may concern,  MessageToJson and MessageToDict from google.protobuf.json_format no longer work. I've created a workaround, but really who cares?

3) When issuing search_stream and querying ad_group, ad_group_ad, etc., "where campaign.id = xxxxx" no longer works, bringing no results. The reason I was using this was so I could implement some sort of incremental query based on campaign age and status, otherwise we get a HUGE amount of data in the results (I'm responsible for Coca-Cola, General Motors, Nestle and some other large accounts in Brazil). Now we have to go back to filtering by client which is in practice no filter at all, and by doing that we'll clog your servers, congratulations.

4) Things keep getting better and better as any column named "type" NEEDS TO BE QUERIED with the original name, but HAS TO BE READ as "type_". 

If I sound pissed is because I AM. At this point, all things being equal, I'm recommending ANYTHING but google to my clients. Your devs are unbelievably incompetent, and I would bet good money they think they're incredible (Dunning-Kruger anyone?). Complexity is not a measure of success, quite the opposite in fact. Your code is HORRIBLE and an embarrassment to Google.

Google Ads API Forum Advisor Prod

unread,
May 26, 2021, 2:42:11 AM5/26/21
to adwor...@googlegroups.com
Hi,

Sorry to hear your frustration. Allow me to provide support to your concern.

As for the first 2 items, since the issue is more specific to client library, then I would suggest posting it to one of the support channels below based on the client library that you are using. You can get support from the author of the client library that is more equipped on this topic.

"3) When issuing search_stream and querying ad_group, ad_group_ad, etc., "where campaign.id = xxxxx" no longer works, bringing no results"
- Could you provide the complete request and response logs with request ID generated on your end to investigate this issue and to address it? Please provide it via Reply privately to author option.


"4) Things keep getting better and better as any column named "type" NEEDS TO BE QUERIED with the original name, but HAS TO BE READ as "type_". "
-To take a closer look at this issue, could you also provide the complete request and response logs with request ID generated on your end where we can see it? Please provide it also through Reply privately to author option.

Regards,
Google Logo
Ernie John Blanca Tacata
Google Ads API Team
 


ref:_00D1U1174p._5004Q2HDaEA:ref

Mat

unread,
May 26, 2021, 9:53:40 AM5/26/21
to AdWords API and Google Ads API Forum
Hi Deny,

I feel you.

2) I opened an issue regarding this point a few days ago. There is an answer from the Python library maintainers too, that works for me.

3) I did not run into this issue yet. At least I hope so (would be very bad). Could you provide an example?

4) This is not limited to fields named "type". Technically, this could affect many other field-names too.

Regards
Mat

Message has been deleted

Deny Watanabe

unread,
May 26, 2021, 1:19:03 PM5/26/21
to AdWords API and Google Ads API Forum
Hi Mat,

3) actually this one was caused by my solution for 2) not being fully debugged on my side, working OK now.

In fact as far as I'm concerned all the issues I've addressed in my OP have been circumvented by yours truly so the issue can be closed, but the bitter taste left by the experience will take a while to fade away.

Cheers,
Deny

Google Ads API Forum Advisor Prod

unread,
May 27, 2021, 1:17:42 AM5/27/21
to deny.w...@wmccann.com, adwor...@googlegroups.com

Hello Deny,

Thanks for getting back to us.

We completely understand on the inconvenience you've encountered and we're here to help you on this.

For us to help you address on your question 3, please enable logging and retry your request to generate these logs (request and response with request-id). You can then send those logs via this email (googleadsa...@google.com). In addition, you mentioned that if you omit the “where campaign.id=11615336854” clause, it returns one adgroup row for that campaign. I've checked on the provided customer ID and I can see that the campaign ID only contains a single adgroup. Could you further elaborate on this?

As an aside, I need to remove your post as it might contain data that isn't intended to shared publicly. Below is a copy of your post with the masked data.

"Hello Ernie,

Thank you for your reply and sorry about venting so bluntly but I am very upset about the whole thing. Sorry to reply publicly but the “Reply to Author” button appears disabled to me.

I don’t care about items 1, 2 and 4 as I’ve fixed those myself on my end.

But concering item 3, we have almost 10 million rows of dimension data for adgroup criterion for one client, another 3 million rows for another one and so on. We query those 4 times a day and it’s taking over 5 hours to get all data without the incremental logic we were using before the Google Ads query engine broke.

We’re using the 
Python client libraries, all updated to the latest version, so I don’t really have access to the actual raw request and results (the later would solve many of my issues that I’ve had to build workarounds to fix btw).

The only thing I can provide is the query and response metadata, we’re using the 
SearchGoogleAdsStreamRequest method:

*** QUERY for customer ID ***
<>

 *** RESPONSE ***
<>

Please note that if I omit the “where 
campaign.id=11615336854” clause, it returns one adgroup row for that campaign.

Also, we use the 
same function for querying with and without the “where” clause, and it works perfectly without it for all entities.

Cheers,
Deny
"

Regards,

Google Logo
Mark Kevin Albios
Google Ads API Team
 


ref:_00D1U1174p._5004Q2HDaEA:ref
Reply all
Reply to author
Forward
0 new messages