Sub-classing wx.TextCompleter

[Xaviou]

Hi.

I am trying to play with auto completion.

I have created a class derived from wx.TextCompleter witch contains the following :

import wx

from ClassList import szClasses

class ClassCompleter(wx.TextCompleter):

def __init__(self):

wx.TextCompleter.__init__(self)

self._iLastReturned = wx.NOT_FOUND

self._sPrefix = ''

def Start(self, prefix):

self._sPrefix = prefix.lower()

self._iLastReturned = wx.NOT_FOUND

for item in szClasses:

if item.lower().startswith(self._sPrefix):

return True

# Nothing found

return False

def GetNext(self):

for i in range(self._iLastReturned+1, len(szClasses)):

if szClasses[i].lower().startswith(self._sPrefix):

return szClasses[i]

# No more corresponding item

return ''

Then, in the main application, I've created a simple textbox and enabled auto complete using the following line :

self._txtEntry.AutoComplete(ClassCompleter())

But this line gives an error at execution time :

TypeError: wx._core.TextCompleter cannot be instantiated or sub-classed

OnInit returned false, exiting...

Can one tell me what I've done wrong ?

I'm using wxPython 4.0.2a1 dev3717 64bits on a Windows 10 system, installed from the "snapshots builds" wheels (https://wxpython.org/Phoenix/snapshot-builds/).

Thanks in advance.

Regards

Xav'

[Xaviou]

Hi again...

For people who prefer having a small test app : here it is.

The line witch causes the error has been commented : see MainFrame.py line 28

Regards

Xav'

[Robin Dunn]

Thanks for the sample. I'll take a look when I can. It will probably need some extra tweaks for that class to convince sip that it's not an abstract class.

I've added an issue to track this, and so it won't be forgotten. https://github.com/wxWidgets/Phoenix/issues/827

--

Robin

[Xaviou]

Hi.

I think there is also a problem with wx.TextCompleterSimple : I've tried the sample code provided on the doc (https://wxpython.org/Phoenix/docs/html/wx.TextCompleterSimple.html) and I obtain an error when auto completion starts :

NotImplementedError: TextCompleterSimple.Start() is abstract and must be overridden

If I add a basic "Start" method witch returns a boolean, it also requires the "GetNext" one:

NotImplementedError: TextCompleterSimple.GetNext() is abstract and must be overridden

Regards

Xav'

[Scott Talbert]

Yes, looks like another bug. TextCompleterSimple should only require
GetCompletions() to be overridden.

> --
> You received this message because you are subscribed to the Google Groups
> "wxPython-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to wxpython-user...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

[Scott Talbert]

I submitted this to fix the TextCompleter issues:
https://github.com/wxWidgets/Phoenix/pull/829

[Xaviou]

Hi.

On Saturday, April 28, 2018 at 2:44:57 AM UTC+2, Scott Talbert wrote:

I submitted this to fix the TextCompleter issues:
https://github.com/wxWidgets/Phoenix/pull/829

Thank you.

It works fine for TextCompleter.

But TextCompleterSimple still requires the "Start" and "GetNext" method to be overriden.

Regards

Xav'

[Xaviou]

I think there is a problem with the last snapshot build filenames :

• wheels names are like "wxPython-4.0.2a1.dev3730+6e8d62e-cp36-cp36m-win_amd64.whl"
  
• sources tarball name is "wxPython-4.0.2a1.dev3730+6e8d62e0.tar.gz" (1 more char in the commit ref)
  

So pip don't install the wheel : it tries to install from the sources.

Regards

Xav'

[Robin Dunn]

Thanks. That will be an easy fix, I'll probably be able to get it taken care of this evening.

https://github.com/wxWidgets/Phoenix/issues/836

--

Robin

[Robin Dunn]

On Sunday, April 29, 2018 at 11:58:36 PM UTC-7, Xaviou wrote:

I think there is a problem with the last snapshot build filenames :

• wheels names are like "wxPython-4.0.2a1.dev3730+6e8d62e-cp36-cp36m-win_amd64.whl"
  
• sources tarball name is "wxPython-4.0.2a1.dev3730+6e8d62e0.tar.gz" (1 more char in the commit ref)
  

So pip don't install the wheel : it tries to install from the sources.

Thanks. https://github.com/wxWidgets/Phoenix/issues/837

 

--Robin

[Xaviou]

Hi.

Thank you for all fixes on this point.

I also noticed that GetCompletions for the TextCompleterSimple class has changed (in a more logical way than it was before).

Regards

Xav'

[Scott Talbert]

Good point - Robin, we should also update the example code to reflect
'res' being returned now instead of a parameter.

Scott

[Robin Dunn]

Yep, I changed it but apparently it didn't get checked in to the PR's branch. It will be there in the next build.

--

Robin