On Wed, 27 Sep 2017 19:45:34 +0200 Maarten Bent wrote:
MB> Comments on a recent commit reminded me of my tests using git submodules
MB> for third party libraries.
MB> Git submodules make it easier to keep these libraries up-to-date.
MB>
MB> I added submodules for expat, jpeg, png, tiff and zlib in this
MB> <
https://github.com/MaartenBent/wxWidgets/tree/submodules> branch.
Wow, great, thanks a lot (and sorry for still not having had time to look
at your PR 527 and 528 -- but, on the bright side, perhaps they're not
needed any more?)!
MB> I located (official and unofficial) git repositories for these
MB> libraries, forked them, added a wxwidgets branch,
MB> and committed the changes that are currently used by wxWidgets (see tiff
MB> <
https://github.com/MaartenBent/libtiff/tree/wxwidgets>, jpeg
MB> <
https://github.com/MaartenBent/libjpeg/tree/wxwidgets>, png
MB> <
https://github.com/MaartenBent/libpng/tree/wxwidgets>, expat
MB> <
https://github.com/MaartenBent/libexpat/tree/wxwidgets> and zlib
MB> <
https://github.com/MaartenBent/zlib/tree/wxwidgets>).
MB> There are some jpeg files added and removed, and expat moved to a
MB> subdirectory, so I also had an attempt at rebaking the project files.
MB> Eventually, everything builds successfully on my system (Windows 10,
MB> msvc and mingw).
Have you by chance tried building under Unix (with --disable-sys-libs to
ensure that the bundled libraries are picked up)?
MB> To merge it into the main wxWidgets branch, I guess the third party
MB> libraries should be forked under the wxWidgets organization,
MB> and a wxWidgets branch has to be created from the last official release
MB> of the library.
Yes, I'd be more ready to do this. I guess I should just fork your
repositories under wxWidgets org, right?
On Thu, 28 Sep 2017 07:41:35 -0600 Bryan Petty wrote:
BP> On Wed, Sep 27, 2017 at 11:45 AM, Maarten Bent <
maart...@gmail.com> wrote:
BP> > Comments on a recent commit reminded me of my tests using git submodules for
BP> > third party libraries.
BP> > Git submodules make it easier to keep these libraries up-to-date.
BP>
BP> Did you experiment with using git subtree to maintain them? I proposed
BP> that here:
BP>
http://trac.wxwidgets.org/ticket/15588#comment:21
I know that many people strongly dislike submodules and I'm not blind to
their shortcomings myself (it's hard not to be, after having used them for
a while), but they still remain the official Git way of solving this
problem and I think it would be wrong to use anything else just from the
point of view of familiarity and support. Besides, the problems with
submodules don't matter that much to us and support for them in Git has
already become much better and will undoubtedly improve even more in the
future.
Regards,
VZ