[patch] Operation of the tab page label with the mouse is wrong.

65 views
Skip to first unread message

h_east

unread,
Sep 3, 2015, 8:35:43 AM9/3/15
to vim_dev
Hi Bram and List,

Tab page does not move even when click and hold the tab page label and drag it to the right of the label.

How to reproduce (CUI Vim on Linux via xterm):
- Preparation.
$ export TERM=xterm-256color
- Start pure Vim. (Open five tab pages)
$ vim -N -u NONE -p A B C D E -c "set mouse=a"
- Click and hold tab page label "A" with the mouse.
- Drag to tab page label "B".

Expected behavior:
- Tab page "A" move to tab page "B" of the right side.

Actual behavior:
- Tab page doesn't move.
When drag to tab page label "C", Become to expected behavior.


Investigation result:
- This bug is regression since the patch 7.4.709.
Sorry. It's my patch.


I wrote a patch.
Please include this.

BTW, Below is also need to be modified, so that, Abe fixed this.
> Patch for drag&drop reordering of GUI tab pages reordering.
> (Ken Takata, 2013 Nov 22, second one, also by Masamichi Abe)

https://gist.github.com/nocd5/165286495c782b815b94
This patch was tested on Windows7 64bit and Ubuntu 14.04.2 64bit.

Let's include the above patch!

Thanks.
--
Best regards,
Hirohito Higashi (a.k.a h_east)

tabpage_drag_to_right_fix.patch

Bram Moolenaar

unread,
Sep 3, 2015, 4:01:27 PM9/3/15
to h_east, vim_dev
Thanks!

--
We apologise again for the fault in the subtitles. Those responsible for
sacking the people who have just been sacked have been sacked.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD

/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Reply all
Reply to author
Forward
0 new messages