Performance improvement: skip applying of modelines if nothing was done in `:doautocmd`

[Daniel Hahler]

I have seen a noticeable performance problem when using the `vim-oblique` plugin, which was caused by calls to `doautocmd User ...` - although the user events did not exist (https://github.com/junegunn/vim-oblique/issues/30).

While there is the `<nomodeline>` option for `:doautocmd`, Vim could always skip applying the modeline (again) in case no commands were executed.

This makes especially sense when there are no events defined at all (that's what the fix for the plugin did: https://github.com/junegunn/vim-oblique/commit/32e1c4291e9138d55962e7408866a80d99726a28).

Regards,
Daniel.

[Andy Wokula]

Am 20.10.2014 um 08:23 schrieb Daniel Hahler:
> I have seen a noticeable performance problem when using the
> `vim-oblique` plugin, which was caused by calls to `doautocmd User
> ...` - although the user events did not exist
> (https://github.com/junegunn/vim-oblique/issues/30).
>
> While there is the `<nomodeline>` option for `:doautocmd`, Vim could
> always skip applying the modeline (again) in case no commands were
> executed.

I want unconditional execution of modelines.

" :DoModelines
" manually execute the modelines ("no matching autocmds" is a good thing
" here, we only need the side effect of :doautocmd); added 2010 Sep 27

com! -bar DoModelines :silent doautocmd User DoModelines

--
Andy

[Daniel Hahler]

Am Montag, 20. Oktober 2014 19:55:53 UTC+2 schrieb Andy Wokula:

> I want unconditional execution of modelines.
>
> " :DoModelines
> " manually execute the modelines ("no matching autocmds" is a good thing
> " here, we only need the side effect of :doautocmd); added 2010 Sep 27
>
> com! -bar DoModelines :silent doautocmd User DoModelines

Ok. But this appears to be a candidate for a separate command then.

Wouldn't `:e` work for you, too?

Cheers,
Daniel.

[Christian Brabandt]

On Mo, 20 Okt 2014, Daniel Hahler wrote:

> Am Montag, 20. Oktober 2014 19:55:53 UTC+2 schrieb Andy Wokula:
>
> > I want unconditional execution of modelines.
> >
> > " :DoModelines
> > " manually execute the modelines ("no matching autocmds" is a good thing
> > " here, we only need the side effect of :doautocmd); added 2010 Sep 27
> >
> > com! -bar DoModelines :silent doautocmd User DoModelines
>
> Ok. But this appears to be a candidate for a separate command then.

Attached patch does that.

> Wouldn't `:e` work for you, too?

That loses your changes.

Best,
Christian
--
Auf 93 Millionen Meilen gibt es nichts zwischen der Sonne und meinem
Schatten. Ich bin immer irgendetwas im Wege ...

[Andy Wokula]

Am 21.10.2014 um 16:51 schrieb Christian Brabandt:
> On Mo, 20 Okt 2014, Daniel Hahler wrote:
>
>> Am Montag, 20. Oktober 2014 19:55:53 UTC+2 schrieb Andy Wokula:
>>
>>> I want unconditional execution of modelines.
>>>
>>> " :DoModelines
>>> " manually execute the modelines ("no matching autocmds" is a good thing
>>> " here, we only need the side effect of :doautocmd); added 2010 Sep 27
>>>
>>> com! -bar DoModelines :silent doautocmd User DoModelines
>>
>> Ok. But this appears to be a candidate for a separate command then.
>
> Attached patch does that.
>
>> Wouldn't `:e` work for you, too?
>
> That loses your changes.

So far this patch works for me.
:domodelines executes modelines.
:doau only executes modelines when there are matching autocommands.

--
Andy