Update ftplugin/ocaml.vim
Hirotaka Hamada
Bram Moolenaar
Markus Mottl wrote:
> Hi Hirotaka,
>
> thanks for the patches, I have applied them to my files.
>
> What is actually the best way to contribute updates to the Vim
> maintainers these days? I see you have switched to Mercurial, which
> is great, because I'm also an avid user. Is there a way to submit
> pull requests? I don't know much about the workflow on Google Code.
> I have moved all my repositories to Bitbucket a long time ago, because
> it made project management with Mercurial shockingly easy.
Just email the update file to me. Then it's easy for me to check for
any differences (and sometimes catch changes already in the distribution
that didn't flow back to the maintainer). I also run a script to check
for mistakes before submitting the updated files.
--
hundred-and-one symptoms of being an internet addict:
10. And even your night dreams are in HTML.
/// Bram Moolenaar -- Br...@Moolenaar.net -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
Markus Mottl
I had to undo part of the patch. There seems to be a strange
performance problem with the <Plug> version of OCamlSwitch. Switching
becomes really slow with it.
Please refer to my Bitbucket repository (not a clone of the
Vim-repository) for the latest files, which do seem to work as usual.
Maybe you can find out what's going on:
https://bitbucket.org/mmottl/vim-files
Regards,
Markus
Markus Mottl http://www.ocaml.info markus...@gmail.com
Markus Mottl
worked out. I'll use your Mercurial repository in the future to make
sure that I'm working with the latest version of all files.
Would it improve your workflow if I cloned the Vim-repository on
Bitbucket and sent you an email with the appropriate pull command
whenever new files should be released? That way you could use
Mercurial right off the bat to deal with my incoming patches.
Regards,
Markus
Bram Moolenaar
Markus Mottl wrote:
> Ok, I'll send you the latest files once some minor issues have been
> worked out. I'll use your Mercurial repository in the future to make
> sure that I'm working with the latest version of all files.
>
> Would it improve your workflow if I cloned the Vim-repository on
> Bitbucket and sent you an email with the appropriate pull command
> whenever new files should be released? That way you could use
> Mercurial right off the bat to deal with my incoming patches.
distribution, not for including patches.
--
hundred-and-one symptoms of being an internet addict:
looks like.
Hirotaka Hamada
>There seems to be a strange
> performance problem with the <Plug> version of OCamlSwitch.
This is not a performance problem, but a mapping problem.
<Plug>OCamlSwitch and <Plug>OCamlSwitchNewWin were started with same sequence of character. So Vim was waiting in a while to solve this ambiguous mapping.
This patch fixes this problem to rename <Plug>OCamlWitch to be unique.
2013年7月23日火曜日 5時49分43秒 UTC+9 Markus Mottl:
Hirotaka Hamada
Nikolay Pavlov
On Jul 24, 2013 6:12 PM, "Hirotaka Hamada" <hirotaka.h...@gmail.com> wrote:
>
> Hi, Markus.
>
> >There seems to be a strange
> > performance problem with the <Plug> version of OCamlSwitch.
>
> I'm sorry for my incomplete patch.
>
> This is not a performance problem, but a mapping problem.
> <Plug>OCamlSwitch and <Plug>OCamlSwitchNewWin were started with same sequence of character. So Vim was waiting in a while to solve this ambiguous mapping.
>
> This patch fixes this problem to rename <Plug>OCamlWitch to be unique.
AFAIR Ingo or maybe somebody else invented wrapping this in () to prevent such problems: i.e. you just use "<Plug>(OCamlSwitch)" and do not care whether or not one prefixes other as it is just not possible. Any suffix character should work though, as far as it is only present at the end and never in the middle: "<Plug>OCamlSwitch$" is just as good.
>
> 2013年7月23日火曜日 5時49分43秒 UTC+9 Markus Mottl:
> > Hirotaka,
> >
> >
> >
> > I had to undo part of the patch. There seems to be a strange
> >
> > performance problem with the <Plug> version of OCamlSwitch. Switching
> >
> > becomes really slow with it.
> >
> >
> >
> > Please refer to my Bitbucket repository (not a clone of the
> >
> > Vim-repository) for the latest files, which do seem to work as usual.
> >
> > Maybe you can find out what's going on:
> >
> >
> >
> > https://bitbucket.org/mmottl/vim-files
> >
> >
> >
> > Regards,
> >
> > Markus
> >
> >
> >
> > On Sun, Jul 21, 2013 at 12:27 PM, Hirotaka Hamada
> >
> > <hirotaka.h...@gmail.com> wrote:
> >
> > > Hi,
> >
> > >
> >
> > > I have updated ftplugin/ocaml.vim.
> >
> > >
> >
> > > 1) use buffer-local mapping instead of global one
> >
> > > 2) provide <Plug>
> >
> > > 3) remove iabbrev (I think this is user specific setting.)
> >
> > >
> >
> > > Please check this patch.
> >
> > >
> >
> > > Regards.
> >
> > >
> >
> > > ----------
> >
> > > Hirotaka Hamada <hirotaka.h...@gmail.com>
> >
> >
> >
> >
> >
> >
> >
> > --
> >
> > Markus Mottl http://www.ocaml.info markus...@gmail.com
>
> --
> --
> You received this message from the "vim_dev" maillist.
> Do not top-post! Type your reply below the text you are replying to.
> For more information, visit http://www.vim.org/maillist.php
>
> ---
> You received this message because you are subscribed to the Google Groups "vim_dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to vim_dev+u...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>
Markus Mottl
already. Bram, could you please remove the error format in the OCaml
ftplugin file I just sent, assuming that's the correct way to
structure things these days? Thanks!
Hirotaka, what other patch are you referring to? I've made all
changes, but commented out your "OCaml switch" mappings that use
<Plug>. If I use those, it takes almost a second for Vim to switch
between source files, which is unacceptably slow. I have no idea why
that happens (I'm using Vim 7.3.762 installed via MacPorts).
Regards,
Markus
Markus Mottl
Bram, please disregard the OCaml-ftplugin file I've sent earlier. The
one I've attached now should have all patches (including the removal
of the efm-setting).
Btw., the compiler-settings don't load unless I enter ":compiler
ocaml". This may be annoying for beginners who might expect things to
work without having to change their Vim-configuration. What would be
the best way to set this as an overridable default?
Regards,
Markus
glts
> Btw., the compiler-settings don't load unless I enter ":compiler
> ocaml". This may be annoying for beginners who might expect things to
> work without having to change their Vim-configuration. What would be
> the best way to set this as an overridable default?
all of Vim's runtime files that sets a compiler for the user.
Beginners can learn. How about adding a note with a suggested
autocommand inside the plugin?
:autocmd FileType ocaml compiler ocaml
People need to look inside the plugin anyway to find out about the
mappings that you define for them.
Bram Moolenaar
Markus Mottl wrote:
> Thanks, Hirotaka, this was indeed a weird issue that seems fixed now.
>
> Bram, please disregard the OCaml-ftplugin file I've sent earlier. The
> one I've attached now should have all patches (including the removal
> of the efm-setting).
> Btw., the compiler-settings don't load unless I enter ":compiler
> ocaml". This may be annoying for beginners who might expect things to
> work without having to change their Vim-configuration. What would be
> the best way to set this as an overridable default?
a user preference then not.
--
For a moment, nothing happened.
Then, after a second or so, nothing continued to happen.
-- Douglas Adams, "The Hitchhiker's Guide to the Galaxy"
Markus Mottl
>> ocaml". This may be annoying for beginners who might expect things to
>> work without having to change their Vim-configuration. What would be
>> the best way to set this as an overridable default?
>
> If nearly everybody uses the same compiler it would be OK, but if it's
> a user preference then not.
the ":compiler ocaml" setting go? In the ftplugin file? Or
elsewhere?
Regards,
Markus
Bram Moolenaar
Markus Mottl wrote:
> On Thu, Jul 25, 2013 at 4:03 PM, Bram Moolenaar <Br...@moolenaar.net> wrote:
> > Markus Mottl wrote:
> >> Btw., the compiler-settings don't load unless I enter ":compiler
> >> ocaml". This may be annoying for beginners who might expect things to
> >> work without having to change their Vim-configuration. What would be
> >> the best way to set this as an overridable default?
> >
> > If nearly everybody uses the same compiler it would be OK, but if it's
> > a user preference then not.
>
> Nearly everybody uses the same compiler. In what standard file should
> the ":compiler ocaml" setting go? In the ftplugin file? Or
> elsewhere?
already for this buffer.
--
"Making it up? Why should I want to make anything up? Life's bad enough
as it is without wanting to invent any more of it."
-- Marvin, the Paranoid Android in Douglas Adams'