Seaside WASstServerAdaptor bug

[Leo O.]

Hi All, 

I think there is a small but dangerous bug in the WASstServerAdaptor class. The adaptor should respond all requests in a safe threading environment, but the sstRequest instance variable in this part of the #process: method, prevents this.

process: aNativeRequest

| response |

sstRequest := aNativeRequest.

self stats incrementCurrentTransactions.

[ response := super process: aNativeRequest ]

ensure: [ self stats decrementCurrentTransactions ].

^ response

A clean solution could be transform this instance variable into a temporal one, rewriting some others methods in the class to recieve the sstRequest later.

Regards,

Leo

[John O'Keefe]

Leo -

You are correct and we are already working on a solution.

John

[John O'Keefe]

Leo -

 

See https://groups.google.com/forum/#!topic/va-smalltalk/bXqrgcnqaeM for a patch.

 

John

[Leo O.]

Thanks John !

I have just tested it and works fine.