Code Assist not working in 8.5.2?

158 views
Skip to first unread message

Louis LaBrunda

unread,
Sep 21, 2012, 2:24:37 PM9/21/12
to va-sma...@googlegroups.com
Hi All,

Code Assist doesn't seem to be working or turned on in 8.5.2.  What do I need to do to turn it on?

Lou

Marten Feldtmann

unread,
Sep 21, 2012, 3:31:44 PM9/21/12
to va-sma...@googlegroups.com
I noticed this also - no idea why ... because sometimes it worked ...

Marten

Marten Feldtmann

unread,
Sep 22, 2012, 3:18:46 PM9/22/12
to va-sma...@googlegroups.com
When I open a Workspace it is working out of the box - in the source code widget of a browser it does not work any more ... any idea or can you confirm it.

Seth Berman

unread,
Sep 22, 2012, 3:52:46 PM9/22/12
to va-sma...@googlegroups.com
Is this an install to an existing manager or fully clean?  Windows?
I can't yet confirm this on a clean install of 8.5.2.

You can try the following to restore default CA settings in the manager:
System Transcript->Options->Code Assist->Edit...
Change the 'Filter By:' to read 'All'
Press the 'Restore All Defaults' button on the bottom left.
Close the config window.

Try it again...still seeing the issue?

Seth Berman

unread,
Sep 22, 2012, 3:55:29 PM9/22/12
to va-sma...@googlegroups.com
Also I should mention....if you restore the default settings...close all open browsers, workspaces, inspectors and debuggers before trying it again

Marten Feldtmann

unread,
Sep 22, 2012, 4:10:58 PM9/22/12
to va-sma...@googlegroups.com, Seth Berman
Am 22.09.2012 21:52, schrieb Seth Berman:
> Is this an install to an existing manager or fully clean? Windows?

Existing Manager
>
> You can try the following to restore default CA settings in the manager:
> System Transcript->Options->Code Assist->Edit...
> Change the 'Filter By:' to read 'All'
> Press the 'Restore All Defaults' button on the bottom left.
> Close the config window.
>
> Try it again...still seeing the issue?
>
Yes

Seth Berman

unread,
Sep 22, 2012, 7:29:26 PM9/22/12
to va-sma...@googlegroups.com, Seth Berman, marten.f...@googlemail.com
I've been trying to reproduce it for a while now in different configurations and setups...but no joy.
You say its in a browser...exactly what kind of browser is it.
You said it works for workspaces...how about inspectors and/or debuggers?

Once upon a time...I thought I saw some z-order issues but I could never repeat it...it may be that the popup is hiding behind the browser widget.
This can be found by setting the "Max Visible Suggestions"  in "Look and Feel" options to something like 50, and then requesting code assist on an empty partial so we get a lot of suggestions.
If this is the case, you will see the popup show up from behind.

-- Seth

Marten Feldtmann

unread,
Sep 23, 2012, 3:46:10 AM9/23/12
to va-sma...@googlegroups.com, Seth Berman
Am 23.09.2012 01:29, schrieb Seth Berman:
> I've been trying to reproduce it for a while now in different
> configurations and setups...but no joy.
> You say its in a browser...exactly what kind of browser is it.
> You said it works for workspaces...how about inspectors and/or debuggers?
>

I tested this with a new mgr85.dat and got the following results (here
W7/64bit):

Workspaces: Yes
Inspectors: No
Debuggers: Yes
ClassBrowser: Yes
ApplicationsBrowser: No
HierarchyBrowser: Yes
Script Editor: no


> Once upon a time...I thought I saw some z-order issues but I could
> never repeat it...it may be that the popup is hiding behind the
> browser widget.
> This can be found by setting the "Max Visible Suggestions" in "Look
> and Feel" options to something like 50, and then requesting code
> assist on an empty partial so we get a lot of suggestions.
> If this is the case, you will see the popup show up from behind.
>

No changes here ...

Seth Berman

unread,
Sep 23, 2012, 1:50:40 PM9/23/12
to va-sma...@googlegroups.com, Seth Berman, marten.f...@googlemail.com
Thanks Marten...found it.  Looks like some regressions came in as a result of the inspector inclusion.
I'm opening a case and will put a patch together.

BTW, everything you listed above I was able to reproduce except for the inspector.  Can you tell me the
class of the inspector that you were using?  Thanks

-- Seth

Jan van de Sandt

unread,
Oct 9, 2012, 8:17:57 AM10/9/12
to va-sma...@googlegroups.com, Seth Berman
Hello Seth,

Is a patch for the Code Assist problems in version 8.5.2 already available? Or is there some setting or workaround so that we can get Code Assist working in the browsers again? I really miss this very useful feature ...

Jan.

--
You received this message because you are subscribed to the Google Groups "VA Smalltalk" group.
To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/x_iAhIRcQZoJ.

To post to this group, send email to va-sma...@googlegroups.com.
To unsubscribe from this group, send email to va-smalltalk...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/va-smalltalk?hl=en.

Seth Berman

unread,
Oct 9, 2012, 1:21:59 PM10/9/12
to va-sma...@googlegroups.com, Seth Berman
Hello Jan,

Attached is the *unofficial* patch I've worked up so far and will restore CA to the application browsers.

Attached are exported applications to:

1. Add code assist back to Application, Applications and AbtScript Browsers
2. Fix code completions in inspectors when the completion request falls within
    the range of the debugPrintString size.


Regards,
Seth
b232_CA_Fixes1.zip

Jan van de Sandt

unread,
Oct 12, 2012, 4:33:46 AM10/12/12
to va-sma...@googlegroups.com
Hello Seth,

Thank you for the fixes. Code Assist now works fine again.

Jan.

To view this discussion on the web visit https://groups.google.com/d/msg/va-smalltalk/-/CYfJq65q8JcJ.

Louis LaBrunda

unread,
Oct 12, 2012, 4:57:13 PM10/12/12
to va-sma...@googlegroups.com
Hello Seth,

Thank you for the fixes. And thanks to Marten for answering all your questions.  Code Assist now works great again.

Lou

Dusty

unread,
Oct 17, 2012, 4:00:18 AM10/17/12
to va-sma...@googlegroups.com, Seth Berman
Hi Seth

Sorry for my ignorence (as mentioned, I've been developing for 6 months or so) but how do I patch my VAST with your fix?
You can learn me! heh
Thanks
Dusty

Seth Berman

unread,
Oct 17, 2012, 3:04:18 PM10/17/12
to va-sma...@googlegroups.com, Seth Berman
Hi Dusty,

Sure...no problem.

1. Download and unzip the file attached to this thread: b232_CA_Fixes1.zip
   - You will now have a file named b232_CA_Fixes1.dat, which contains two
     updated versions of applications that have been exported to this file
 
2. Open an abt vast image

3. System Transcript Menu -> Tools -> Manage Applications
   - Click on the resulting Application manger windows
  
4. Now you will import the applications from the patch file
   Application Manager Menu -> Applications -> Import/Export -> Import Applications...
   
5. Erase 'localhost' from the resulting popup so the text field is blank and press 'Ok'

6. Select the patch file, which you unzipped, from the file dialog and press 'Open'

7. You will now see a selection required dialog, from which you will select all names and versions
   from the left side and use the '>>' button to commit to the selection to the right side.  At the
   end of this, you should see the following in the Selected Version column
   StsCodeAssistApp b232 + 50057 a
   StsPowerTools b232 + 50058 a
   Press 'Ok' when finished to import these fixes into your manager.
   
8.  Now the code is in your manager repository, but not loaded into you live image...so we need to do that.
    From the Application Manager, find and select StsPowerTools in the left pane.
Bring up a popup menu on it -> Load -> Another Edition...
Select 'StsPowerTools b232 + 50058 a' and press ok.
9.  Now we load the other part of the patch
    From the Application Manager, find and select StsCodeAssistApp in the left pane.
Bring up a popup menu on it -> Load -> Another Edition...
Select 'StsCodeAssistApp b232 + 50057 a' and press ok.
You should now have the patch not only imported into your manager, but also loaded into your running image.
In order to retain what you just did, you will probably want to save your image.  Otherwise, you will need to
repeat steps 8 and 9 every time you start a new image.

Hope this helps...let me know if you need additional help

Regards

--Seth

jtu...@objektfabrik.de

unread,
Mar 11, 2013, 8:14:20 PM3/11/13
to va-sma...@googlegroups.com, Seth Berman
Hi Seth,

it seems the fix does not work for the workspace in INspectors (the one you can toggle on/off in Inspectors). Is that a feature?

Joachim

Seth Berman

unread,
Mar 11, 2013, 10:46:14 PM3/11/13
to va-sma...@googlegroups.com, Seth Berman
Hi Joachim,

No..it was just simply never enabled.  Looks like a simple fix to enable...I'll look at doing this or the up coming release.

The fix is trivial enough that I will just put it here if you are really interested.
Just add the following line to the end of StsWorkspaceInspector>>initializeAfterRealize

(self stsRequestCodeAssistOn: wsTextWidget contextProvider: self) ifNotNil: [:codeAssist | codeAssist connect].


...and that should do it

Seth Berman

unread,
Mar 11, 2013, 10:52:50 PM3/11/13
to va-sma...@googlegroups.com
Case 50546 opened: Add Code Assist to the workspace portion of an StsWorkspaceInspector
Reply all
Reply to author
Forward
0 new messages