TracAutocompleteUsersPlugin and custom fields failing on comment modification

[Mo]

Hi,

with Trac-1.2.3 and TracAutocompleteUsersPlugin-0.4.6.dev0-py2.7.egg we have errors when trying to modify an existing ticket comment.
Writing new comments works fine.

The error is something about our custom field "tester" that is configured like this:

[ticket-custom]
test = select
test.label = Test
test.options = |open|done
test.order = 11
test.value =
tester = text
tester.label = Tester
tester.order = 10
tester.value =

Trac detected an internal error:

KeyError: u'field_tester'

Most recent call last:

File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 647, in _dispatch_request
  dispatcher.dispatch(req)
File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 215, in dispatch
  chosen_handler = self._pre_process_request(req, chosen_handler)
File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 455, in _pre_process_request
  chosen_handler = filter_.pre_process_request(req, chosen_handler)
File "build/bdist.linux-x86_64/egg/autocompleteusers/autocompleteusers.py", line 85, in pre_process_request
  fixup_user_list(FIELDS_OPTION[1])
File "build/bdist.linux-x86_64/egg/autocompleteusers/autocompleteusers.py", line 82, in fixup_user_list
  req.args[arg] = _fixup_cc_list(req.args[arg])

Is this really part of the TracAutocompleteUsersPlugin and should I file a bug report to that plugin?

Best regards.

[Jun Omae]

Hi,

On Wed, Jul 24, 2019 at 5:12 PM Mo <burcheri...@gmail.com> wrote:
> Trac detected an internal error:
>
> KeyError: u'field_tester'
>
>
> Most recent call last:
>
> File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 647, in _dispatch_request
> dispatcher.dispatch(req)
> File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 215, in dispatch
> chosen_handler = self._pre_process_request(req, chosen_handler)
> File "/usr/lib64/python2.7/site-packages/trac/web/main.py", line 455, in _pre_process_request
> chosen_handler = filter_.pre_process_request(req, chosen_handler)
> File "build/bdist.linux-x86_64/egg/autocompleteusers/autocompleteusers.py", line 85, in pre_process_request
> fixup_user_list(FIELDS_OPTION[1])
> File "build/bdist.linux-x86_64/egg/autocompleteusers/autocompleteusers.py", line 82, in fixup_user_list
> req.args[arg] = _fixup_cc_list(req.args[arg])
>
> Is this really part of the TracAutocompleteUsersPlugin and should I file a bug report to that plugin?

Yes. That's a TracAutocompleteUsersPlugin issue. Could you please
create a new ticket?
I think the same issue is also lead by wrong settings in [autocomplete] section.

====
diff --git a/autocompleteusersplugin/trunk/autocompleteusers/autocompleteusers.py
b/autocompleteusersplugin/trunk/autocompleteusers/autocompleteusers.py
index f2ebf8086..6e884a0f4 100644
--- a/autocompleteusersplugin/trunk/autocompleteusers/autocompleteusers.py
+++ b/autocompleteusersplugin/trunk/autocompleteusers/autocompleteusers.py
@@ -79,7 +79,8 @@ class AutocompleteUsers(Component):
def fixup_user_list(option_name):
for field in self.config.getlist(SECTION_NAME, option_name):
arg = 'field_' + field
- req.args[arg] = _fixup_cc_list(req.args[arg])
+ if arg in req.args:
+ req.args[arg] = _fixup_cc_list(req.args[arg])

fixup_user_list(FIELDS_OPTION[0])
fixup_user_list(FIELDS_OPTION[1])
====

--
Jun Omae <jun...@gmail.com> (大前 潤)

[Mo]

Am Donnerstag, 25. Juli 2019 08:46:31 UTC+2 schrieb Jun Omae:

Yes. That's a TracAutocompleteUsersPlugin issue. Could you please
create a new ticket?

 

-> https://trac-hacks.org/ticket/13577

[RjOllos]

New version has been published to PyPI: https://pypi.org/project/TracAutocompleteUsersPlugin/

- Ryan