WikiTableMacro and Trac-1.0

[Brettschneider Falk]

I get

Trac detected an internal error:
NotImplementedError: pre-0.11 Wiki macro SQLTable by provider <class 'wikitable.table.SQLTable'> no longer supported

Why doesn't it work with 1.0? I checked the sources of this plugin but there is no version check in it.

CU, F@lk

----
R&D Software
Baumer Optronic GmbH
www.baumer.com



Gesch?ftsf?hrer: Dr. Albert Schmidt* Dr. Oliver Vietze
Sitz der Gesellschaft: Radeberg
Amtsgericht Dresden: HRB 15379
Ust. ID: DE 189714583

[Steffen Hoffmann]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 18.12.2012 20:50, Brettschneider Falk wrote:
> I get
>
> Trac detected an internal error:
> NotImplementedError: pre-0.11 Wiki macro SQLTable by provider <class 'wikitable.table.SQLTable'> no longer supported
>
> Why doesn't it work with 1.0? I checked the sources of this plugin but there is no version check in it.

Seems like the old way, that wiki macro worked before Trac-0.11 by using

WikiMacroBase.render_macro

doesn't work anymore, and you'll have to use

WikiMacroBase.expand_macro

instead. NotImplementedError just comes from finally removing the old
compat method. It was a depreciation notice before, knowing it i.e. from
older versions of IncludeMacro.


Steffen Hoffmann
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlDQ6VsACgkQ31DJeiZFuHfNmQCfb7HCKvFa55H6WYT79O2uJe0e
xQsAnRxim8IPE6L0Cd8kbur7bpB2Q2hM
=iDRA
-----END PGP SIGNATURE-----

[Brettschneider Falk]

Steffen Hoffmann wrote:
> Seems like the old way, that wiki macro worked before Trac-0.11 by using
>
> WikiMacroBase.render_macro
>
> doesn't work anymore, and you'll have to use
>
> WikiMacroBase.expand_macro
>
> instead.

Thanks Steffen! After I gave up digging in the API porting pages I've found a changeset of osimons [1] and patch it this way. It's available as Trac-hacks ticket [2] now.

[1] https://bitbucket.org/osimons/trac-estimationtoolsplugin/diff/estimationtools/burndownchart.py?diff2=ba1a25546115&at=trunk
[2] http://trac-hacks.org/ticket/10718

[Steffen Hoffmann]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 19.12.2012 08:48, Brettschneider Falk wrote:
> Steffen Hoffmann wrote:
>> Seems like the old way, that wiki macro worked before Trac-0.11 by
>> using
>>
>> WikiMacroBase.render_macro
>>
>> doesn't work anymore, and you'll have to use
>>
>> WikiMacroBase.expand_macro
>>
>> instead.
>
> Thanks Steffen! After I gave up digging in the API porting pages I've
> found a changeset of osimons [1] and patch it this way. It's
> available as Trac-hacks ticket [2] now.

Ideal. This is a success for all of us.
+1 for testing and taking care of the issue including required
investigation on the issue.
+1 for asking to the mailing-list first.
+1 for opening a ticket AFTER investigation on the issue.
+1 for further research and providing a patch.
In fact all the steps towards a ready-made solution for the maintainer.

Your way to setup and improve your own Trac application yields
significant contributions back to the Trac plugin developer community.
Glad to have you around.

Steffen Hoffmann
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlDR7eIACgkQ31DJeiZFuHeK6gCgldxRuEbbEozJqHgLK4g11s3L
oVYAn154J2Q/Y0bTRbmmSuylrfAhLBgm
=g+Bi
-----END PGP SIGNATURE-----

[RjOllos]

On Wednesday, December 19, 2012 8:40:07 AM UTC-8, hasienda wrote:

[...]

Ideal. This is a success for all of us.
+1 for testing and taking care of the issue including required
investigation on the issue.
+1 for asking to the mailing-list first.
+1 for opening a ticket AFTER investigation on the issue.
+1 for further research and providing a patch.
In fact all the steps towards a ready-made solution for the maintainer.

Fix has been applied (not sure why i became maintainer for this one, but must have had some ambitions for the macro at some point). Thanks falkb!