Numerous problems with Spam Filter plugin (v1.0)

[Nicolas MARTIN]

Hello Trac community,


I installed the plugin from the last revision of the branch restricted
to Trac 1.0.x releases.

First I got my usual installation issues with our outdated release
1.0.1: 'from trac.util.html import tag' => 'from trac.util.html import
html as tag' (all changes are in the attached file).

Then 2 admin pages crash: 'Monitoring' (/admin/spamfilter/monitor) and
'Reports' (/admin/spamfilter/report). But the log refers to
WikiAutoCompletePlugin

2018-06-10 20:57:39,539 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 497,
in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 224,
in dispatch
    self._post_process_request(req, *resp)
  File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 338,
in _post_process_request
    resp = f.post_process_request(req, *resp)
  File "build/bdist.linux-x86_64/egg/wikiautocomplete/web_ui.py", line
60, in post_process_request
    if context_or_page and context_or_page.resource:
AttributeError: 'int' object has no attribute 'resource'

Finally I tried to delete an unused account from 'Users' with 'Remove'
button: Trac seems to proceed but ends in a page from the webserver
outside of our Trac.
If I goes back the account about to be removed is still there,
AccountManager plugin is in version 0.5.


Regards,
Nicolas

[Peter Suter]

Hello

I created https://trac-hacks.org/ticket/13439 for this, thanks.

[RjOllos]

On Sunday, June 10, 2018 at 1:53:56 PM UTC-7, Nicolas MARTIN wrote:

Hello Trac community,


I installed the plugin from the last revision of the branch restricted
to Trac 1.0.x releases.

First I got my usual installation issues with our outdated release
1.0.1: 'from trac.util.html import tag' => 'from trac.util.html import
html as tag' (all changes are in the attached file).

Committed in r16632.

https://trac.edgewall.org/changeset/16632

 

Then 2 admin pages crash: 'Monitoring' (/admin/spamfilter/monitor) and
'Reports' (/admin/spamfilter/report). But the log refers to
WikiAutoCompletePlugin

2018-06-10 20:57:39,539 Trac[main] ERROR: Internal Server Error:
Traceback (most recent call last):
   File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 497,
in _dispatch_request
     dispatcher.dispatch(req)
   File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 224,
in dispatch
     self._post_process_request(req, *resp)
   File "/usr/lib/python2.7/site-packages/trac/web/main.py", line 338,
in _post_process_request
     resp = f.post_process_request(req, *resp)
   File "build/bdist.linux-x86_64/egg/wikiautocomplete/web_ui.py", line
60, in post_process_request
     if context_or_page and context_or_page.resource:
AttributeError: 'int' object has no attribute 'resource'

Finally I tried to delete an unused account from 'Users' with 'Remove'
button: Trac seems to proceed but ends in a page from the webserver
outside of our Trac.
If I goes back the account about to be removed is still there,
AccountManager plugin is in version 0.5.

Which external site?

- Ryan

[Nicolas MARTIN]

Tanks for the ticket and the commit.

Regarding the last issue, it seems to be a little issue with the targeted URL of AccountManager admin page:
The good one is $HOSTNAME/$PROJECT/admin/accounts/users and I got $HOSTNAME/admin/accounts/users ($PROJECT missing).

So probably nothing tricky I guess.

Nicolas

--
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to trac-users+...@googlegroups.com.
To post to this group, send email to trac-...@googlegroups.com.
Visit this group at https://groups.google.com/group/trac-users.
For more options, visit https://groups.google.com/d/optout.

[RjOllos]

On Monday, June 11, 2018 at 9:39:08 AM UTC-7, Nicolas MARTIN wrote:

Tanks for the ticket and the commit.

Regarding the last issue, it seems to be a little issue with the targeted URL of AccountManager admin page:
The good one is $HOSTNAME/$PROJECT/admin/accounts/users and I got $HOSTNAME/admin/accounts/users ($PROJECT missing).

So probably nothing tricky I guess.

Nicolas

Fixed in r16633:

https://trac.edgewall.org/changeset/16633

- Ryan

[Nicolas MARTIN]

Thanks, I found that there is the same kind of error in the URL displayed as 'Source' from the 'Last login' column for 'All' view.

Nicolas

[RjOllos]

On Monday, June 11, 2018 at 4:23:57 PM UTC-7, Nicolas MARTIN wrote:

Thanks, I found that there is the same kind of error in the URL displayed as 'Source' from the 'Last login' column for 'All' view.

Nicolas

Fixed in r16639:

https://trac.edgewall.org/changeset/16639

- Ryan

[Nicolas MARTIN]

Hello,

After updating the plugin, the name of the project is still missing in the relative targeted URL.
It's like nothing has changed with the previous commit.

Nicolas

On 11/06/2018 23:04, RjOllos wrote:

[Ryan Ollos]

On Tue, Jun 26, 2018 at 1:20 PM Nicolas MARTIN <ntm...@locean.upmc.fr> wrote:

Hello,

After updating the plugin, the name of the project is still missing in the relative targeted URL.
It's like nothing has changed with the previous commit.

Nicolas

Please do a hard refresh of the page. If that doesn't fix the issue, please send a screen capture highlighting whatever link you are having trouble with.

[Nicolas MARTIN]

You can find in the 2 attached files the view of the 'Remove' button involved and the HTML code behind with the truncated URL for action form.

[RjOllos]

On Tuesday, June 26, 2018 at 3:22:45 PM UTC-7, Nicolas MARTIN wrote:

You can find in the 2 attached files the view of the 'Remove' button involved and the HTML code behind with the truncated URL for action form.

Unfortunately there are many URLs in the plugin templates that aren't coded correctly. I fixed a few more in r16683:

https://trac.edgewall.org/changeset/16683

- Ryan