[PATCH stable] installer: not enable mercurial_keyring by default for now (fixes #2587)

[Yuya Nishihara]

# HG changeset patch
# User Yuya Nishihara <yu...@tcha.org>
# Date 1368107900 -32400
# Thu May 09 22:58:20 2013 +0900
# Branch stable
# Node ID 720bf50fccc5174f2000d9c3ff24571795bd49ab
# Parent e978edeac68aac07827390c1069086d6e527bbe6
installer: not enable mercurial_keyring by default for now (fixes #2587)

#1690 says mercurial_keyring causes hard crash in our package, and the problem
seems not resolved yet. So it isn't safe to enable keyring by default.

Backed out 8a47847543b2.

diff --git a/win32/mercurial.rc b/win32/mercurial.rc
--- a/win32/mercurial.rc
+++ b/win32/mercurial.rc
@@ -42,11 +42,6 @@ ssh = "TortoisePlink.exe" -ssh -2
;git = false
;nodates = false

-; Enable mercurial_keyring by default on Windows. It stores passwords
-; for https:// and SMTP using the WIN32 crypto APIs.
-[extensions]
-mercurial_keyring =
-
;
; Keyword extension example configuration. To use, one must
; enable the keyword extension, then uncomment and modify these

[Steve Borho]

On Thu, May 9, 2013 at 9:04 AM, Yuya Nishihara <yu...@tcha.org> wrote:

# HG changeset patch
# User Yuya Nishihara <yu...@tcha.org>
# Date 1368107900 -32400
#      Thu May 09 22:58:20 2013 +0900
# Branch stable
# Node ID 720bf50fccc5174f2000d9c3ff24571795bd49ab
# Parent  e978edeac68aac07827390c1069086d6e527bbe6
installer: not enable mercurial_keyring by default for now (fixes #2587)

#1690 says mercurial_keyring causes hard crash in our package, and the problem
seems not resolved yet. So it isn't safe to enable keyring by default.

Backed out 8a47847543b2.

When I get home next Tuesday, I'm going to generate some installers with the latest version of pywin32 and see if this resolves the issue.

 

diff --git a/win32/mercurial.rc b/win32/mercurial.rc
--- a/win32/mercurial.rc
+++ b/win32/mercurial.rc
@@ -42,11 +42,6 @@ ssh = "TortoisePlink.exe" -ssh -2
 ;git = false
 ;nodates = false

-; Enable mercurial_keyring by default on Windows.  It stores passwords
-; for https:// and SMTP using the WIN32 crypto APIs.
-[extensions]
-mercurial_keyring =
-
 ;
 ; Keyword extension example configuration.  To use, one must
 ; enable the keyword extension, then uncomment and modify these

--
You received this message because you are subscribed to the Google Groups "TortoiseHg Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to thg-dev+u...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
Steve Borho

[Yuya Nishihara]

On Thu, 9 May 2013 23:20:20 -0500, Steve Borho wrote:
> On Thu, May 9, 2013 at 9:04 AM, Yuya Nishihara <yu...@tcha.org> wrote:
>
> > # HG changeset patch
> > # User Yuya Nishihara <yu...@tcha.org>
> > # Date 1368107900 -32400
> > # Thu May 09 22:58:20 2013 +0900
> > # Branch stable
> > # Node ID 720bf50fccc5174f2000d9c3ff24571795bd49ab
> > # Parent e978edeac68aac07827390c1069086d6e527bbe6
> > installer: not enable mercurial_keyring by default for now (fixes #2587)
> >
> > #1690 says mercurial_keyring causes hard crash in our package, and the
> > problem
> > seems not resolved yet. So it isn't safe to enable keyring by default.
> >
> > Backed out 8a47847543b2.
> >
>
> When I get home next Tuesday, I'm going to generate some installers with
> the latest version of pywin32 and see if this resolves the issue.

Sounds great.
I hope I can drop this backout patch. ;)

Regards,

[Yuya Nishihara]

Hi,

I heard on twitter that 2.8.1 still crashes if mercurial_keyring is enabled.
So for now, it will be safe to disable keyring by default.

Regards,

[Steve Borho]

Feel free to push that to stable.  I will be out of town this week (vacation this time) so 2.8.2 will be about a week late. 

--
Steve Borho

[Yuya Nishihara]

Okay, pushed to stable.

Regards,