5.3 builds

[Matt Harbison]

These Windows and macOS builds have hg 5.3.1:

https://bitbucket.org/matt_harbison/thg/downloads/

Still hoping to get these on www.mercurial-scm.org at some point, and should have a 5.3.1 build in the next couple of days if no issues pop up.

[Daniel Comeau]

When trying to clone a Git repository (using the HgGit extension), I get an error message:

abort: No module named brotli!

[Code: 255]

My clone command:

hg clone --verbose https://github.com/js-cookie/js-cookie.git "C:\Temp\js-cookie HgGit Test"

Daniel Comeau

[Matt Harbison]

On Friday, March 6, 2020 at 9:41:50 AM UTC-5, Daniel Comeau wrote:

When trying to clone a Git repository (using the HgGit extension), I get an error message:

abort: No module named brotli!

[Code: 255]

My clone command:

hg clone --verbose https://github.com/js-cookie/js-cookie.git "C:\Temp\js-cookie HgGit Test"

Daniel Comeau

It looks like this is mentioned towards the end of this bug report:

    https://bitbucket.org/tortoisehg/thg/issues/5140/hg-git-abort-no-module-named-selectors

I'm not sure that I'm comfortable downgrading urllib3 (which is a dependency of requests), and then hacking up certifi to work with py2exe.  This build process is crazy as it is.  Also, I'm not sure if hg-git supports 5.3 yet.

I'll look into trying to get the user level site-package visible to the app like on macOS, so you can install hg-git (and whatever dependencies) yourself.  That will probably be better if hg-git is lagging behind anyway.  In the meantime, you might want to look at the suggestion in that bug report about hacking library.zip.

[Matt Harbison]

Apparently py2exe doesn't run site.py, so it doesn't run the custom sitecustomize.py, so we can't use the same mechanism as the macOS app.  But I see that contrib/hg is the base script run by py2exe, and it already drops cwd from `sys.path`.  Yuya, do you think it's reasonable to:

    - extend `sys.path` there with `os.path.join(os.environ['APPDATA'], 'Python', 'Python2.7', 'site-packages')` (which corresponds to `pip install --user`)

    - drop hg-git and dependencies

    - tell users that it's on them to install hg-git dependencies via pip, and clone hg-git from source

?

It seems like with hg-git lagging behind a bit for awhile now and the complex dependencies, it's not something we can bundle well.  But this would still provide a mechanism to use it.

[Yuya Nishihara]

I'm okay with that. Windows packaging sucks in general, so let's make it
easier for us to manage.

[Pierre-Yves David]

As far as I know, hg-git as a pretty large user base. What would be the
official way to set it up after this get dropped ?

--
Pierre-Yves David

[Matt Harbison]

It looks like it’s been broken on Windows for a long time. (See that bug report I referenced, or search for hg-git on the bug tracker).

That said, it *should* be as simple as:

$ py -2 -m pip install —user dulwich brotli urllib3
# change `extensions.hggit=` to `extensions.hggit=path/to/local/clone`

I tried something like that last night by building the installer with the change proposed above, and deleting those dependencies from library.zip. The stacktrace changed so that now it complains about not being able to find `dulwich.errors`. There’s a thg bug report about that too, but no helpful info there. When I import it running system python, it works. So it should work here too.

[Matt Harbison]

On Friday, March 6, 2020 at 9:41:50 AM UTC-5, Daniel Comeau wrote:

When trying to clone a Git repository (using the HgGit extension), I get an error message:

abort: No module named brotli!

[Code: 255]

My clone command:

hg clone --verbose https://github.com/js-cookie/js-cookie.git "C:\Temp\js-cookie HgGit Test"

Daniel Comeau

Give this build a try:

    https://bitbucket.org/matt_harbison/thg/downloads/tortoisehg-stable-5.3.107.1107-x64.msi

You will need to have python2.7 installed somewhere, and install the dependencies manually:

    pip2 install --user dulwich urllib3 brotli ipaddress

This build looks for extra packages in %APPDATA%\python\python27\site-packages, so you *must* use the `--user` flag to put them there.  For the record, that installed brotli-1.0.7 dulwich-0.19.15 ipaddress-1.0.23 and urllib3-1.25.8.  I ran hg-git 6479726a6ff9 from source, which I got here:

    https://foss.heptapod.net/mercurial/hg-git

Please report back any issues, so we can get the 5.3.1 build out.  Maybe we could keep bundling those dependencies, but it seems like we absolutely can't bundle certifi.  (I seem to recall it using __file__ when I looked at it some months ago.)  And if one dependency needs to be manually installed, then I'd say the end user can install them all.  I think it's ultimately better not *not* bundle hg-git, so that it can be upgraded when needed.  It's not clear to me that it supports 5.3 yet, though the clone command above completed successfully for me.