On test_code_quality.py

[Saurabh Jha]

Hi,

As many of you have already noticed, while running the tests, this
test fails. I would love to help in solving this problem but I am not
able to find previous discussion on this topic. Has anyone pondered
about this problem before?


Your's

-Saurabh Jha

[krastano...@gmail.com]

Are you saying that it is failing in master?

This test is not about functionality, rather just checking that the
code is nicely written. For instance it checks that you do not have
trailing white-spaces.

[Sergiu Ivanov]

On Fri, Aug 3, 2012 at 10:46 AM, krastano...@gmail.com
<krastano...@gmail.com> wrote:
>>
>> As many of you have already noticed, while running the tests, this
>> test fails. I would love to help in solving this problem but I am not
>> able to find previous discussion on this topic. Has anyone pondered
>> about this problem before?
>
> Are you saying that it is failing in master?

Works for me, with Python 2.7 on 64-bit Linux.

Saurabh, could you specify the version of the interpreter and the
environment you are using?

Sergiu

[Chris Smith]

If you post the error that is given, perhaps we can help (if you haven't figured it out already). 

[Sergiu Ivanov]

On Fri, Aug 3, 2012 at 8:08 PM, Saurabh Jha <saurab...@gmail.com> wrote:
> I have made the code pass all the tests(doctest and test). I commited
> it and pushed it. Now if I try to make a pull request, the following
> message appears.
> Oops! There's already a pull request for SaurabhJha/kauers Try a
> different branch or view the pull request?
> Can someone help me with this? I don't want to change the branch.
> Here's my commit
> https://github.com/SaurabhJha/sympy/commit/301a2ce91eb1f7413201e7df4d6d20f2ad51d410

Just click View the Pull Request, if that's clickable. In any case,
your pull request is here [0].

Take a look, your new commit is already there, so you don't have to
open a pull request, since this change has already been added to your
own earlier pull request.

Sergiu

[0] https://github.com/sympy/sympy/pull/1452

[Saurabh Jha]

I am extremely sorry for my last naive post. I immediately discovered it, and tried to  deleted that post, so that no one is distracted by it. It seems it wasen't deleted

Apologies,

-Saurabh Jha

[Sergiu Ivanov]

On Fri, Aug 3, 2012 at 8:55 PM, Saurabh Jha <saurab...@gmail.com> wrote:
> I am extremely sorry for my last naive post. I immediately discovered it,
> and tried to deleted that post, so that no one is distracted by it. It
> seems it wasen't deleted

Don't worry :-)

The reason why I still replied to the post is that I don't use the
Google Groups interface to read SymPy mail; instead, I rely on E-mail
messages, which obviously cannot be deleted once they are in my Inbox.

Sergiu

[Ondřej Čertík]

On Fri, Aug 3, 2012 at 10:55 AM, Saurabh Jha <saurab...@gmail.com> wrote:
> I am extremely sorry for my last naive post. I immediately discovered it,
> and tried to deleted that post, so that no one is distracted by it. It
> seems it wasen't deleted

No problem. Now you know how to send pull requests. :)

Ondrej