Re: [sympy] discussion on pull request #1226: decorator is an antipythonic?

10 views
Skip to first unread message

krastano...@gmail.com

unread,
Jul 1, 2012, 2:47:32 PM7/1/12
to sy...@googlegroups.com
It is mostly my fault that this is stuck. I said that simply using
default named arguments would be a better decision (see discussion on
the pull request page). However if someone else gives a +1 one on this
topic, the PR should be ok for merging.

I would like to implement what I proposed, however I still have not
found the time. It should be quite straightforward, though; just the
usual named arguments stuff.

krastano...@gmail.com

unread,
Jul 1, 2012, 4:57:04 PM7/1/12
to sy...@googlegroups.com
Slightly off topic, you have already merged contributions, however I
am not sure that you were added to the AUTHORS file.

alexandr popov

unread,
Jul 1, 2012, 8:17:25 PM7/1/12
to sy...@googlegroups.com
You talked me into it =) I implement it "simply" with default argument
(and make another PR). If this implementation will be better, 
it will be possible to abandon decorator.

alexandr popov

unread,
Jul 1, 2012, 8:21:17 PM7/1/12
to sy...@googlegroups.com
Yes, you're right. One of PR was merged yesterday.
Reply all
Reply to author
Forward
0 new messages