> I don't think it's quite as dire as that. If you ignore issues related to adaptation, the resulting Markov chain is fine. Consider it this way:
I disagree.
> 1. Assume we define the hyperspherical parameters on a limited domain, e.g.., x_\in [0,2pi]. This means we only need one term of that infinite sum, which is what we're doing now.
The hyper spherical angles are always defined on [0, 2pi] -- otherwise they wouldn't be hyper spherical angles. The infinite sum comes when we try to extend [0, 2pi] to \mathcal{R} -- if modular division shows up then an infinite number of terms are required.
> 2. When we do HMC (or MH) there is a question of what to do if the parameter ends up outside of [0,2pi]. One thing we could do is at the end of every step, reset the coordinate modulo 2pi, e.g., x <- mod(x',2pi). This is fine because we know the mapping is completely invariant to shifts +/- 2pi so nothing changes. You can think of this another way by assuming that we setup a local chart where y \in [x - pi, x + pi], do the simulation in y, and then go back to the global chart as a representation.
Modular division is not equivalent to an atlas. In particular, an atlas is assumed to be a minimal covering of charts: for S^{1} that would be two charts, whereas the modular division defines an infinite number of charts. Also, charts can't be defined on [0, 2pi] or (0, 2pi) or (0, 2pi] or [0, 2pi), because the resulting boundary isn't open.
But more importantly if we work in charts then we can't do expectations in the typical fashion. We have to compute expectations on each chart and then average the results in any overlap using partitions of unity -- not exactly something you'd want to implement. Essentially, that's what the infinite sum in the change of variables is trying to represent anyways.
> 3. Finally, if you never need to do any kind of estimation or diagnostics in x then you never actually need to bother correcting back to [0,2pi] during sampling.
If adaptation or diagnostics weren't necessary then HMC would have been adopted by everyone a long time ago. Not exactly realistic example.